• Icon: Bug Bug
    • Resolution: Fixed
    • Icon: Trivial Trivial
    • core

      As commented by James on the previous PR, the trailing dots are valid in URL.

          [JENKINS-51158] Allow trailing dot in Root URL

          Wadeck Follonier created issue -
          Wadeck Follonier made changes -
          Description Original: As commented by James on the previous PR, the trailing dots are valid in URL. New: As [commented|https://github.com/jenkinsci/jenkins/commit/e7eec1cbe60067871689871f12a56d496abe60a2#r28867382] by James on the previous PR, the trailing dots are valid in URL.
          Wadeck Follonier made changes -
          Status Original: Open [ 1 ] New: In Progress [ 3 ]
          Wadeck Follonier made changes -
          Remote Link New: This issue links to "#3424 core (Web Link)" [ 20626 ]
          Wadeck Follonier made changes -
          Description Original: As [commented|https://github.com/jenkinsci/jenkins/commit/e7eec1cbe60067871689871f12a56d496abe60a2#r28867382] by James on the previous PR, the trailing dots are valid in URL. New: As [commented|https://github.com/jenkinsci/jenkins/commit/e7eec1cbe60067871689871f12a56d496abe60a2#r28867382] by James on the previous PR, the trailing dots are valid in URL.

          Not really critical since the trailing dot is not commonly used.
          Wadeck Follonier made changes -
          Description Original: As [commented|https://github.com/jenkinsci/jenkins/commit/e7eec1cbe60067871689871f12a56d496abe60a2#r28867382] by James on the previous PR, the trailing dots are valid in URL.

          Not really critical since the trailing dot is not commonly used.
          New: As [commented|https://github.com/jenkinsci/jenkins/commit/e7eec1cbe60067871689871f12a56d496abe60a2#r28867382] by James on the previous PR, the trailing dots are valid in URL.
          Wadeck Follonier made changes -
          Status Original: In Progress [ 3 ] New: In Review [ 10005 ]
          Wadeck Follonier made changes -
          Link New: This issue is related to JENKINS-51064 [ JENKINS-51064 ]

          Code changed in jenkins
          User: Wadeck Follonier
          Path:
          core/src/main/java/jenkins/util/UrlHelper.java
          core/src/test/java/jenkins/util/UrlHelperTest.java
          http://jenkins-ci.org/commit/jenkins/c79f3f719c3f320ff6f0b17fae7d15ee2c1cbbcb
          Log:
          JENKINS-51158 Improve Root URL validation

          • remove the bug for ipv6
          • remove the support of query that was not expected
          • add support for trailing dots
          • add lots of unit tests

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Wadeck Follonier Path: core/src/main/java/jenkins/util/UrlHelper.java core/src/test/java/jenkins/util/UrlHelperTest.java http://jenkins-ci.org/commit/jenkins/c79f3f719c3f320ff6f0b17fae7d15ee2c1cbbcb Log: JENKINS-51158 Improve Root URL validation remove the bug for ipv6 remove the support of query that was not expected add support for trailing dots add lots of unit tests

          Code changed in jenkins
          User: Devin Nusbaum
          Path:
          core/src/main/java/jenkins/util/UrlHelper.java
          core/src/test/java/jenkins/util/UrlHelperTest.java
          http://jenkins-ci.org/commit/jenkins/b03beb72f33c13ff57c761fe9a7a6a38fc195729
          Log:
          Merge pull request #3424 from Wadeck/JENINS-51158_IMPROVE_ROOT_URL_VALIDATION

          JENKINS-51158 Improve Root URL validation

          Compare: https://github.com/jenkinsci/jenkins/compare/f33731e7ec7a...b03beb72f33c
          *NOTE:* This service been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/

          Functionality will be removed from GitHub.com on January 31st, 2019.

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Devin Nusbaum Path: core/src/main/java/jenkins/util/UrlHelper.java core/src/test/java/jenkins/util/UrlHelperTest.java http://jenkins-ci.org/commit/jenkins/b03beb72f33c13ff57c761fe9a7a6a38fc195729 Log: Merge pull request #3424 from Wadeck/JENINS-51158_IMPROVE_ROOT_URL_VALIDATION JENKINS-51158 Improve Root URL validation Compare: https://github.com/jenkinsci/jenkins/compare/f33731e7ec7a...b03beb72f33c * NOTE: * This service been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/ Functionality will be removed from GitHub.com on January 31st, 2019.

            wfollonier Wadeck Follonier
            wfollonier Wadeck Follonier
            Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

              Created:
              Updated:
              Resolved: