Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-51841

Remoting Extensibility: Provide API for constructing commands in remote CommandTransport implementations

    • Icon: New Feature New Feature
    • Resolution: Fixed
    • Icon: Minor Minor
    • remoting
    • None

      Remoting Kafka Plugin implements its own Command Transport, which creates Command Instances. Proper deserialization of Commands requires setting proper classloader and a local channel instances.

      There is a Command#readFrom() method which does it, but it's package-private. Also, a construction of the ObjectInputStreamEx requires package-private Channel fields.

      I propose to create a public Channel#readFrom(Channel, byte[] payload) method so that it can be used externally

          [JENKINS-51841] Remoting Extensibility: Provide API for constructing commands in remote CommandTransport implementations

          Oleg Nenashev created issue -
          Oleg Nenashev made changes -
          Epic Link New: JENKINS-51338 [ 190680 ]
          Oleg Nenashev made changes -
          Status Original: Open [ 1 ] New: In Progress [ 3 ]
          Oleg Nenashev made changes -
          Status Original: In Progress [ 3 ] New: In Review [ 10005 ]
          Oleg Nenashev made changes -
          Remote Link New: This issue links to "Reference Impl: https://github.com/pvtuan10/remoting-kafka-plugin/pull/1 (Web Link)" [ 20827 ]
          Oleg Nenashev made changes -
          Remote Link New: This issue links to "https://github.com/jenkinsci/remoting/pull/276 (Web Link)" [ 20828 ]

          Oleg Nenashev added a comment -

          Fix has been released in Jenkins 2.129

          Oleg Nenashev added a comment - Fix has been released in Jenkins 2.129
          Oleg Nenashev made changes -
          Resolution New: Fixed [ 1 ]
          Status Original: In Review [ 10005 ] New: Resolved [ 5 ]

            oleg_nenashev Oleg Nenashev
            oleg_nenashev Oleg Nenashev
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

              Created:
              Updated:
              Resolved: