Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-51852

Since 0.10 the glob matching broken/incompatible

    XMLWordPrintable

Details

    Description

      Between version 0.9 and 0.10, there seems to be a subtle change that causes files not to be found in the workspace. The plain file foo in root of the workspace can not be found using foo pattern, only as **/foo.

      See https://github.com/jenkinsci/acceptance-test-harness/blob/master/src/test/java/plugins/CIFSPublishPluginTest.java for reproducers.

      Attachments

        Activity

          Ascending order - Click to sort in descending order
          slide_o_mix Alex Earl added a comment -

          How do I run the reproduction case?

          slide_o_mix Alex Earl added a comment - How do I run the reproduction case?
          olivergondza Oliver Gondža added a comment -

          See https://github.com/jenkinsci/acceptance-test-harness/blob/master/docs/DOCKER.md. It is roughly:

          $ sudo systemctl start docker
$ ./ath-container.sh
$ eval $(./vnc.sh)
$ ./run.sh firefox latest -Dmaven.test.failure.ignore=true -DforkCount=1 -B -Dtest=CIFSPublishPluginTest#publish_resources
          olivergondza Oliver Gondža added a comment - See https://github.com/jenkinsci/acceptance-test-harness/blob/master/docs/DOCKER.md . It is roughly: $ sudo systemctl start docker $ ./ath-container.sh $ eval $(./vnc.sh) $ ./run.sh firefox latest -Dmaven.test.failure.ignore=true -DforkCount=1 -B -Dtest=CIFSPublishPluginTest#publish_resources
          slide_o_mix Alex Earl added a comment -

          I don't have docker available to me, I only have a Windows PC that I can use right now and I can't install docker on it. I'll try and reproduce another way.

          slide_o_mix Alex Earl added a comment - I don't have docker available to me, I only have a Windows PC that I can use right now and I can't install docker on it. I'll try and reproduce another way.
          slide_o_mix Alex Earl added a comment -

          I am unable to reproduce this on my local instance of Jenkins.

          slide_o_mix Alex Earl added a comment - I am unable to reproduce this on my local instance of Jenkins.
          slide_o_mix Alex Earl added a comment -

          Is there a way to run with a non-released version of the plugin?

          slide_o_mix Alex Earl added a comment - Is there a way to run with a non-released version of the plugin?
          olivergondza Oliver Gondža added a comment -

          slide_o_mix, the ATH? sure: https://github.com/jenkinsci/acceptance-test-harness/blob/master/docs/SUT-VERSIONS.md#use-custom-plugin-file

          olivergondza Oliver Gondža added a comment - slide_o_mix , the ATH? sure: https://github.com/jenkinsci/acceptance-test-harness/blob/master/docs/SUT-VERSIONS.md#use-custom-plugin-file
          slide_o_mix Alex Earl added a comment -

          When I try and do that I just get errors like this:

          master53668|SEVERE: Failed to install Publish Over CIFS
master53668|java.io.IOException: Downloaded file /home/ath-user/ath-sources/target/jenkins3939363797066647269home/plugins/publish-over-cifs.jpi.tmp does not match expected SHA-256, expected 'nBOpBcYoY/KfajQw8AQ2XTL3BYPw5xA2onk+w05WFR0=', actual '40fakNRWazpJHrwg3eaW44QFqCMVFhNmV1pJL9SqSYM='

          I've tried with running an "mvn install" so that the snapshot is in .m2 and using VERSION_OVERRIDES as well as with LOCAL_JARS.

          slide_o_mix Alex Earl added a comment - When I try and do that I just get errors like this: master53668|SEVERE: Failed to install Publish Over CIFS master53668|java.io.IOException: Downloaded file /home/ath-user/ath-sources/target/jenkins3939363797066647269home/plugins/publish-over-cifs.jpi.tmp does not match expected SHA-256, expected 'nBOpBcYoY/KfajQw8AQ2XTL3BYPw5xA2onk+w05WFR0=' , actual '40fakNRWazpJHrwg3eaW44QFqCMVFhNmV1pJL9SqSYM=' I've tried with running an "mvn install" so that the snapshot is in .m2 and using VERSION_OVERRIDES as well as with LOCAL_JARS.
          olivergondza Oliver Gondža added a comment -

          Hmm, it seems weeklies has broken this aspect of ATH: https://github.com/jenkinsci/jenkins/commit/6dc32977fc6772a2e18452672d69b8b93ea3e832. Try core pre-2.130.

          olivergondza Oliver Gondža added a comment - Hmm, it seems weeklies has broken this aspect of ATH: https://github.com/jenkinsci/jenkins/commit/6dc32977fc6772a2e18452672d69b8b93ea3e832 . Try core pre-2.130.
          slide_o_mix Alex Earl added a comment -

          Ok, that worked. Thanks. The next release version (will be released soon) of the plugin passes the test.

          slide_o_mix Alex Earl added a comment - Ok, that worked. Thanks. The next release version (will be released soon) of the plugin passes the test.
          slide_o_mix Alex Earl added a comment -

          Will be fixed in 0.12

          slide_o_mix Alex Earl added a comment - Will be fixed in 0.12
          olivergondza Oliver Gondža added a comment -

          slide_o_mix, Thanks, I have verified https://github.com/jenkinsci/publish-over-cifs-plugin/commit/4e699e09d93d393c5ece95287e657acd904a9bcd fixed the problem. Can you please cut the release (or I can do it if you do not mind), the false positives this causes in acceptance test harness are painful in evaluating Java 11 readiness. Thank you!

          olivergondza Oliver Gondža added a comment - slide_o_mix , Thanks, I have verified https://github.com/jenkinsci/publish-over-cifs-plugin/commit/4e699e09d93d393c5ece95287e657acd904a9bcd fixed the problem. Can you please cut the release (or I can do it if you do not mind), the false positives this causes in acceptance test harness are painful in evaluating Java 11 readiness. Thank you!
          slide_o_mix Alex Earl added a comment -

          I'll cut the release today

          slide_o_mix Alex Earl added a comment - I'll cut the release today
          slide_o_mix Alex Earl added a comment -

          Released 0.12

          slide_o_mix Alex Earl added a comment - Released 0.12
          olivergondza Oliver Gondža added a comment -

          Thanks, works as a charm!

          olivergondza Oliver Gondža added a comment - Thanks, works as a charm!
          gmcdonald Gavin McDonald added a comment -

          For your information, all publish-over-cifs component type JENKINS issues related to the Publish Over CIFS plugin have been transferred to Github: https://github.com/jenkinsci/publish-over-cifs-plugin/issues

          Here is the direct link to this issue in Github: https://github.com/jenkinsci/publish-over-cifs-plugin/issues/82
          And here is the link to a search for related issues: https://github.com/jenkinsci/publish-over-cifs-plugin/issues?q=%22JENKINS-51852%22

          (Note: this is an automated bulk comment)

          gmcdonald Gavin McDonald added a comment - For your information, all publish-over-cifs component type JENKINS issues related to the Publish Over CIFS plugin have been transferred to Github: https://github.com/jenkinsci/publish-over-cifs-plugin/issues Here is the direct link to this issue in Github: https://github.com/jenkinsci/publish-over-cifs-plugin/issues/82 And here is the link to a search for related issues: https://github.com/jenkinsci/publish-over-cifs-plugin/issues?q=%22JENKINS-51852%22 (Note: this is an automated bulk comment)

          People

            slide_o_mix Alex Earl
            olivergondza Oliver Gondža
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: