• Type: Bug
• Resolution: Unresolved
• Priority: Major
• Component/s: office-365-connector-plugin
• Labels:

  None
• Environment:

  Jenkins version 2.107.1
  
  Office 365 Connector Plugin version 4.5
  
  CloudBees Folders Plugin version 6.1.2
  
  Blue Ocean Plugin version 1.3.3

[JENKINS-53262] Folder URL forward slashes are double encoded for Outlook notifications

Collapse comment: Devin Nusbaum added a comment - 2018-08-27 22:13, Edited by Devin Nusbaum - 2018-08-27 22:16

Devin Nusbaum added a comment - 2018-08-27 22:13 - edited

I'm not sure why I am the default assignee here. It looks like outconn is the maintainer of office-365-connector-plugin, so I am assigning it to him. It should be easy enough to check whether the bug is in that plugin or if the URL it gets from https://github.com/jenkinsci/blueocean-display-url-plugin has already been double-escaped in which case that plugin would need to be fixed.

Also note: the problem is not 2 slashes (which would be %2f%2f), but that / was encoded twice: Once into %2f, and then the % was encoded again resulting in %252f

Expand comment: Devin Nusbaum added a comment - 2018-08-27 22:13, Edited by Devin Nusbaum - 2018-08-27 22:16

Devin Nusbaum added a comment - 2018-08-27 22:13 - edited I'm not sure why I am the default assignee here. It looks like outconn is the maintainer of office-365-connector-plugin, so I am assigning it to him. It should be easy enough to check whether the bug is in that plugin or if the URL it gets from https://github.com/jenkinsci/blueocean-display-url-plugin has already been double-escaped in which case that plugin would need to be fixed. Also note: the problem is not 2 slashes (which would be %2f%2f ), but that / was encoded twice: Once into %2f , and then the % was encoded again resulting in %252f

Collapse comment: Jason Curtis added a comment - 2018-09-05 14:46

Jason Curtis added a comment - 2018-09-05 14:46

This Jenkins master is behind Apache with the rewrite module enabled, and rewrite directives configured. The double encoding problem was resolved by adding the NE flag to the RewriteRule directive to prevent mod_rewrite from applying hexcode escaping of special characters in the result of the rewrite. The forward slash ('/') characters are no longer being double encoded. Related links:

https://httpd.apache.org/docs/current/mod/mod_rewrite.html#rewriterule

https://httpd.apache.org/docs/2.4/rewrite/flags.html#flag_ne

http://tkurek.blogspot.com/2013/06/252f-instead-of-2f-in-url-apache.html

 

Expand comment: Jason Curtis added a comment - 2018-09-05 14:46

Jason Curtis added a comment - 2018-09-05 14:46 This Jenkins master is behind Apache with the rewrite module enabled, and rewrite directives configured. The double encoding problem was resolved by adding the NE flag to the RewriteRule directive to prevent mod_rewrite from applying hexcode escaping of special characters in the result of the rewrite. The forward slash ('/') characters are no longer being double encoded. Related links: https://httpd.apache.org/docs/current/mod/mod_rewrite.html#rewriterule https://httpd.apache.org/docs/2.4/rewrite/flags.html#flag_ne http://tkurek.blogspot.com/2013/06/252f-instead-of-2f-in-url-apache.html