Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-5443

Left navigation link People does not automatically appear

    • Icon: Improvement Improvement
    • Resolution: Fixed
    • Icon: Trivial Trivial
    • core
    • None
    • Any.
      Behavior duplicated under Windows XP, and Ubuntu.

      In the initial state of a Hudson Server, the People link does not appear.

      One can create jobs, and users, and manage both, and the People link will not appear.

      It only appears after a job is triggered by an scm poll.

      Instead of the current logic, could a test of:
      useSecurity && authorizationStrategy!=null && authorizationStrategy.length>0 || users!=null && users.length>0)

      { // the reference to authorizationStrategy may not be valid for "Anyone can do Anything". // include People link. }

      This change would allow for the link to not be shown when there is no security (enable security==false), and no implied users (via scm) exist.

      In the meantime, anyone who needs it can just include a link to People in their dashboard customization.

          [JENKINS-5443] Left navigation link People does not automatically appear

          Alan Harder added a comment -

          looks like the intent of the logic is to hide the link when that people page would be empty.. but I don't think it is always correct, as you have seen. looking into it..

          Alan Harder added a comment - looks like the intent of the logic is to hide the link when that people page would be empty.. but I don't think it is always correct, as you have seen. looking into it..

          Code changed in hudson
          User: : mindless
          Path:
          trunk/hudson/main/core/src/main/java/hudson/model/View.java
          trunk/hudson/main/core/src/main/resources/hudson/model/View/People/index.jelly
          trunk/hudson/main/core/src/main/resources/hudson/model/View/sidepanel.jelly
          trunk/www/changelog.html
          http://jenkins-ci.org/commit/27129
          Log:
          [FIXED JENKINS-5443] Fixes for sidepanel link for People.
          Link to top level /people/ for AllView, otherwise to people for this view.
          Hide link only for non-default, non-All view that would list no people.
          Add heading on People page and a link to top level /people/ when appropriate.

          SCM/JIRA link daemon added a comment - Code changed in hudson User: : mindless Path: trunk/hudson/main/core/src/main/java/hudson/model/View.java trunk/hudson/main/core/src/main/resources/hudson/model/View/People/index.jelly trunk/hudson/main/core/src/main/resources/hudson/model/View/sidepanel.jelly trunk/www/changelog.html http://jenkins-ci.org/commit/27129 Log: [FIXED JENKINS-5443] Fixes for sidepanel link for People. Link to top level /people/ for AllView, otherwise to people for this view. Hide link only for non-default, non-All view that would list no people. Add heading on People page and a link to top level /people/ when appropriate.

            mindless Alan Harder
            ken_graham ken_graham
            Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

              Created:
              Updated:
              Resolved: