Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-54466

HPIs should be renamed JPIs after download

XMLWordPrintable

    • Evergreen - Milestone 2

      Problem statement

      During downloads, we put plugins as-is on the disk with their name and extension.
      Issue is, download URLs end with .hpi. This is inconsistent with what Jenkins does renaming to .jpi since ~1.5xx.
      I saw that a lot in JENKINS-54358, not sure where this comes from, but fixing it would at least avoid this situation in the future.

      Expected

      We should actively rename to .jpi after download.

          [JENKINS-54466] HPIs should be renamed JPIs after download

          Baptiste Mathus created issue -
          Baptiste Mathus made changes -
          Link New: This issue relates to JENKINS-54358 [ JENKINS-54358 ]
          Baptiste Mathus made changes -
          Description Original: h3. Problem statement

          During downloads, we put plugins as-is on the disk with their name and extension.
          Issue is, download URLs end with .hpi, and Jenkins renames it to .jpi in many cases since ~1.5xx. So on updates, and potential restarts, we can end up with both .hpi and .jpi.

          h3. Expected

          We should actively rename to .jpi after download.           		New: h3. Problem statement

          During downloads, we put plugins as-is on the disk with their name and extension.
          Issue is, download URLs end with .hpi, and Jenkins renames it to .jpi in many cases since ~1.5xx. So on updates, and potential restarts, we can end up with both .hpi and .jpi.
          I saw that a lot in JENKINS-54358

          h3. Expected

          We should actively rename to .jpi after download.
          Baptiste Mathus made changes -
          Assignee Original: R. Tyler Croy [ rtyler ] New: Baptiste Mathus [ batmat ]
          Baptiste Mathus made changes -
          Status Original: Open [ 1 ] New: In Progress [ 3 ]
          Baptiste Mathus made changes -
          Rank New: Ranked higher
          Baptiste Mathus made changes -
          Description Original: h3. Problem statement

          During downloads, we put plugins as-is on the disk with their name and extension.
          Issue is, download URLs end with .hpi, and Jenkins renames it to .jpi in many cases since ~1.5xx. So on updates, and potential restarts, we can end up with both .hpi and .jpi.
          I saw that a lot in JENKINS-54358

          h3. Expected

          We should actively rename to .jpi after download.           		New: h3. Problem statement

          During downloads, we put plugins as-is on the disk with their name and extension.
          Issue is, download URLs end with .hpi. This is inconsistent with what Jenkins does renaming to .jpi since ~1.5xx.
          I saw that a lot in JENKINS-54358, not sure where this comes from, but fixing it would at least avoid this situation in the future.

          h3. Expected

          We should actively rename to .jpi after download.

          Baptiste Mathus added a comment -

          Also TODO: check that the core issues a warning if both .jpi and .hpi are present for a given plugin.

          Baptiste Mathus added a comment - Also TODO: check that the core issues a warning if both .jpi and .hpi are present for a given plugin.

          Baptiste Mathus added a comment -

          Almost there FTR. Fixing a few tests here and there that were expecting .hpi. Slightly more than just replaceAll, since we actually want to detect if someone put an hpi by hand for instance, and not just ignore these files when reporting versions for example.

          Baptiste Mathus added a comment - Almost there FTR. Fixing a few tests here and there that were expecting .hpi. Slightly more than just replaceAll, since we actually want to detect if someone put an hpi by hand for instance, and not just ignore these files when reporting versions for example.
          Baptiste Mathus made changes -
          Status Original: In Progress [ 3 ] New: In Review [ 10005 ]

            batmat Baptiste Mathus
            batmat Baptiste Mathus
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Created:
              Updated:
              Resolved: