• Icon: Bug Bug
    • Resolution: Fixed
    • Icon: Major Major
    • mercurial-plugin
    • None

      Looking at page like http://deadlock.netbeans.org/hudson/job/trunk/7635/changes, there is a whitespace at the end of the user name "Alex Petrov " in this case.

      I can't spot if this is caused by the core or by the plugin, but such whitespace should be trimmed.

          [JENKINS-5452] Whitespace in the user ID

          Jesse Glick added a comment -

          For a User whose fullName is 'Bob Hacker <bhacker@netbeans.org>' (legitimate AFAIK), this Jelly code:

          <a href="${rootURL}/${cs.author.url}/">${cs.author}</a>
          

          produces this HTML:

          <a style="" href="/hudson/user/Bob%20Hacker%20_bhacker@netbeans.org_/">Bob Hacker <bhacker@netbeans.org></bhacker@netbeans.org></a>
          

          which is clearly wrong. What should be used to emit text while escaping HTML metacharacters?

          Jesse Glick added a comment - For a User whose fullName is 'Bob Hacker <bhacker@netbeans.org>' (legitimate AFAIK), this Jelly code: <a href="${rootURL}/${cs.author.url}/">${cs.author}</a> produces this HTML: <a style="" href="/hudson/user/Bob%20Hacker%20_bhacker@netbeans.org_/">Bob Hacker <bhacker@netbeans.org></bhacker@netbeans.org></a> which is clearly wrong. What should be used to emit text while escaping HTML metacharacters?

          evernat added a comment -

          This is currently reproductible with Hudson v1.392.
          See for example, http://deadlock.netbeans.org/hudson/job/trunk/10616/changes or another build.

          evernat added a comment - This is currently reproductible with Hudson v1.392. See for example, http://deadlock.netbeans.org/hudson/job/trunk/10616/changes or another build.

          Is it actual? How reproduce? Any screenshots?

          Kanstantsin Shautsou added a comment - Is it actual? How reproduce? Any screenshots?

          Code changed in jenkins
          User: Jesse Glick
          Path:
          src/main/resources/hudson/plugins/mercurial/MercurialChangeSetList/index.jelly
          http://jenkins-ci.org/commit/mercurial-plugin/89f9e5fd842595ed8e0afc1196e53c8690436c63
          Log:
          [FIXED JENKINS-5452] Lack of proper escaping broke display of user names in changelog.

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Jesse Glick Path: src/main/resources/hudson/plugins/mercurial/MercurialChangeSetList/index.jelly http://jenkins-ci.org/commit/mercurial-plugin/89f9e5fd842595ed8e0afc1196e53c8690436c63 Log: [FIXED JENKINS-5452] Lack of proper escaping broke display of user names in changelog.

            jglick Jesse Glick
            kohsuke Kohsuke Kawaguchi
            Votes:
            1 Vote for this issue
            Watchers:
            3 Start watching this issue

              Created:
              Updated:
              Resolved: