Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-54686

Use trilead-api plugin instead trilead-ssh2 from core

    XMLWordPrintable

Details

    • ssh-slaves-1.29.1

    Description

      Remove the dependency of the Trilead-ssh2 plugin and use the Trilead-api plugins instead, this means that ssh-slaves plugins no longer uses the trilead-ssh2 plugin provider by the Jenkins core, it will use the Trilead-api version, so now it is possible to upgrade the plugin ssh library without to upgrade the core.

      Attachments

        Issue Links

          Activity

            ifernandezcalvo Ivan Fernandez Calvo added a comment - - edited

            ssh-slaves 1.28.1 does not use trilead-api, it was introduced in 1.29.0.

            I have tested a few stuff

            • A fresh installation of Jenkins 2.152, I do not see the issue
            • A fresh installation of Jenkins 2.73.3(I choose this because you can not install 1.29.X), then upgrade to 2.152 and upgrade the plugins, I do not see the issue

            You can test the same if you want:

            • Copy your JENKINS_HOME and your jenkins.war to a test machine
            • Go to the test machine
            • Go to the JENKINS_HOME folder
            • Remove the plugin from the plugins folder rm -fr plugins/ssh-slaves* (the asterisk matters)
            • Start Jenkins 'JENKINS_HOME=$(pwd) java -jar jenkins.war'
            • Enter in the test instance on port 8080 'http://test.exampl.com:8080'
            • Upgrade the plugin
            • Restart
            ifernandezcalvo Ivan Fernandez Calvo added a comment - - edited ssh-slaves 1.28.1 does not use trilead-api, it was introduced in 1.29.0. I have tested a few stuff A fresh installation of Jenkins 2.152, I do not see the issue A fresh installation of Jenkins 2.73.3(I choose this because you can not install 1.29.X), then upgrade to 2.152 and upgrade the plugins, I do not see the issue You can test the same if you want: Copy your JENKINS_HOME and your jenkins.war to a test machine Go to the test machine Go to the JENKINS_HOME folder Remove the plugin from the plugins folder rm -fr plugins/ssh-slaves * (the asterisk matters) Start Jenkins 'JENKINS_HOME=$(pwd) java -jar jenkins.war' Enter in the test instance on port 8080 'http://test.exampl.com:8080' Upgrade the plugin Restart
            clausewitz45 Csaba Sari added a comment -

            Hi ifernandezcalvo

            I can confirm fsteff's report, exactly the same issue on CentOS 7, with Jenkins LTS 2.138.3. Only the 1.28.1 works for me. 

            regards,

            Csaba

            clausewitz45 Csaba Sari added a comment - Hi ifernandezcalvo ,  I can confirm fsteff 's report, exactly the same issue on CentOS 7, with Jenkins LTS 2.138.3. Only the 1.28.1 works for me.  regards, Csaba

            ifernandezcalvo

            I were manually installing the plugins, and stopping the Jenkins service before each installation.

            The only two plugins changed on my system were ssh-slave and trilead-api.

            I manually tried these combinations (in this order), before I wrote here:

             

            1.29.1 + 1.0.1 = Stacktrace on boot

             1.29.1 + 1.0.0 = Stacktrace on boot

            1.29.0 + 1.0.0 = Stacktrace on boot

            1.28.1 + 1.0.0 = Works

            1.28.1 + 1.0.1 = Works

            1.29.0 + 1.0.1 = Stacktrace on boot

             

            Ended up using this combination:

            1.28.1 + 1.0.1 = Works

             

             

            fsteff Flemming Steffensen added a comment - ifernandezcalvo I were manually installing the plugins, and stopping the Jenkins service before each installation. The only two plugins changed on my system were ssh-slave and trilead-api. I manually tried these combinations (in this order), before I wrote here:   1.29.1 + 1.0.1 = Stacktrace on boot  1.29.1 + 1.0.0 = Stacktrace on boot 1.29.0 + 1.0.0 = Stacktrace on boot 1.28.1 + 1.0.0 = Works 1.28.1 + 1.0.1 = Works 1.29.0 + 1.0.1 = Stacktrace on boot   Ended up using this combination: 1.28.1 + 1.0.1 = Works    
            ifernandezcalvo Ivan Fernandez Calvo added a comment - - edited

            I have confirmation on a few issues that the upgrade to 1.29.1 fix the issue, it required a restart if not yo do not change the plugin, check that you are using the right version of the plugin by executing the following script in the Jenkins script console

            result = ''
            for (plugin in Jenkins.instance.pluginManager.plugins) {
            	result = result + "${plugin.displayName}" + ',' + "${plugin.version}\n"
            }
            return result
            

            JENKINS-54061
            JENKINS-54713

            ifernandezcalvo Ivan Fernandez Calvo added a comment - - edited I have confirmation on a few issues that the upgrade to 1.29.1 fix the issue, it required a restart if not yo do not change the plugin, check that you are using the right version of the plugin by executing the following script in the Jenkins script console result = '' for (plugin in Jenkins.instance.pluginManager.plugins) { result = result + "${plugin.displayName}" + ',' + "${plugin.version}\n" } return result JENKINS-54061 JENKINS-54713

            I just upgraded the ssh-slave from 1.28.1 to 1.29.1, and immediately got the same stack-trace.

            Downgrading to 1.29.0 also produced the stack-trace.

             

            Finally, back on 1.28.1, everything is back to normal.

             

            On each of the above mentioned versions, I've tested both trilead-api 1.0.0 and 1.0.1 - but this plugin version does not seem to affect the problem.

             

            fsteff Flemming Steffensen added a comment - I just upgraded the ssh-slave from 1.28.1 to 1.29.1 , and immediately got the same stack-trace. Downgrading to 1.29.0 also produced the stack-trace.   Finally, back on 1.28.1 , everything is back to normal.   On each of the above mentioned versions, I've tested both trilead-api 1.0.0 and 1.0.1 - but this plugin version does not seem to affect the problem.  

            People

              ifernandezcalvo Ivan Fernandez Calvo
              ifernandezcalvo Ivan Fernandez Calvo
              Votes:
              1 Vote for this issue
              Watchers:
              15 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: