Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-54686

Use trilead-api plugin instead trilead-ssh2 from core

XMLWordPrintable

    • ssh-slaves-1.29.1

      Remove the dependency of the Trilead-ssh2 plugin and use the Trilead-api plugins instead, this means that ssh-slaves plugins no longer uses the trilead-ssh2 plugin provider by the Jenkins core, it will use the Trilead-api version, so now it is possible to upgrade the plugin ssh library without to upgrade the core.

          [JENKINS-54686] Use trilead-api plugin instead trilead-ssh2 from core

          Ivan Fernandez Calvo created issue -
          Ivan Fernandez Calvo made changes -
          Status Original: Open [ 1 ] New: In Progress [ 3 ]
          Ivan Fernandez Calvo made changes -
          Status Original: In Progress [ 3 ] New: In Review [ 10005 ]
          Ivan Fernandez Calvo made changes -
          Summary Original: Use trilead-api plugin instead trilead-ssh2 core New: Use trilead-api plugin instead trilead-ssh2 from core
          Ivan Fernandez Calvo made changes -
          Released As New: ssh-slave-1.29.0
          Resolution New: Fixed [ 1 ]
          Status Original: In Review [ 10005 ] New: Resolved [ 5 ]

          John Zila added a comment -

          FYI this breaks the ec2-fleet plugin.

          John Zila added a comment - FYI this breaks the ec2-fleet plugin.

          John Zila added a comment - 
          SSHLauncher{host='10.0.0.21', port=22, credentialsId='b6a4fe2c-9ba5-4052-b91c-7a15e913df37', jvmOptions='-Xmx8192m', javaPath='', prefixStartSlaveCmd='', suffixStartSlaveCmd='', launchTimeoutSeconds=210, maxNumRetries=10, retryWaitTime=15, sshHostKeyVerificationStrategy=hudson.plugins.sshslaves.verifiers.ManuallyTrustedKeyVerificationStrategy, tcpNoDelay=true, trackCredentials=false}
[11/20/18 00:29:56] [SSH] Opening SSH connection to 10.0.0.21:22.
[11/20/18 00:29:57] [SSH] SSH host key matches key seen previously for this host. Connection will be allowed.
ERROR: Unexpected error in launching a agent. This is probably a bug in Jenkins.
java.lang.NoClassDefFoundError: com/trilead/ssh2/Connection
	at com.cloudbees.jenkins.plugins.sshcredentials.impl.TrileadSSHPasswordAuthenticator$Factory.supports(TrileadSSHPasswordAuthenticator.java:194)
	at com.cloudbees.jenkins.plugins.sshcredentials.impl.TrileadSSHPasswordAuthenticator$Factory.newInstance(TrileadSSHPasswordAuthenticator.java:181)
	at com.cloudbees.jenkins.plugins.sshcredentials.SSHAuthenticator.newInstance(SSHAuthenticator.java:216)
	at com.cloudbees.jenkins.plugins.sshcredentials.SSHAuthenticator.newInstance(SSHAuthenticator.java:170)
	at hudson.plugins.sshslaves.SSHLauncher.openConnection(SSHLauncher.java:1213)
	at hudson.plugins.sshslaves.SSHLauncher$2.call(SSHLauncher.java:846)
	at hudson.plugins.sshslaves.SSHLauncher$2.call(SSHLauncher.java:833)
	at java.util.concurrent.FutureTask.run(FutureTask.java:266)
	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
	at java.lang.Thread.run(Thread.java:748)
[11/20/18 00:29:57] Launch failed - cleaning up connection
[11/20/18 00:29:57] [SSH] Connection closed.

          John Zila added a comment - SSHLauncher{host='10.0.0.21', port=22, credentialsId='b6a4fe2c-9ba5-4052-b91c-7a15e913df37', jvmOptions='-Xmx8192m', javaPath='', prefixStartSlaveCmd='', suffixStartSlaveCmd='', launchTimeoutSeconds=210, maxNumRetries=10, retryWaitTime=15, sshHostKeyVerificationStrategy=hudson.plugins.sshslaves.verifiers.ManuallyTrustedKeyVerificationStrategy, tcpNoDelay=true, trackCredentials=false} [11/20/18 00:29:56] [SSH] Opening SSH connection to 10.0.0.21:22. [11/20/18 00:29:57] [SSH] SSH host key matches key seen previously for this host. Connection will be allowed. ERROR: Unexpected error in launching a agent. This is probably a bug in Jenkins. java.lang.NoClassDefFoundError: com/trilead/ssh2/Connection at com.cloudbees.jenkins.plugins.sshcredentials.impl.TrileadSSHPasswordAuthenticator$Factory.supports(TrileadSSHPasswordAuthenticator.java:194) at com.cloudbees.jenkins.plugins.sshcredentials.impl.TrileadSSHPasswordAuthenticator$Factory.newInstance(TrileadSSHPasswordAuthenticator.java:181) at com.cloudbees.jenkins.plugins.sshcredentials.SSHAuthenticator.newInstance(SSHAuthenticator.java:216) at com.cloudbees.jenkins.plugins.sshcredentials.SSHAuthenticator.newInstance(SSHAuthenticator.java:170) at hudson.plugins.sshslaves.SSHLauncher.openConnection(SSHLauncher.java:1213) at hudson.plugins.sshslaves.SSHLauncher$2.call(SSHLauncher.java:846) at hudson.plugins.sshslaves.SSHLauncher$2.call(SSHLauncher.java:833) at java.util.concurrent.FutureTask.run(FutureTask.java:266) at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149) at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624) at java.lang.Thread.run(Thread.java:748) [11/20/18 00:29:57] Launch failed - cleaning up connection [11/20/18 00:29:57] [SSH] Connection closed.

          Mike Corum added a comment -

          This "fix" busted all my jobs that use SSH slaves - they all get a classNotFoundException on the trilead/ssh2/Base64 class.  I assumed there was some other dependency that this required so I made sure to be on the very latest Jenkins and the very latest of all my plugins.  It still broke everything.  

          What do we have to do in order to make this version work?  It's seriously busted.

          Mike Corum added a comment - This "fix" busted all my jobs that use SSH slaves - they all get a classNotFoundException on the trilead/ssh2/Base64 class.  I assumed there was some other dependency that this required so I made sure to be on the very latest Jenkins and the very latest of all my plugins.  It still broke everything.   What do we have to do in order to make this version work?  It's seriously busted.

          Mike Corum added a comment -

          Can this "fix" be reversed?  It completely breaks all uses of the SSH Slaves plugin.  Any job using this plugin immediately gets a stack trace with a ClassNotFoundException with the trilead ssh2 Base64 class.  This includes being at the very latest release of Jenkins and the latest of all other plugins.  I tried reverting the Jenkins to the previous release but it didn't help.

          Mike Corum added a comment - Can this "fix" be reversed?  It completely breaks all uses of the SSH Slaves plugin.  Any job using this plugin immediately gets a stack trace with a ClassNotFoundException with the trilead ssh2 Base64 class.  This includes being at the very latest release of Jenkins and the latest of all other plugins.  I tried reverting the Jenkins to the previous release but it didn't help.
          Mike Corum made changes -
          Resolution Original: Fixed [ 1 ]
          Status Original: Resolved [ 5 ] New: Reopened [ 4 ]

            ifernandezcalvo Ivan Fernandez Calvo
            ifernandezcalvo Ivan Fernandez Calvo
            Votes:
            1 Vote for this issue
            Watchers:
            15 Start watching this issue

              Created:
              Updated:
              Resolved: