Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-54998

Stash and archive should refuse symlinks

XMLWordPrintable

      Stash and archive should follow symlinks. Otherwise a symlink that the pipeline tries to archive is broken, a broken symlink is unstashed, unarchived or copied from another job, an error should be thrown.

          [JENKINS-54998] Stash and archive should refuse symlinks

          Jan Sprinz created issue -
          Vivek Pandey made changes -
          Labels Original: archive pipeline stash New: archive pipeline pipeline-triaged stash
          Andrew Bayer made changes -
          Link New: This issue duplicates JENKINS-52781 [ JENKINS-52781 ]
          Andrew Bayer made changes -
          Resolution New: Duplicate [ 3 ]
          Status Original: Open [ 1 ] New: Resolved [ 5 ]
          Jesse Glick made changes -
          Link New: This issue is duplicated by JENKINS-55560 [ JENKINS-55560 ]

          Jesse Glick added a comment -

          Presence of symlinks or other special files in the input should just be treated as an error.

          Jesse Glick added a comment - Presence of symlinks or other special files in the input should just be treated as an error.
          Jesse Glick made changes -
          Resolution Original: Duplicate [ 3 ]
          Status Original: Resolved [ 5 ] New: Reopened [ 4 ]
          Jesse Glick made changes -
          Component/s New: core [ 15593 ]
          Component/s New: workflow-basic-steps-plugin [ 21712 ]
          Component/s Original: pipeline [ 21692 ]
          Jesse Glick made changes -
          Summary Original: Stash and archive should resolve symlinks New: Stash and archive should refuse symlinks

          Chris Dore added a comment -

          jglick why should a symlink be an error?

          Since symlinks are not preserved, we abandoned using stash and instead we are now allocating a node for the entire pipeline, even when that node could be released back to the pool during certain stages. I would love to revisit our workaround and improve node utilization, having stash handle symlinks would make this very easy. Are there other alternative ideas to allow a pipeline to save state containing symlinks across stages on different nodes/workspaces?

          Chris Dore added a comment - jglick why should a symlink be an error? Since symlinks are not preserved, we abandoned using stash and instead we are now allocating a node for the entire pipeline, even when that node could be released back to the pool during certain stages. I would love to revisit our workaround and improve node utilization, having stash handle symlinks would make this very easy. Are there other alternative ideas to allow a pipeline to save state containing symlinks across stages on different nodes/workspaces?

            Unassigned Unassigned
            neothethird Jan Sprinz
            Votes:
            2 Vote for this issue
            Watchers:
            5 Start watching this issue

              Created:
              Updated: