Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-55050

Performance improvement for large archive symlink outside of workspace

    • Icon: Improvement Improvement
    • Resolution: Fixed
    • Icon: Major Major
    • core
    • None
    • Jenkins 2.164

      When an archive contain a symlink that is leading outside of the workspace, the current implementation check if the linked folder and every descendants in that folder are inside the workspace, causing some performance troubles if there are really numerous. Those checks are performed when we want to download the zip containing the specific symlink.

      This case is mostly encountered when an undesired symlink is created.

          [JENKINS-55050] Performance improvement for large archive symlink outside of workspace

          Wadeck Follonier created issue -
          Wadeck Follonier made changes -
          Description Original: When an archive contain a symlink that is leading outside of the workspace, the current implementation check if the linked folder and *every* descendants in that folder are inside the workspace, causing some performance troubles if there are really numerous.

          This case is mostly encountered when an undesired symlink is created.
          New: When an archive contain a symlink that is leading outside of the workspace, the current implementation check if the linked folder and *every* descendants in that folder are inside the workspace, causing some performance troubles if there are really numerous. Those checks are performed when we want to download the zip containing the specific symlink.

          This case is mostly encountered when an undesired symlink is created.
          Wadeck Follonier made changes -
          Attachment New: generate_structure.groovy [ 45388 ]

          Script attached to generate 4013 files inside a complex structure of folders.
          With log in INFO level, time to download the zip of that directory: 10-12s

          First approach:
          By just setting the log to FINE, time down to: 6-7s

          Wadeck Follonier added a comment - Script attached to generate 4013 files inside a complex structure of folders. With log in INFO level, time to download the zip of that directory: 10-12s First approach: By just setting the log to FINE, time down to: 6-7s
          Wadeck Follonier made changes -
          Remote Link New: This issue links to "#3848 in core (log level reduction) (Web Link)" [ 22211 ]
          Wadeck Follonier made changes -
          Status Original: Open [ 1 ] New: In Progress [ 3 ]
          Wadeck Follonier made changes -
          Remote Link New: This issue links to "#3861 in core (advanced version) (Web Link)" [ 22302 ]
          Wadeck Follonier made changes -
          Status Original: In Progress [ 3 ] New: In Review [ 10005 ]
          Jesse Glick made changes -
          Link New: This issue relates to SECURITY-904 [ SECURITY-904 ]

          Oleg Nenashev added a comment -

          It was released in 2.164. If a previous version is selected as an LTS baseline, we may need backporting

          Oleg Nenashev added a comment - It was released in 2.164. If a previous version is selected as an LTS baseline, we may need backporting
          Oleg Nenashev made changes -
          Released As New: Jenkins 2.164
          Resolution New: Fixed [ 1 ]
          Status Original: In Review [ 10005 ] New: Resolved [ 5 ]

            wfollonier Wadeck Follonier
            wfollonier Wadeck Follonier
            Votes:
            1 Vote for this issue
            Watchers:
            2 Start watching this issue

              Created:
              Updated:
              Resolved: