Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-55605

can only click on the first active parallel stage, others running but cannot click

    • Icon: Bug Bug
    • Resolution: Fixed
    • Icon: Major Major
    • blueocean-plugin
    • None
    • blueocean 1.10.1, all browsers
    • 1.19

      I have a pipeline with parallel sequential stages (the same problem might occur if there are parallel 1-stage, not sure) and can only click on the first 'active' stage. Too much to obfuscate, will do ascii:

       4 parallel - sequential stages below:

      ....s1....

      .

      ....s2....

      .

      ....s3...s4...

      .

      ....s5....s6
       
       
       
      s4 and s6 included in the diagram in case it's relevant, but the problem happens without them being shown visually in what I'm about to describe, as those stages haven't started yet:

      s1 is a single stage and complete (green)

      s2, s3, s5 all show as animated blue circles, which is accurate. Going out of blue ocean and examining legacy pipeline view properly shows logs progressing on those.

      But in the blue ocean view, I can only click on s1, or s2, and have the bottom half of the screen (console log, etc) update. s3 and s5 on hover-over show that they're clickable, but clicking them does nothing. Only clicking s1 or s2 changes the context of the bottom half of the blue ocean UI.

      Potentially of interest:

      If I'm currently clicked/selected on s2, then clicking s3/s5 does nothing.

      If I'm currently clicked/selected on s1 (the one that is green/complete), then clicking on s3/s5 changes the bottom context to s2.

      It's as is clicking on any active parallel stage will only set the bottom context to the first active parallel stage, but that is just a guess.

      As I write this – the graph has now progressed so that s2, s4, and s6 are active. s1, s3, and s5 are complete. Still has the same problem – if I click on s4 or s6, it only shows the context of s2.

       

       

          [JENKINS-55605] can only click on the first active parallel stage, others running but cannot click

          boris ivan added a comment -

          some improvement in BO 1.11.1 – I can now click on S1, S2, S3, S5, and context changes accordingly. Prior to BO 1.11.1 I could only see the context of S1 regardless what I clicked.

          Unfortunately when S5 finishes and the active stages are: S1, S2, S3, S6 ... I cannot click on S6 and have the context switch to S6. The blue active icon gets larger, but the context (logs, etc) doesn't switch.

          So.. things are a bit better, but still broke.

          boris ivan added a comment - some improvement in BO 1.11.1 – I can now click on S1, S2, S3, S5, and context changes accordingly. Prior to BO 1.11.1 I could only see the context of S1 regardless what I clicked. Unfortunately when S5 finishes and the active stages are: S1, S2, S3, S6 ... I cannot click on S6 and have the context switch to S6. The blue active icon gets larger, but the context (logs, etc) doesn't switch. So.. things are a bit better, but still broke.

          boris ivan added a comment -

          Tried again, and things seem the same as prior to 1.11.1, so I'm not sure there was slight improvement. In either case, still broken.

          boris ivan added a comment - Tried again, and things seem the same as prior to 1.11.1, so I'm not sure there was slight improvement. In either case, still broken.

          Gavin Mogan added a comment -

          borisivan @borisivan 13:32
          Hi @halkeye – was referring to some of the pipeline graph anomalies, like https://issues.jenkins-ci.org/browse/JENKINS-55605
          In that one, if there is a parallel-sequential set of stages occurring, if the 'active' one is not the leftmost one, I cannot click on it and get the context to change to see the build log/etc.
          in terms of the crude diagram I have in the report, the current behavior is as I describe in the last sentence in the JIRA description. I cannot click on s4 or s6, if they are the active stages. That might depend whether or not s1 or s2 are still active (i.e. maybe it works if s4/s6 is the only active stage remaining). But if s1 or s2 is active, I know that I cannot click on s4 or s6.

          Gavin Mogan @halkeye 13:41
          @borisivan if you have a jenkinsfile that highlights it, I can throw it on ci.blueocean.io and you can see it with master, otherwise tomorrow should have it all cleaned up. Josh added a ton of new tests to confirm proper behavior

          Gavin Mogan @halkeye 15:01
          @borisivan https://ci.blueocean.io/blue/organizations/jenkins/Gavin%20Folder%2FJENKINS-56383%20-%20parallel%20steps/detail/JENKINS-56383%20-%20parallel%20steps/1/pipeline

          borisivan @borisivan 15:10
          @halkeye Here's a file that demonstrates the problem: https://github.com/borisivan/blueOceanUI

          Gavin Mogan @halkeye 15:13
          @borisivan https://ci.blueocean.io/blue/organizations/jenkins/Gavin%20Folder%2Fborisivan/detail/borisivan/1/pipeline

          borisivan @borisivan 15:15
          @halkeye right. But in the JIRA I linked, it describes the problem that occurs during that build. That file has the delays set up to demonstrate. If you watch the build occur, try to click on git:c2 or git:e while they are active. I can't. Start the pipeline and after the first 10 seconds, git:c2 and git:e should be active, as is git:b. But if you click on git:c2 or git:e.... git:b remains as the thing you clicked on – I can't shift the context/log/etc away from git:b.

          Gavin Mogan @halkeye 15:22
          hrm, okay, i think i see what you mean, i don't think it'll be fixed in 1.14 then
          cause thats less than a day away

          borisivan @borisivan 15:22
          @halkeye understood.

          Gavin Mogan added a comment - borisivan @borisivan 13:32 Hi @halkeye – was referring to some of the pipeline graph anomalies, like https://issues.jenkins-ci.org/browse/JENKINS-55605 In that one, if there is a parallel-sequential set of stages occurring, if the 'active' one is not the leftmost one, I cannot click on it and get the context to change to see the build log/etc. in terms of the crude diagram I have in the report, the current behavior is as I describe in the last sentence in the JIRA description. I cannot click on s4 or s6, if they are the active stages. That might depend whether or not s1 or s2 are still active (i.e. maybe it works if s4/s6 is the only active stage remaining). But if s1 or s2 is active, I know that I cannot click on s4 or s6. Gavin Mogan @halkeye 13:41 @borisivan if you have a jenkinsfile that highlights it, I can throw it on ci.blueocean.io and you can see it with master, otherwise tomorrow should have it all cleaned up. Josh added a ton of new tests to confirm proper behavior Gavin Mogan @halkeye 15:01 @borisivan https://ci.blueocean.io/blue/organizations/jenkins/Gavin%20Folder%2FJENKINS-56383%20-%20parallel%20steps/detail/JENKINS-56383%20-%20parallel%20steps/1/pipeline borisivan @borisivan 15:10 @halkeye Here's a file that demonstrates the problem: https://github.com/borisivan/blueOceanUI Gavin Mogan @halkeye 15:13 @borisivan https://ci.blueocean.io/blue/organizations/jenkins/Gavin%20Folder%2Fborisivan/detail/borisivan/1/pipeline borisivan @borisivan 15:15 @halkeye right. But in the JIRA I linked, it describes the problem that occurs during that build. That file has the delays set up to demonstrate. If you watch the build occur, try to click on git:c2 or git:e while they are active. I can't. Start the pipeline and after the first 10 seconds, git:c2 and git:e should be active, as is git:b. But if you click on git:c2 or git:e.... git:b remains as the thing you clicked on – I can't shift the context/log/etc away from git:b. Gavin Mogan @halkeye 15:22 hrm, okay, i think i see what you mean, i don't think it'll be fixed in 1.14 then cause thats less than a day away borisivan @borisivan 15:22 @halkeye understood.

          boris ivan added a comment -

          added an attachment illustrating the problem. In the picture, I cannot get the context of the lower half of the window (i.e. where the steps / build console is) to switch to the active stage "git:e" (or "git:s1"). The only active stage I can click on (and see the context change) is "git:b".

          However, when the 'leftmost' stages were all active at the beginning of the pipeline, I could click on any of them, and the context would change correctly. It is only when the leftmost stages complete, that the active stage to the right is 'unclickable'.

          boris ivan added a comment - added an attachment illustrating the problem. In the picture, I cannot get the context of the lower half of the window (i.e. where the steps / build console is) to switch to the active stage "git:e" (or "git:s1"). The only active stage I can click on (and see the context change) is "git:b". However, when the 'leftmost' stages were all active at the beginning of the pipeline, I could click on any of them, and the context would change correctly. It is only when the leftmost stages complete, that the active stage to the right is 'unclickable'.

          boris ivan added a comment -

          Also note odd behavior re: "git:c2" in the picture attached. After running the pipeline multiple times, stages start to not render correctly at all (transparent), even though they're active (and sometimes, completed). They all correctly render when the pipeline is complete. But mid pipeline, they are broken. Possibly not related to this JIRA, but since it's in the same picture (and I don't know how to reliably replicate) – just mentioning it in case it generates any ideas...

          boris ivan added a comment - Also note odd behavior re: "git:c2" in the picture attached. After running the pipeline multiple times, stages start to not render correctly at all (transparent), even though they're active (and sometimes, completed). They all correctly render when the pipeline is complete. But mid pipeline, they are broken. Possibly not related to this JIRA, but since it's in the same picture (and I don't know how to reliably replicate) – just mentioning it in case it generates any ideas...

          Josh McDonald added a comment -

          FYI I can replicate this and I'm currently working on isolating the location of the issue.

          Josh McDonald added a comment - FYI I can replicate this and I'm currently working on isolating the location of the issue.

          Josh McDonald added a comment - - edited

          I think I've got it solved without breaking anything

           -- 

          It's a bit of a maze in that part of the codebase, and the issue was caused by some old code trying to grok the graph that was unaware of the relatively new support for sequential-stage parallel branches.

           -- 

           

          Josh McDonald added a comment - - edited I think I've got it solved without breaking anything  --  It's a bit of a maze in that part of the codebase, and the issue was caused by some old code trying to grok the graph that was unaware of the relatively new support for sequential-stage parallel branches.  --   

          Josh McDonald added a comment -

          This part of the codebase is too brittle, I'm putting this issue back on the shelf for now.

          Josh McDonald added a comment - This part of the codebase is too brittle, I'm putting this issue back on the shelf for now.

          Gavin Mogan added a comment -

          Merged PR https://github.com/jenkinsci/blueocean-plugin/pull/2018

          This should prevent the inability to click on nodes.

          Gavin Mogan added a comment - Merged PR  https://github.com/jenkinsci/blueocean-plugin/pull/2018 This should prevent the inability to click on nodes.

            halkeye Gavin Mogan
            borisivan boris ivan
            Votes:
            4 Vote for this issue
            Watchers:
            6 Start watching this issue

              Created:
              Updated:
              Resolved: