• Type: Bug
• Resolution: Fixed
• Priority: Major
• Component/s: git-plugin
• Labels:

  • expansion
  • git-plugin
  • newbie-friendly
  • variables
• Environment:

  Jenkins 2.150.2
  Git plugin 4.0.0-rc

1. git-clone-config.xml

   4 kB

   2019-02-08 21:40

[JENKINS-56063] git-plugin fails to expand variables in refspec on initial clone

Pavel Roskin created issue - 2019-02-08 22:23

Mark Waite made changes - 2019-02-11 20:15

Assignee

Original: Mark Waite [ markewaite ]

Mark Waite made changes - 2020-01-20 02:51

Labels

Original: expansion git-plugin variables

New: expansion git-plugin newbie-friendly variables

Rishabh Budhouliya made changes - 2020-01-30 20:45

Assignee

New: Rishabh Budhouliya [ rishabhbudhouliya ]

Rishabh Budhouliya made changes - 2020-01-30 20:45

Status

Original: Open [ 1 ]

New: In Progress [ 3 ]

Rishabh Budhouliya made changes - 2020-02-05 20:10

Status

Original: In Progress [ 3 ]

New: In Review [ 10005 ]

Deepansh Nagaria made changes - 2020-02-06 23:11

Description

Original: Git plugin fails to expand variables in the refspec setting. A sure way to trigger the bug is to enable both "Honor refspec on initial clone" and "Wipe out repository & force clone". The config is attached. Here's an excerpt from the log to the top-level job:   {code:java}  > git fetch --no-tags --progress http://stash/scm/rob/testrepository.git +refs/heads/master:refs/remotes/origin/master${BUILD_ID} # timeout=10  > git config remote.origin.url http://stash/scm/rob/testrepository.git # timeout=10  > git config --add remote.origin.fetch +refs/heads/master:refs/remotes/origin/master${BUILD_ID} # timeout=10  > git config remote.origin.url http://stash/scm/rob/testrepository.git # timeout=10 Cleaning workspace  > git rev-parse --verify HEAD # timeout=10 No valid HEAD. Skipping the resetting  > git clean -fdx # timeout=10 Pruning obsolete local branches Fetching upstream changes from http://stash/scm/rob/testrepository.git  > git fetch --no-tags --progress http://stash/scm/rob/testrepository.git +refs/heads/master:refs/remotes/origin/master6 --prune # timeout=10 {code} Note that ${BUILD_ID} is not expanded in the first commit, but is expanded at the end where branch specifier is being used.   Remove "Wipe out repository & force clone", and the variable is being expanded now.   {code:java}  > git fetch --no-tags --progress http://stash/scm/rob/testrepository.git +refs/heads/master:refs/remotes/origin/master9 --prune # timeout=10  > git rev-parse refs/remotes/origin/master9^{commit} # timeout=10  > git rev-parse refs/remotes/origin/refs/heads/master9^{commit} # timeout=10 {code}   It may seem a trivial issue with ${BUILD_ID}, but it's actually a big problem when I try pulling ${sourceCommitHash} with stash-pull-request-builder. That's why I consider it a major bug. It prevents me from using the correct commit received from Stash REST API and makes me use a suboptimal solution that involves a race condition. I believe git-plugin should always expand variables in the refspec setting on its own, without relying on the shell.

New: 0...........................................................................0Git plugin fails to expand variables in the refspec setting. A sure way to trigger the bug is to enable both "Honor refspec on initial clone" and "Wipe out repository & force clone". The config is attached. Here's an excerpt from the log to the top-level job:   {code:java}  > git fetch --no-tags --progress http://stash/scm/rob/testrepository.git +refs/heads/master:refs/remotes/origin/master${BUILD_ID} # timeout=10  > git config remote.origin.url http://stash/scm/rob/testrepository.git # timeout=10  > git config --add remote.origin.fetch +refs/heads/master:refs/remotes/origin/master${BUILD_ID} # timeout=10  > git config remote.origin.url http://stash/scm/rob/testrepository.git # timeout=10 Cleaning workspace  > git rev-parse --verify HEAD # timeout=10 No valid HEAD. Skipping the resetting  > git clean -fdx # timeout=10 Pruning obsolete local branches Fetching upstream changes from http://stash/scm/rob/testrepository.git  > git fetch --no-tags --progress http://stash/scm/rob/testrepository.git +refs/heads/master:refs/remotes/origin/master6 --prune # timeout=10 {code} Note that ${BUILD_ID} is not expanded in the first commit, but is expanded at the end where branch specifier is being used.   Remove "Wipe out repository & force clone", and the variable is being expanded now.   {code:java}  > git fetch --no-tags --progress http://stash/scm/rob/testrepository.git +refs/heads/master:refs/remotes/origin/master9 --prune # timeout=10  > git rev-parse refs/remotes/origin/master9^{commit} # timeout=10  > git rev-parse refs/remotes/origin/refs/heads/master9^{commit} # timeout=10 {code}   It may seem a trivial issue with ${BUILD_ID}, but it's actually a big problem when I try pulling ${sourceCommitHash} with stash-pull-request-builder. That's why I consider it a major bug. It prevents me from using the correct commit received from Stash REST API and makes me use a suboptimal solution that involves a race condition. I believe git-plugin should always expand variables in the refspec setting on its own, without relying on the shell.

Mark Waite made changes - 2020-02-07 00:18

Description

Original: 0...........................................................................0Git plugin fails to expand variables in the refspec setting. A sure way to trigger the bug is to enable both "Honor refspec on initial clone" and "Wipe out repository & force clone". The config is attached. Here's an excerpt from the log to the top-level job:   {code:java}  > git fetch --no-tags --progress http://stash/scm/rob/testrepository.git +refs/heads/master:refs/remotes/origin/master${BUILD_ID} # timeout=10  > git config remote.origin.url http://stash/scm/rob/testrepository.git # timeout=10  > git config --add remote.origin.fetch +refs/heads/master:refs/remotes/origin/master${BUILD_ID} # timeout=10  > git config remote.origin.url http://stash/scm/rob/testrepository.git # timeout=10 Cleaning workspace  > git rev-parse --verify HEAD # timeout=10 No valid HEAD. Skipping the resetting  > git clean -fdx # timeout=10 Pruning obsolete local branches Fetching upstream changes from http://stash/scm/rob/testrepository.git  > git fetch --no-tags --progress http://stash/scm/rob/testrepository.git +refs/heads/master:refs/remotes/origin/master6 --prune # timeout=10 {code} Note that ${BUILD_ID} is not expanded in the first commit, but is expanded at the end where branch specifier is being used.   Remove "Wipe out repository & force clone", and the variable is being expanded now.   {code:java}  > git fetch --no-tags --progress http://stash/scm/rob/testrepository.git +refs/heads/master:refs/remotes/origin/master9 --prune # timeout=10  > git rev-parse refs/remotes/origin/master9^{commit} # timeout=10  > git rev-parse refs/remotes/origin/refs/heads/master9^{commit} # timeout=10 {code}   It may seem a trivial issue with ${BUILD_ID}, but it's actually a big problem when I try pulling ${sourceCommitHash} with stash-pull-request-builder. That's why I consider it a major bug. It prevents me from using the correct commit received from Stash REST API and makes me use a suboptimal solution that involves a race condition. I believe git-plugin should always expand variables in the refspec setting on its own, without relying on the shell.

New: Git plugin fails to expand variables in the refspec setting. A sure way to trigger the bug is to enable both "Honor refspec on initial clone" and "Wipe out repository & force clone". The config is attached. Here's an excerpt from the log to the top-level job:   {code:java}  > git fetch --no-tags --progress http://stash/scm/rob/testrepository.git +refs/heads/master:refs/remotes/origin/master${BUILD_ID} # timeout=10  > git config remote.origin.url http://stash/scm/rob/testrepository.git # timeout=10  > git config --add remote.origin.fetch +refs/heads/master:refs/remotes/origin/master${BUILD_ID} # timeout=10  > git config remote.origin.url http://stash/scm/rob/testrepository.git # timeout=10 Cleaning workspace  > git rev-parse --verify HEAD # timeout=10 No valid HEAD. Skipping the resetting  > git clean -fdx # timeout=10 Pruning obsolete local branches Fetching upstream changes from http://stash/scm/rob/testrepository.git  > git fetch --no-tags --progress http://stash/scm/rob/testrepository.git +refs/heads/master:refs/remotes/origin/master6 --prune # timeout=10 {code} Note that ${BUILD_ID} is not expanded in the first commit, but is expanded at the end where branch specifier is being used.   Remove "Wipe out repository & force clone", and the variable is being expanded now.   {code:java}  > git fetch --no-tags --progress http://stash/scm/rob/testrepository.git +refs/heads/master:refs/remotes/origin/master9 --prune # timeout=10  > git rev-parse refs/remotes/origin/master9^{commit} # timeout=10  > git rev-parse refs/remotes/origin/refs/heads/master9^{commit} # timeout=10 {code}   It may seem a trivial issue with ${BUILD_ID}, but it's actually a big problem when I try pulling ${sourceCommitHash} with stash-pull-request-builder. That's why I consider it a major bug. It prevents me from using the correct commit received from Stash REST API and makes me use a suboptimal solution that involves a race condition. I believe git-plugin should always expand variables in the refspec setting on its own, without relying on the shell.

Mark Waite made changes - 2020-12-10 04:26

Status

Original: In Review [ 10005 ]

New: In Progress [ 3 ]

Mark Waite made changes - 2020-12-10 04:26

Status

Original: In Progress [ 3 ]

New: Open [ 1 ]

Mark Waite made changes - 2020-12-10 21:50

Remote Link

New: This issue links to "PR 1013 - extending Rishabh's work (Web Link)" [ 26363 ]

Load more newer history items