Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-5676

git tag cannot be disabled overrides the existing version

    XMLWordPrintable

Details

    Description

      git describe depends on the last tag. When the plugin runs git tag, it damages the repo's idea of what the version is. git tag should be optional.

      Attachments

        Issue Links

          Activity

            eguess74 eguess74 added a comment -

            My bad.
            I was waiting for the tag format as hudson-[job]...
            Now absence of log saying that it is tagging with tag bla-bla confused me even more.

            So, while i will change the script to expect the tag in new jenkins format, could you please add logging of this tagging step to the build log?

            Thanks!!

            eguess74 eguess74 added a comment - My bad. I was waiting for the tag format as hudson- [job] ... Now absence of log saying that it is tagging with tag bla-bla confused me even more. So, while i will change the script to expect the tag in new jenkins format, could you please add logging of this tagging step to the build log? Thanks!!
            abayer Andrew Bayer added a comment -

            Hi -

            Are you sure it's not tagging? In my tests, I'm seeing tags in the default case - it's not logging that it's tagging currently, but the actual tags are there. They are formatted as "jenkins-[job]-[buildnumber]" now.

            abayer Andrew Bayer added a comment - Hi - Are you sure it's not tagging? In my tests, I'm seeing tags in the default case - it's not logging that it's tagging currently, but the actual tags are there. They are formatted as "jenkins- [job] - [buildnumber] " now.
            eguess74 eguess74 added a comment - - edited

            There is a bug introduced with this change. By default the state of "Skip internal tagging" is unmarked - but no tagging happening. We actually use these tags extensively, so they are critical to our release process. Could you, please, fix it?
            Git plugin 1.1.5

            eguess74 eguess74 added a comment - - edited There is a bug introduced with this change. By default the state of "Skip internal tagging" is unmarked - but no tagging happening. We actually use these tags extensively, so they are critical to our release process. Could you, please, fix it? Git plugin 1.1.5
            dogfood dogfood added a comment -

            Integrated in plugins_git-plugin #84
            [FIXED JENKINS-5676] Added an advanced option to skip the internal tagging.

            Andrew Bayer :
            Files :

            • src/main/webapp/help-skipTag.html
            • src/test/java/hudson/plugins/git/GitSCMTest.java
            • src/main/java/hudson/plugins/git/GitSCM.java
            • src/main/resources/hudson/plugins/git/GitSCM/config.jelly
            dogfood dogfood added a comment - Integrated in plugins_git-plugin #84 [FIXED JENKINS-5676] Added an advanced option to skip the internal tagging. Andrew Bayer : Files : src/main/webapp/help-skipTag.html src/test/java/hudson/plugins/git/GitSCMTest.java src/main/java/hudson/plugins/git/GitSCM.java src/main/resources/hudson/plugins/git/GitSCM/config.jelly
            bvakili bvakili added a comment -

            Mark, unfortunately I'd have to modify hundreds of build scripts at work to use the '--match' option you've proposed. So, in my case, it's not a viable workaround for me

            I'd rather fix things change in one place (i.e. the Hudson git plugin) instead.

            We've had the patch (attached to this ticket) working for months now. Are there any perceived problems with integrating it into an upcoming release?

            bvakili bvakili added a comment - Mark, unfortunately I'd have to modify hundreds of build scripts at work to use the '--match' option you've proposed. So, in my case, it's not a viable workaround for me I'd rather fix things change in one place (i.e. the Hudson git plugin) instead. We've had the patch (attached to this ticket) working for months now. Are there any perceived problems with integrating it into an upcoming release?

            People

              abayer Andrew Bayer
              rcolocke rcolocke
              Votes:
              9 Vote for this issue
              Watchers:
              7 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: