Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-56885

It is possible to save a Node without host configuration

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Resolved (View Workflow)
    • Priority: Major
    • Resolution: Fixed
    • Labels:
    • Environment:
      org.jenkins-ci.main:jenkins-war:2.170
      org.jenkins-ci:crypto-util:1.1
      org.jenkins-ci.modules:sshd:2.6
      org.kohsuke:trilead-putty-extension:1.2
      org.jenkins-ci.modules:ssh-cli-auth:1.5
      org.jenkins-ci.plugins:ssh-slaves:1.29.4
    • Similar Issues:
    • Released As:
      ssh-slaves-1.30.0

      Description

      If you do not set the host field in the Node configuration it is possible to save it, then when it tries to connect fails with an NPE

      Agent connection log

      ERROR: Unexpected error in launching a agent. This is probably a bug in Jenkins.
      java.lang.NullPointerException
      at com.trilead.ssh2.KnownHosts.hostnameMatches(KnownHosts.java:313)
      at com.trilead.ssh2.KnownHosts.getAllKnownHostEntries(KnownHosts.java:260)
      at com.trilead.ssh2.KnownHosts.recommendHostkeyAlgorithms(KnownHosts.java:504)
      at com.trilead.ssh2.KnownHosts.getPreferredServerHostkeyAlgorithmOrder(KnownHosts.java:282)
      at hudson.plugins.sshslaves.verifiers.KnownHostsFileKeyVerificationStrategy.getPreferredKeyAlgorithms(KnownHostsFileKeyVerificationStrategy.java:92)
      at hudson.plugins.sshslaves.SSHLauncher$2.call(SSHLauncher.java:837)
      at hudson.plugins.sshslaves.SSHLauncher$2.call(SSHLauncher.java:833)
      at java.util.concurrent.FutureTask.run(FutureTask.java:266)
      at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
      at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
      at java.lang.Thread.run(Thread.java:748)
       [04/04/19 15:40:41] Launch failed - cleaning up connection
      

       

      Config.xml

      <?xml version='1.1' encoding='UTF-8'?>
      <slave>
         <name>agentNullHost</name>
         <description>agent description</description>
         <remoteFS>/home/jenkins</remoteFS>
         <numExecutors>1</numExecutors>
         <mode>NORMAL</mode>
         <retentionStrategy class="hudson.slaves.RetentionStrategy$Always"/>
          <launcher class="hudson.plugins.sshslaves.SSHLauncher" plugin="ssh-slaves@1.29.4">
             <port>22</port>
             <credentialsId>my-credentials</credentialsId>
             <launchTimeoutSeconds>210</launchTimeoutSeconds>
             <maxNumRetries>10</maxNumRetries>
             <retryWaitTime>15</retryWaitTime>
             <sshHostKeyVerificationStrategy class="hudson.plugins.sshslaves.verifiers.NonVerifyingKeyVerificationStrategy"/>
             <tcpNoDelay>true</tcpNoDelay>
        </launcher>
        <label>linux</label>
        <nodeProperties/>
      </slave>
      

        Attachments

          Issue Links

            Activity

            Hide
            ifernandezcalvo Ivan Fernandez Calvo added a comment -

            Jira is not a support site see https://wiki.jenkins.io/display/JENKINS/How+to+report+an+issue
            BTW, the host setting is a hostname or an IP address of a host you want to use as an agent to execute jobs in it, does not have too much complication or too much to understand.

            Show
            ifernandezcalvo Ivan Fernandez Calvo added a comment - Jira is not a support site see https://wiki.jenkins.io/display/JENKINS/How+to+report+an+issue BTW, the host setting is a hostname or an IP address of a host you want to use as an agent to execute jobs in it, does not have too much complication or too much to understand.
            Hide
            jenbeg Hao Maio added a comment -

            Ivan Fernandez Calvo: Unfortunately the documentation doesnt say anything about the host:

            https://jenkins.io/doc/book/managing/nodes/

             

            Maybe you have another hint?

            Show
            jenbeg Hao Maio added a comment - Ivan Fernandez Calvo : Unfortunately the documentation doesnt say anything about the host: https://jenkins.io/doc/book/managing/nodes/   Maybe you have another hint?
            Hide
            ifernandezcalvo Ivan Fernandez Calvo added a comment - - edited

            1.30 version will protect against those pitfalls

            Show
            ifernandezcalvo Ivan Fernandez Calvo added a comment - - edited 1.30 version will protect against those pitfalls
            Show
            ifernandezcalvo Ivan Fernandez Calvo added a comment - take a look to the documentation https://wiki.jenkins.io/display/JENKINS/Distributed+builds also https://jenkins.io/doc/pipeline/tour/getting-started/
            Hide
            jenbeg Hao Maio added a comment -

            Ivan Fernandez Calvo: could you please give me any hint, of where I can read more about, what || how to choose the host ip ?

             

            Show
            jenbeg Hao Maio added a comment - Ivan Fernandez Calvo : could you please give me any hint, of where I can read more about, what || how to choose the host ip ?  

              People

              Assignee:
              ifernandezcalvo Ivan Fernandez Calvo
              Reporter:
              jenbeg Hao Maio
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved: