Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-57747

Add form validation for gitlab gold and ultimate server urls

    XMLWordPrintable

    Details

    • Similar Issues:
    • Sprint:
      GSoC 2019. Coding Phase 1

      Description

      Add a default sever url to the it the serverUrl field

      Default url should be:

      https://gitlab.com

      User may want to change it to other server urls like:

      http://gitlab.example.com:7990
      https://gitlab.example.com

        Attachments

          Activity

          Hide
          baymac Parichay Barpanda added a comment -

          In the doCheckServerUrl method, open up the serverUrl and see if it is a valid serverUrl. See how it this part is gone in the Gitea Plugin and the GitHub Plugin.

          Show
          baymac Parichay Barpanda added a comment - In the doCheckServerUrl method, open up the serverUrl and see if it is a valid serverUrl. See how it this part is gone in the Gitea Plugin and the GitHub Plugin.
          Hide
          baymac Parichay Barpanda added a comment -

          No more performing form validation for gitlab server url. Only checking if it is a valid url. Not checking if it a valid gitlab server url. Since gitlab doesn't have a public endpoint to validate the server url. 

          Show
          baymac Parichay Barpanda added a comment - No more performing form validation for gitlab server url. Only checking if it is a valid url. Not checking if it a valid gitlab server url. Since gitlab doesn't have a public endpoint to validate the server url. 
          Show
          baymac Parichay Barpanda added a comment - See  https://github.com/gitlab4j/gitlab4j-api/issues/384
          Hide
          baymac Parichay Barpanda added a comment -

          This can be fixed by fetching a single project from projects endpoint.

          Show
          baymac Parichay Barpanda added a comment - This can be fixed by fetching a single project from projects endpoint.
          Hide
          baymac Parichay Barpanda added a comment -

          Fixed it by fetching public projects from /projects endpoint.

          Show
          baymac Parichay Barpanda added a comment - Fixed it by fetching public projects from /projects endpoint.

            People

            Assignee:
            baymac Parichay Barpanda
            Reporter:
            baymac Parichay Barpanda
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved: