Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-57784

Add a `none` option when no credential is added to server configuration

    XMLWordPrintable

    Details

    • Similar Issues:
    • Sprint:
      GSoC 2019. Coding Phase 1

      Description

      In some cases, user might not require to supply credentials or maybe the credentials listbox is empty. So in that case, credentialsId listbox should display an empty value.

        Attachments

          Activity

          baymac Parichay Barpanda created issue -
          baymac Parichay Barpanda made changes -
          Field Original Value New Value
          Epic Link JENKINS-57445 [ 199258 ]
          baymac Parichay Barpanda made changes -
          Sprint GSoC 2019. Coding Phase 1 [ 686 ]
          Description 1) Add Java 8 functional interfaces for behavioural design pattern

          4) -Add a `none` option when no credential is added to server configuration-

          5) -The credentials list box also enlists credentials generated for other SCMs, same with Gitea Plugin. See how gitlab-plugin and github-plugin do it.- Fixed it by adding a lambda to check if credentials belong our plugin personal Token implementation. Also send PR to Gitea Plugin.

          6) -Add text descriptions to the text boxes for help like GitLab Plugin.-

          All features with strikethroughs are implemented.
           
          In some cases, user might not require to supply credentials or maybe the credentials listbox is empty. So in that case, credentialsId listbox should display an empty value.
          baymac Parichay Barpanda made changes -
          Status Open [ 1 ] In Progress [ 3 ]
          Hide
          baymac Parichay Barpanda added a comment - - edited

          This was fixed by chaining a method to the StandardListBox object returned from the `doFillCredentialsIdItems` method.

          The ListBox returned is:

          new StandardListBoxModel()
          .includeEmptyValue()
          .includeMatchingAs(...)

          This was inspired from GitHub Plugin. Can also be implemented in Gitea Plugin.

          Show
          baymac Parichay Barpanda added a comment - - edited This was fixed by chaining a method to the StandardListBox object returned from the `doFillCredentialsIdItems` method. The ListBox returned is: new StandardListBoxModel() .includeEmptyValue() .includeMatchingAs(...) This was inspired from GitHub Plugin. Can also be implemented in Gitea Plugin.
          baymac Parichay Barpanda made changes -
          Resolution Fixed [ 1 ]
          Status In Progress [ 3 ] Resolved [ 5 ]
          baymac Parichay Barpanda made changes -
          Issue Type Improvement [ 4 ] Bug [ 1 ]

            People

            Assignee:
            baymac Parichay Barpanda
            Reporter:
            baymac Parichay Barpanda
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved: