Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-58126

Make Parsing for Plugin Manager CLI More Robust

XMLWordPrintable

    • GSoC 2019. Coding Phase 2

      The parsing for the plugin manager needs to be more robust. It needs to take into account unwanted characters, a better way to split on ":", and recognize requested plugin parameters.

          [JENKINS-58126] Make Parsing for Plugin Manager CLI More Robust

          Natasha Stopa added a comment - - edited

          Kept parsing to be on ":", but added checks for blank lines and comments.  Pinged the platform sig Gitter channel and in the install-plugins.sh if a url was entered, a placeholder was still kept for version, so I kept it this way. Also asked them about changing delimiters and they wanted to keep the ":" delimiter.

          Partially fixed in https://github.com/jenkinsci/plugin-installation-manager-tool/pull/27, but url input still broken.

          Fixed again in: https://github.com/jenkinsci/plugin-installation-manager-tool/pull/28

           

           

          Natasha Stopa added a comment - - edited Kept parsing to be on ":", but added checks for blank lines and comments.  Pinged the platform sig Gitter channel and in the install-plugins.sh if a url was entered, a placeholder was still kept for version, so I kept it this way. Also asked them about changing delimiters and they wanted to keep the ":" delimiter. Partially fixed in  https://github.com/jenkinsci/plugin-installation-manager-tool/pull/27 , but url input still broken. Fixed again in:  https://github.com/jenkinsci/plugin-installation-manager-tool/pull/28    

            stopalopa Natasha Stopa
            stopalopa Natasha Stopa
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

              Created:
              Updated:
              Resolved: