[JENKINS-58315] Allow to customize serverUrl while using rocketSend step - Jenkins Jira

XML

Word

Printable

Details

Type: New Feature
Status: Fixed but Unreleased (View Workflow)
Priority: Major
Resolution: Fixed
Component/s: rocket-chat-notifier-plugin
Labels:
None

Similar Issues:

Show

Description

Today we can only use one RocketChat instance defined in general settings to send notifications. In our team we use multi RocketChat instances so we cannot use this plugin.

Would be nice if we can define a serverUrl directly in rocketSend step.

Example :

rocketSend serverUrl: 'https://myrocket.example.com', channel: 'general', message: 'My message'

Thanks!

Attachments

Activity

Ascending order - Click to sort in descending order

Martin Reinhardt added a comment - 2019-07-04 02:49

I see the issue, but how would you pass the login info the step? If we add this feature you also need to pass the login info here..

Martin Reinhardt added a comment - 2019-07-04 02:49 I see the issue, but how would you pass the login info the step? If we add this feature you also need to pass the login info here..

Maxime KILT added a comment - 2019-07-04 07:48 - edited

I don't think username/password are necessary when using a token for our incoming webhook. What are they for anyway?

For info, today we use the Slack plugin v2.17 (latest version not working) in a roundabout way for RocketChat:

slackSend(
    channel: 'jenkins',
    message: 'my message',
    baseUrl: 'https://myrocket.example.com/hooks/',
    teamDomain: 'myrocket',
    token: '0123456789'
)

Maxime KILT added a comment - 2019-07-04 07:48 - edited I don't think username/password are necessary when using a token for our incoming webhook. What are they for anyway? For info, today we use the Slack plugin v2.17 (latest version not working) in a roundabout way for RocketChat: slackSend( channel: 'jenkins' , message: 'my message' , baseUrl: 'https: //myrocket.example.com/hooks/' , teamDomain: 'myrocket' , token: '0123456789' )

Martin Reinhardt added a comment - 2019-07-04 08:46

ok, I like the idea, i think could be easily added. But already struggeling with issues on the latest RocketChat API and will take some time to get it fixed

Nevertheless any PR with this feature is welcome

Martin Reinhardt added a comment - 2019-07-04 08:46 ok, I like the idea, i think could be easily added. But already struggeling with issues on the latest RocketChat API and will take some time to get it fixed Nevertheless any PR with this feature is welcome

Maxime KILT added a comment - 2019-07-04 13:50

Yeah I think I will create a PR

Maxime KILT added a comment - 2019-07-04 13:50 Yeah I think I will create a PR

Maxime KILT added a comment - 2019-07-04 14:55

https://github.com/jenkinsci/rocketchatnotifier-plugin/pull/37

Maxime KILT added a comment - 2019-07-04 14:55 https://github.com/jenkinsci/rocketchatnotifier-plugin/pull/37

Martin Reinhardt added a comment - 2019-07-04 19:58

thanks for the PR

Martin Reinhardt added a comment - 2019-07-04 19:58 thanks for the PR