Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-5836

Make subscripton mode for Hudson Jabber user configurable

    XMLWordPrintable

Details

    • New Feature
    • Status: Closed (View Workflow)
    • Minor
    • Resolution: Fixed
    • jabber-plugin
    • None
    • N/A

    Description

      Currently, using a Gmail account for the Hudson Jabber user, the Jabber plug-in will automatically authorize any user that tries to add the Hudson Jabber user to their contact list regardless of the Gmail account settings.

      That is, under Gmail settings > Chat, if one selects the option "Only allow people that I've explicitly approved to chat with me and see when I'm online." for the Hudson Jabber user, the Jabber user will automatically approve the user bypassing the Gmail interface for approving the user by selecting "Yes" or "No".

      You can see this happening if you are logged into the Hudson Jabber user's Gmail account and have someone try to add the user; in the chat window on the left-hand side of the screen, you'll see the Gmail prompt saying "[username] wants to be able to chat with you. Okay?" (See the attached image to see what this looks like) with two buttons "Yes" and "No", however within one second this prompt immediately disappears before you take an action and the user is added to the contact list.

      This feature request is for the Jabber plug-in to allow for users to turn off this auto-authorization behavior so that users that want to add the Hudson Jabber user will need to be screened and authorized through Gmail's interface. This is a security issue because if any gchat user can add Hudson as a buddy then they will be able to control the build process without any trouble.

      Attachments

        Issue Links

          Activity

            kutzi kutzi added a comment -

            Integrated in Jabber plugin 1.7

            kutzi kutzi added a comment - Integrated in Jabber plugin 1.7
            kutzi kutzi added a comment -

            It'd be great if you could try the attached snapshot (you need to install the attached instant-messaging.hpi, too).
            You have to select the wanted subscription mode - which should be 'manual' in your case, I guess - in the global settings.

            kutzi kutzi added a comment - It'd be great if you could try the attached snapshot (you need to install the attached instant-messaging.hpi, too). You have to select the wanted subscription mode - which should be 'manual' in your case, I guess - in the global settings.

            Code changed in hudson
            User: : kutzi
            Path:
            trunk/hudson/plugins/jabber/src/main/java/hudson/plugins/jabber/im/transport/JabberPublisherDescriptor.java
            trunk/hudson/plugins/jabber/src/main/resources/hudson/plugins/jabber/im/transport/JabberPublisher/global.jelly
            trunk/hudson/plugins/jabber/src/main/webapp/help-subscription-mode.html
            http://jenkins-ci.org/commit/28599
            Log:
            JENKINS-5836 make subscription mode for XMPP buddies configurable

            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in hudson User: : kutzi Path: trunk/hudson/plugins/jabber/src/main/java/hudson/plugins/jabber/im/transport/JabberPublisherDescriptor.java trunk/hudson/plugins/jabber/src/main/resources/hudson/plugins/jabber/im/transport/JabberPublisher/global.jelly trunk/hudson/plugins/jabber/src/main/webapp/help-subscription-mode.html http://jenkins-ci.org/commit/28599 Log: JENKINS-5836 make subscription mode for XMPP buddies configurable
            kutzi kutzi added a comment -

            Changed title to reflect the intended implementation:
            Subscription mode should be configurable.

            • accept-all: accept all buddy requests (behaviour until now)
            • reject-all: auto-reject all requests
            • manual: request must be accepted/denied manually - via another XMPP client
            kutzi kutzi added a comment - Changed title to reflect the intended implementation: Subscription mode should be configurable. accept-all: accept all buddy requests (behaviour until now) reject-all: auto-reject all requests manual: request must be accepted/denied manually - via another XMPP client
            kutzi kutzi added a comment -

            Changed title to reflect the intended implementation:
            Subscription mode should be configurable.

            • accept-all: accept all buddy requests (behaviour until now)
            • reject-all: auto-reject all requests
            • manual: request must be accepted/denied manually - via another XMPP client
            kutzi kutzi added a comment - Changed title to reflect the intended implementation: Subscription mode should be configurable. accept-all: accept all buddy requests (behaviour until now) reject-all: auto-reject all requests manual: request must be accepted/denied manually - via another XMPP client

            Code changed in hudson
            User: : kutzi
            Path:
            trunk/hudson/plugins/instant-messaging/src/main/java/hudson/plugins/im/IMMessage.java
            trunk/hudson/plugins/instant-messaging/src/main/java/hudson/plugins/im/bot/Bot.java
            trunk/hudson/plugins/jabber/pom.xml
            trunk/hudson/plugins/jabber/src/main/java/hudson/plugins/jabber/im/transport/JabberChat.java
            trunk/hudson/plugins/jabber/src/main/java/hudson/plugins/jabber/im/transport/JabberIMConnection.java
            trunk/hudson/plugins/jabber/src/main/java/hudson/plugins/jabber/im/transport/JabberMUCMessageListenerAdapter.java
            trunk/hudson/plugins/jabber/src/main/java/hudson/plugins/jabber/im/transport/JabberMessage.java
            trunk/hudson/plugins/jabber/src/main/java/hudson/plugins/jabber/im/transport/JabberMessageListenerAdapter.java
            trunk/hudson/plugins/jabber/src/main/java/hudson/plugins/jabber/im/transport/JabberMultiUserChat.java
            trunk/hudson/plugins/jabber/src/main/java/hudson/plugins/jabber/im/transport/JabberPublisherDescriptor.java
            trunk/hudson/plugins/jabber/src/main/java/hudson/plugins/jabber/im/transport/JabberUtil.java
            trunk/hudson/plugins/jabber/src/main/resources/hudson/plugins/jabber/im/transport/JabberPublisher/global.jelly
            http://jenkins-ci.org/commit/28598
            Log:
            JENKINS-5836 make subscription mode for XMPP buddies configurable

            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in hudson User: : kutzi Path: trunk/hudson/plugins/instant-messaging/src/main/java/hudson/plugins/im/IMMessage.java trunk/hudson/plugins/instant-messaging/src/main/java/hudson/plugins/im/bot/Bot.java trunk/hudson/plugins/jabber/pom.xml trunk/hudson/plugins/jabber/src/main/java/hudson/plugins/jabber/im/transport/JabberChat.java trunk/hudson/plugins/jabber/src/main/java/hudson/plugins/jabber/im/transport/JabberIMConnection.java trunk/hudson/plugins/jabber/src/main/java/hudson/plugins/jabber/im/transport/JabberMUCMessageListenerAdapter.java trunk/hudson/plugins/jabber/src/main/java/hudson/plugins/jabber/im/transport/JabberMessage.java trunk/hudson/plugins/jabber/src/main/java/hudson/plugins/jabber/im/transport/JabberMessageListenerAdapter.java trunk/hudson/plugins/jabber/src/main/java/hudson/plugins/jabber/im/transport/JabberMultiUserChat.java trunk/hudson/plugins/jabber/src/main/java/hudson/plugins/jabber/im/transport/JabberPublisherDescriptor.java trunk/hudson/plugins/jabber/src/main/java/hudson/plugins/jabber/im/transport/JabberUtil.java trunk/hudson/plugins/jabber/src/main/resources/hudson/plugins/jabber/im/transport/JabberPublisher/global.jelly http://jenkins-ci.org/commit/28598 Log: JENKINS-5836 make subscription mode for XMPP buddies configurable
            kutzi kutzi added a comment -

            Has probably to be deferred until I've upgraded to Smack 3.x JENKINS-5805

            kutzi kutzi added a comment - Has probably to be deferred until I've upgraded to Smack 3.x JENKINS-5805

            People

              kutzi kutzi
              rsyamlal rsyamlal
              Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: