Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-58717

Modify ATH to be compatible with new GitHub Branch Source UI

    XMLWordPrintable

Details

    Description

      Summary
      Starting with GitHub Branch Source 2.5.5 (see PR), we now have two ways to set up our remote repo for multibranch projects based on GitHub repositories. This ticket represents the accompanying updates that the acceptance test harness needs in order to make this work.

      Details
      The new UI offers, and defaults to, the ability to supply a single HTTPS URL, in much the same way you'd copy/paste such a URL into a git clone command. The ATH needs to be modified to accomodate this.

      Before the above-mentioned improvement to GitHub Branch Source, users needed to first supply the repository owner. For example, And then, if the repo owner had hundreds or even thousands of repos, it could take a very long time to populate the resulting drop-down menu. My suspicion is that this delay is the reason why the test was set to @Ignore.

      The page now looks like this when creating a new project:

      It's possible that the ATH will also need to maintain some sort of backward compatibility with the old UI.

      Attachments

        Issue Links

          Activity

            kshultz Karl Shultz created issue -
            kshultz Karl Shultz made changes -
            Field Original Value New Value
            Issue Type Bug [ 1 ] Improvement [ 4 ]
            kshultz Karl Shultz made changes -
            Description *Summary*
            Starting with Git

            The new UI offers, and defaults to, the ability to supply a single HTTPS URL, in much the same way you'd copy/paste such a URL into a {{git clone}} command. The ATH needs to be modified to accomodate this.

            The page now looks like this when creating a new project:
             !image-2019-07-29-16-25-51-544.png|thumbnail!

            It's possible that the ATH will also need to maintain some sort of backward compatibility with the old UI.
            *Summary*
            Starting with GitHub Branch Source 2.5.5 (see [PR|https://github.com/jenkinsci/github-branch-source-plugin/pull/236]), we now have two ways to set up our remote repo for multibranch projects based on GitHub repositories. This ticket represents the accompanying updates that the acceptance test harness needs in order to make this work.

            *Details*
            The new UI offers, and defaults to, the ability to supply a single HTTPS URL, in much the same way you'd copy/paste such a URL into a {{git clone}} command. The ATH needs to be modified to accomodate this.

            Before the above-mentioned improvement to GitHub Branch Source, users needed to first supply the repository owner. For example, And then, if the repo owner had hundreds or even thousands of repos, it could take a very long time to populate the resulting drop-down menu. My suspicion is that this delay is the reason why the test was being [{{@Ignore}} d|https://github.com/jenkinsci/acceptance-test-harness/blob/master/src/test/java/plugins/WorkflowMultibranchTest.java#L37].

            The page now looks like this when creating a new project:
             !image-2019-07-29-16-25-51-544.png|thumbnail!

            It's possible that the ATH will also need to maintain some sort of backward compatibility with the old UI.
            kshultz Karl Shultz made changes -
            Description *Summary*
            Starting with GitHub Branch Source 2.5.5 (see [PR|https://github.com/jenkinsci/github-branch-source-plugin/pull/236]), we now have two ways to set up our remote repo for multibranch projects based on GitHub repositories. This ticket represents the accompanying updates that the acceptance test harness needs in order to make this work.

            *Details*
            The new UI offers, and defaults to, the ability to supply a single HTTPS URL, in much the same way you'd copy/paste such a URL into a {{git clone}} command. The ATH needs to be modified to accomodate this.

            Before the above-mentioned improvement to GitHub Branch Source, users needed to first supply the repository owner. For example, And then, if the repo owner had hundreds or even thousands of repos, it could take a very long time to populate the resulting drop-down menu. My suspicion is that this delay is the reason why the test was being [{{@Ignore}} d|https://github.com/jenkinsci/acceptance-test-harness/blob/master/src/test/java/plugins/WorkflowMultibranchTest.java#L37].

            The page now looks like this when creating a new project:
             !image-2019-07-29-16-25-51-544.png|thumbnail!

            It's possible that the ATH will also need to maintain some sort of backward compatibility with the old UI.
            *Summary*
            Starting with GitHub Branch Source 2.5.5 (see [PR|https://github.com/jenkinsci/github-branch-source-plugin/pull/236]), we now have two ways to set up our remote repo for multibranch projects based on GitHub repositories. This ticket represents the accompanying updates that the acceptance test harness needs in order to make this work.

            *Details*
            The new UI offers, and defaults to, the ability to supply a single HTTPS URL, in much the same way you'd copy/paste such a URL into a {{git clone}} command. The ATH needs to be modified to accomodate this.

            Before the above-mentioned improvement to GitHub Branch Source, users needed to first supply the repository owner. For example, And then, if the repo owner had hundreds or even thousands of repos, it could take a very long time to populate the resulting drop-down menu. My suspicion is that this delay is the reason why the test was set to [{{@Ignore}} d|https://github.com/jenkinsci/acceptance-test-harness/blob/master/src/test/java/plugins/WorkflowMultibranchTest.java#L37].

            The page now looks like this when creating a new project:
             !image-2019-07-29-16-25-51-544.png|thumbnail!

            It's possible that the ATH will also need to maintain some sort of backward compatibility with the old UI.
            kshultz Karl Shultz made changes -
            Description *Summary*
            Starting with GitHub Branch Source 2.5.5 (see [PR|https://github.com/jenkinsci/github-branch-source-plugin/pull/236]), we now have two ways to set up our remote repo for multibranch projects based on GitHub repositories. This ticket represents the accompanying updates that the acceptance test harness needs in order to make this work.

            *Details*
            The new UI offers, and defaults to, the ability to supply a single HTTPS URL, in much the same way you'd copy/paste such a URL into a {{git clone}} command. The ATH needs to be modified to accomodate this.

            Before the above-mentioned improvement to GitHub Branch Source, users needed to first supply the repository owner. For example, And then, if the repo owner had hundreds or even thousands of repos, it could take a very long time to populate the resulting drop-down menu. My suspicion is that this delay is the reason why the test was set to [{{@Ignore}} d|https://github.com/jenkinsci/acceptance-test-harness/blob/master/src/test/java/plugins/WorkflowMultibranchTest.java#L37].

            The page now looks like this when creating a new project:
             !image-2019-07-29-16-25-51-544.png|thumbnail!

            It's possible that the ATH will also need to maintain some sort of backward compatibility with the old UI.
            *Summary*
            Starting with GitHub Branch Source 2.5.5 (see [PR|https://github.com/jenkinsci/github-branch-source-plugin/pull/236]), we now have two ways to set up our remote repo for multibranch projects based on GitHub repositories. This ticket represents the accompanying updates that the acceptance test harness needs in order to make this work.

            *Details*
            The new UI offers, and defaults to, the ability to supply a single HTTPS URL, in much the same way you'd copy/paste such a URL into a {{git clone}} command. The ATH needs to be modified to accomodate this.

            Before the above-mentioned improvement to GitHub Branch Source, users needed to first supply the repository owner. For example, And then, if the repo owner had hundreds or even thousands of repos, it could take a very long time to populate the resulting drop-down menu. My suspicion is that this delay is the reason why the test was set to [{{@Ignore}}|https://github.com/jenkinsci/acceptance-test-harness/blob/master/src/test/java/plugins/WorkflowMultibranchTest.java#L37].

            The page now looks like this when creating a new project:
             !image-2019-07-29-16-25-51-544.png|thumbnail!

            It's possible that the ATH will also need to maintain some sort of backward compatibility with the old UI.
            kshultz Karl Shultz made changes -
            Description *Summary*
            Starting with GitHub Branch Source 2.5.5 (see [PR|https://github.com/jenkinsci/github-branch-source-plugin/pull/236]), we now have two ways to set up our remote repo for multibranch projects based on GitHub repositories. This ticket represents the accompanying updates that the acceptance test harness needs in order to make this work.

            *Details*
            The new UI offers, and defaults to, the ability to supply a single HTTPS URL, in much the same way you'd copy/paste such a URL into a {{git clone}} command. The ATH needs to be modified to accomodate this.

            Before the above-mentioned improvement to GitHub Branch Source, users needed to first supply the repository owner. For example, And then, if the repo owner had hundreds or even thousands of repos, it could take a very long time to populate the resulting drop-down menu. My suspicion is that this delay is the reason why the test was set to [{{@Ignore}}|https://github.com/jenkinsci/acceptance-test-harness/blob/master/src/test/java/plugins/WorkflowMultibranchTest.java#L37].

            The page now looks like this when creating a new project:
             !image-2019-07-29-16-25-51-544.png|thumbnail!

            It's possible that the ATH will also need to maintain some sort of backward compatibility with the old UI.
            *Summary*
            Starting with GitHub Branch Source 2.5.5 (see [PR|https://github.com/jenkinsci/github-branch-source-plugin/pull/236]), we now have two ways to set up our remote repo for multibranch projects based on GitHub repositories. This ticket represents the accompanying updates that the acceptance test harness needs in order to make this work.

            *Details*
            The new UI offers, and defaults to, the ability to supply a single HTTPS URL, in much the same way you'd copy/paste such a URL into a {{git clone}} command. The ATH needs to be modified to accomodate this.

            Before the above-mentioned improvement to GitHub Branch Source, users needed to first supply the repository owner. For example, And then, if the repo owner had hundreds or even thousands of repos, it could take a very long time to populate the resulting drop-down menu. My suspicion is that this delay is the reason why [the test was set to {{@Ignore}}|https://github.com/jenkinsci/acceptance-test-harness/blob/e538cb7ffeeeb11ce5aad4de3b6bc59d03b9a56d/src/test/java/plugins/WorkflowMultibranchTest.java#L37].

            The page now looks like this when creating a new project:
             !image-2019-07-29-16-25-51-544.png|thumbnail!

            It's possible that the ATH will also need to maintain some sort of backward compatibility with the old UI.
            kshultz Karl Shultz made changes -
            Assignee Oliver Gond┼ża [ olivergondza ] Karl Shultz [ kshultz ]
            kshultz Karl Shultz added a comment -

            Assigning to myself.

            I'm currently blocked by JENKINS-58071.

            kshultz Karl Shultz added a comment - Assigning to myself. I'm currently blocked by JENKINS-58071 .
            kshultz Karl Shultz made changes -
            Status Open [ 1 ] In Progress [ 3 ]
            kshultz Karl Shultz made changes -
            Link This issue is blocked by JENKINS-58071 [ JENKINS-58071 ]
            kshultz Karl Shultz made changes -
            Link This issue is blocked by JENKINS-58071 [ JENKINS-58071 ]
            kshultz Karl Shultz added a comment -

            I found a way to get past this, so I'm no longer blocked against 58071. But 58071 is still worth looking at.

            The behavior was, when working on the ATH from IntelliJ IDEA, I wanted to set an environment variable specifying a war file. Something like this:

            JENKINS_LOCAL_HOSTNAME=127.0.0.1;BROWSER=chrome;JENKINS_WAR=/some/path/to/jenkins.war
            

            When running that way, I was having problems getting the UI to load correctly. The trace itself can be seen here.

            kshultz Karl Shultz added a comment - I found a way to get past this, so I'm no longer blocked against 58071. But 58071 is still worth looking at. The behavior was, when working on the ATH from IntelliJ IDEA, I wanted to set an environment variable specifying a war file. Something like this: JENKINS_LOCAL_HOSTNAME=127.0.0.1;BROWSER=chrome;JENKINS_WAR=/some/path/to/jenkins.war When running that way, I was having problems getting the UI to load correctly. The trace itself can be seen here .
            kshultz Karl Shultz made changes -
            Link This issue relates to JENKINS-58071 [ JENKINS-58071 ]
            kshultz Karl Shultz added a comment -

            I've got a simple pull request up for review that adds the ability to set a single repository URL from a test, via the new field in GitHub Branch Source 2.5.5.

            kshultz Karl Shultz added a comment - I've got a simple pull request up for review that adds the ability to set a single repository URL from a test, via the new field in GitHub Branch Source 2.5.5.
            kshultz Karl Shultz made changes -
            Status In Progress [ 3 ] In Review [ 10005 ]
            kshultz Karl Shultz added a comment -

            This was fixed with 541.

            kshultz Karl Shultz added a comment - This was fixed with 541 .
            kshultz Karl Shultz made changes -
            Resolution Fixed [ 1 ]
            Status In Review [ 10005 ] Resolved [ 5 ]
            kshultz Karl Shultz made changes -
            Status Resolved [ 5 ] Closed [ 6 ]

            People

              kshultz Karl Shultz
              kshultz Karl Shultz
              Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: