Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-5935

Improve equals method for warnings

    XMLWordPrintable

Details

    Description

      Some checkstyle warnings contain details about the violation:

      File: ProductCmptView.java, Line: 76, Type: ClassDataAbstractionCouplingCheck, Priority: Normal, Category: Metrics

      Message:
      Class Data Abstraction Coupling is 19 (max allowed is 10) classes [AssocFilterListener, Combo, Composite, GridData, GridLayout, IpsObjectViewerComparator, Label, NewProductComponentAction, NewQuestionTypeAction, NewRuleTypeAction, PasteInPCViewAction, Path, ProductCmptGridConfiguration, ProductCmptSearchFilter, ProductCmptViewContentProvider, Separator, ShowProductCmptViewAction, StructuredSelection, ToggleShowAssociationsAction].

      For such warnings, the message should not be part of the equals method.

      Attachments

        Issue Links

          is blocking

          Bug - A problem which impairs or prevents the functions of the product. JENKINS-2968 Findbugs reports some warnings as resolved even if this is not true

          • Major - Major loss of function.
          • Closed
          relates to

          Improvement - An improvement or enhancement to an existing feature or task. JENKINS-58403 Issue marked as new when the issue did exist in a previous build but on a different line

          • Minor - Minor loss of function, or other problem where easy workaround is present.
          • Closed

          Activity

            Ascending order - Click to sort in descending order
            drulli Ulli Hafner created issue -
            drulli Ulli Hafner made changes -
            Field Original Value New Value
            Component/s analysis-core [ 15709 ]
            Component/s checkstyle [ 15512 ]
            drulli Ulli Hafner made changes -
            Link This issue is blocking JENKINS-2968 [ JENKINS-2968 ]
            rtyler R. Tyler Croy made changes -
            Workflow JNJira [ 136027 ] JNJira + In-Review [ 174431 ]
            drulli Ulli Hafner made changes -
            Component/s analysis-model [ 23523 ]
            Component/s warnings-ng-plugin [ 24526 ]
            Component/s analysis-core-plugin [ 15709 ]
            drulli Ulli Hafner made changes -
            Rank Ranked lower
            drulli Ulli Hafner made changes -
            Rank Ranked lower
            drulli Ulli Hafner made changes -
            Rank Ranked lower
            drulli Ulli Hafner made changes -
            Link This issue relates to JENKINS-58403 [ JENKINS-58403 ]

            People

              drulli Ulli Hafner
              drulli Ulli Hafner
              Votes:
              1 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

                Created:
                Updated: