Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-59459

ConnectionStrategy changes not backward compatible

    XMLWordPrintable

Details

    • Bug
    • Status: Resolved (View Workflow)
    • Major
    • Resolution: Fixed
    • ec2-plugin
    • None
    • ec-2.46

    Description

      [The changes||https://github.com/jenkinsci/ec2-plugin/pull/329] https://github.com/jenkinsci/ec2-plugin/pull/329 []|https://github.com/jenkinsci/ec2-plugin/pull/329] to deliver JENKINS-54329 declared the fields "usePrivateDnsName" and "connectUsingPublicIp" as deprecated but at the same time they were made transient, which changes the way they are exported (to the config.xml file for example) and make the template not to be backward compatible.

      Reproduction steps

      • Setup a Jenkins instance with ec2 1.42.1 and configure a ec2 cloud where the two mentioned parameters are set to true (or one of them, the thing is there is a non default value for a boolean field, which would be true).
      • Verify they are exported into the config.xml file.
      • Update ec2 plugin to >1.43 version.
      • I open the cloud configuration, verify the connection strategy has been set accordingly to the previous boolean values, and re-save the configuration.
      • In the config.xml file, the two mentioned fields are now gone.
      • Revert ec2 plugin to 1.42.1
      • If I open the cloud configuration, both values are set to false (default value for a boolean field) given they were not present in the config.xml file.

      Attachments

        Activity

          egutierrez Evaristo Gutierrez created issue -
          egutierrez Evaristo Gutierrez made changes -
          Field Original Value New Value
          Status Open [ 1 ] In Progress [ 3 ]
          egutierrez Evaristo Gutierrez made changes -
          Status In Progress [ 3 ] In Review [ 10005 ]
          egutierrez Evaristo Gutierrez added a comment - https://github.com/jenkinsci/ec2-plugin/pull/400
          egutierrez Evaristo Gutierrez made changes -
          Description [The changes|[https://github.com/jenkinsci/ec2-plugin/pull/329]] to deliver JENKINS-54329 declared the fields "usePrivateDnsName" and "connectUsingPublicIp" as deprecated but at the same time they were made transient, which changes the way they are exported (to the config.xml file for example) and make the template not to be backward compatible.

          *Reproduction steps*
           * Setup a Jenkins instance with ec2 1.42.1 and configure a ec2 cloud where the two mentioned parameters are set to true (or one of them, the thing is there is a non default value for a boolean field, which would be true).
           * Verify they are exported into the config.xml file.
           * Update ec2 plugin to >1.43 version.
           * I open the cloud configuration, verify the connection strategy has been set accordingly to the previous boolean values, and re-save the configuration.
           * In the config.xml file, the two mentioned fields are now gone.
           * Revert ec2 plugin to 1.42.1
           * If I open the cloud configuration, both values are set to false (default value for a boolean field) given they were not present in the config.xml file.
          [[The changes||https://github.com/jenkinsci/ec2-plugin/pull/329] [https://github.com/jenkinsci/ec2-plugin/pull/329] []|https://github.com/jenkinsci/ec2-plugin/pull/329] to deliver JENKINS-54329 declared the fields "usePrivateDnsName" and "connectUsingPublicIp" as deprecated but at the same time they were made transient, which changes the way they are exported (to the config.xml file for example) and make the template not to be backward compatible.

          *Reproduction steps*
           * Setup a Jenkins instance with ec2 1.42.1 and configure a ec2 cloud where the two mentioned parameters are set to true (or one of them, the thing is there is a non default value for a boolean field, which would be true).
           * Verify they are exported into the config.xml file.
           * Update ec2 plugin to >1.43 version.
           * I open the cloud configuration, verify the connection strategy has been set accordingly to the previous boolean values, and re-save the configuration.
           * In the config.xml file, the two mentioned fields are now gone.
           * Revert ec2 plugin to 1.42.1
           * If I open the cloud configuration, both values are set to false (default value for a boolean field) given they were not present in the config.xml file.
          egutierrez Evaristo Gutierrez made changes -
          Description [[The changes||https://github.com/jenkinsci/ec2-plugin/pull/329] [https://github.com/jenkinsci/ec2-plugin/pull/329] []|https://github.com/jenkinsci/ec2-plugin/pull/329] to deliver JENKINS-54329 declared the fields "usePrivateDnsName" and "connectUsingPublicIp" as deprecated but at the same time they were made transient, which changes the way they are exported (to the config.xml file for example) and make the template not to be backward compatible.

          *Reproduction steps*
           * Setup a Jenkins instance with ec2 1.42.1 and configure a ec2 cloud where the two mentioned parameters are set to true (or one of them, the thing is there is a non default value for a boolean field, which would be true).
           * Verify they are exported into the config.xml file.
           * Update ec2 plugin to >1.43 version.
           * I open the cloud configuration, verify the connection strategy has been set accordingly to the previous boolean values, and re-save the configuration.
           * In the config.xml file, the two mentioned fields are now gone.
           * Revert ec2 plugin to 1.42.1
           * If I open the cloud configuration, both values are set to false (default value for a boolean field) given they were not present in the config.xml file.
          [The changes||https://github.com/jenkinsci/ec2-plugin/pull/329] [https://github.com/jenkinsci/ec2-plugin/pull/329] []|https://github.com/jenkinsci/ec2-plugin/pull/329] to deliver JENKINS-54329 declared the fields "usePrivateDnsName" and "connectUsingPublicIp" as deprecated but at the same time they were made transient, which changes the way they are exported (to the config.xml file for example) and make the template not to be backward compatible.

          *Reproduction steps*
           * Setup a Jenkins instance with ec2 1.42.1 and configure a ec2 cloud where the two mentioned parameters are set to true (or one of them, the thing is there is a non default value for a boolean field, which would be true).
           * Verify they are exported into the config.xml file.
           * Update ec2 plugin to >1.43 version.
           * I open the cloud configuration, verify the connection strategy has been set accordingly to the previous boolean values, and re-save the configuration.
           * In the config.xml file, the two mentioned fields are now gone.
           * Revert ec2 plugin to 1.42.1
           * If I open the cloud configuration, both values are set to false (default value for a boolean field) given they were not present in the config.xml file.
          egutierrez Evaristo Gutierrez made changes -
          Resolution Fixed [ 1 ]
          Status In Review [ 10005 ] Resolved [ 5 ]
          egutierrez Evaristo Gutierrez made changes -
          Released As ec-2.46

          People

            egutierrez Evaristo Gutierrez
            egutierrez Evaristo Gutierrez
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: