Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-59580

NPE in OSProcess#hasMatchingEnvVars on Windows

    XMLWordPrintable

Details

    • Bug
    • Status: Closed (View Workflow)
    • Major
    • Resolution: Fixed
    • core
    • Windows, Jenkins Core master from GitHub
    • 2.199

    Description

      Reproducing code:

              OUTER:
              while (true) {
                  for (OSProcess proc : ProcessTree.get()) {
                      if (proc.hasMatchingEnvVars(Collections.singletonMap("foo", "bar"))) { //-------- fails with NPE
                          break OUTER;
                      }
                  }
              }

      Analysis:
      1. OSProcess#hasMatchingEnvVars assumes that OSProcess#getEnvironmentVariables never returns null (and its Javadoc says so).
      2. There's a time frame between ProcessTree.get() and call to getEnvironmentVariables
      3. If proccess exits during this timeframe, an exception is thrown by org.jvnet.winp.WinProcess#getEnvironmentVariables, propagated through WindowsOSProcess#getEnvironmentVariables2, then caught in WindowsOSProcess#getEnvironmentVariables
      4. And finally, WindowsOSProcess#getEnvironmentVariables returns null, thus violating contract from superclass Javadoc.

      Attachments

        Issue Links

          Activity

            slonopotamusorama Marat Radchenko created issue -
            slonopotamusorama Marat Radchenko made changes -
            Field Original Value New Value
            Remote Link This issue links to "PR#4231 (Web Link)" [ 23731 ]
            slonopotamusorama Marat Radchenko made changes -
            Description Reproducing code:

            {code} OUTER:
                    while (true) {
                        for (OSProcess proc : ProcessTree.get()) {
                            if (proc.hasMatchingEnvVars(Collections.singletonMap("foo", "bar"))) {
                                break OUTER;
                            }
                        }
                    }{code}

            Analysis:
            1. {{OSProcess#hasMatchingEnvVars}} assumes that {{OSProcess#getEnvironmentVariables}} never returns null (and its Javadoc says so).
            2. There's a time frame between {{ProcessTree.get()}} and call to {{getEnvironmentVariables}}
            3. If proccess exits during this timeframe, an exception is thrown by {{org.jvnet.winp.WinProcess#getEnvironmentVariables}}, propagated through {{WindowsOSProcess#getEnvironmentVariables2}}, then caught in {{WindowsOSProcess#getEnvironmentVariables}}
            4. And finally, {{WindowsOSProcess#getEnvironmentVariables}} returns null, thus violating contract from superclass Javadoc.
            Reproducing code:

            {code} OUTER:
                    while (true) {
                        for (OSProcess proc : ProcessTree.get()) {
                            if (proc.hasMatchingEnvVars(Collections.singletonMap("foo", "bar"))) { //-------- fails with NPE
                                break OUTER;
                            }
                        }
                    }{code}

            Analysis:
            1. {{OSProcess#hasMatchingEnvVars}} assumes that {{OSProcess#getEnvironmentVariables}} never returns null (and its Javadoc says so).
            2. There's a time frame between {{ProcessTree.get()}} and call to {{getEnvironmentVariables}}
            3. If proccess exits during this timeframe, an exception is thrown by {{org.jvnet.winp.WinProcess#getEnvironmentVariables}}, propagated through {{WindowsOSProcess#getEnvironmentVariables2}}, then caught in {{WindowsOSProcess#getEnvironmentVariables}}
            4. And finally, {{WindowsOSProcess#getEnvironmentVariables}} returns null, thus violating contract from superclass Javadoc.
            slonopotamusorama Marat Radchenko made changes -
            Released As 2.199
            Resolution Fixed [ 1 ]
            Status Open [ 1 ] Fixed but Unreleased [ 10203 ]
            danielbeck Daniel Beck made changes -
            Status Fixed but Unreleased [ 10203 ] Closed [ 6 ]
            oleg_nenashev Oleg Nenashev made changes -
            Labels lts-candidate
            olivergondza Oliver Gond┼ża made changes -
            Labels lts-candidate 2.190.2-fixed

            People

              Unassigned Unassigned
              slonopotamusorama Marat Radchenko
              Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: