• Type: Bug
• Resolution: Fixed
• Priority: Critical
• Component/s: branch-api-plugin
• Labels:

  None

[JENKINS-59756] NameEncoder.decode can introduce duplicate characters per build to name-utf8.txt

Karl Shultz created issue - 2019-10-11 20:52

Karl Shultz made changes - 2019-10-11 20:53

Link

New: This issue is caused by JENKINS-41124 [ JENKINS-41124 ]

Devin Nusbaum made changes - 2019-10-11 21:00

Remote Link

New: This issue links to "jenkinsci/branch-api-plugin#168 (Web Link)" [ 23825 ]

Karl Shultz made changes - 2019-10-11 21:04

Description

Original: *Summary* Branch names with [reserved URL characters|https://www.w3.org/Addressing/URL/4_URI_Recommentations.html] in them, such as {{/}}, surface a bug in {{NameEncoder.decode()}}. Other characters can surface this bug too, such as {{.}}, {{..}}, and an empty space. *Details* With multibranch pipelines that have branch names including these reserved URL characters, such as the {{/}} in {{feature/branch-name}}, this method gets called as part of the creation of a file called {{name-utf8.txt}}, which defines the computed folders for the branch jobs containing these special characters. The bug causes this file to essentially double in size. The issue lies [here|https://github.com/jenkinsci/branch-api-plugin/blob/847348f6c741f9ac350c138d6267e41a081b89e4/src/main/java/jenkins/branch/NameEncoder.java#L209-L240].

New: *Summary* Branch names with [reserved URL characters|https://www.w3.org/Addressing/URL/4_URI_Recommentations.html] in them, such as {{/}}, surface a bug in {{NameEncoder.decode()}}. Other characters can surface this bug too, such as {{.}}, {{..}}, and an empty space. It appears to only affect jobs which were migrated, back in the timeframe of [JENKINS-41124|https://issues.jenkins-ci.org/browse/JENKINS-41124]. This hasn't been recreated on a "real" environment with post-41124 projects. *Details* With multibranch pipelines that have branch names including these reserved URL characters, such as the {{/}} in {{feature/branch-name}}, this method gets called as part of the creation of a file called {{name-utf8.txt}}, which defines the computed folders for the branch jobs containing these special characters. The bug causes this file to essentially double in size. The issue lies [here|https://github.com/jenkinsci/branch-api-plugin/blob/847348f6c741f9ac350c138d6267e41a081b89e4/src/main/java/jenkins/branch/NameEncoder.java#L209-L240].

Karl Shultz made changes - 2019-10-17 19:24

Status

Original: Open [ 1 ]

New: In Progress [ 3 ]

Liam Newman made changes - 2020-02-11 00:20

Resolution		New: Fixed [ 1 ]
Status	Original: In Progress [ 3 ]	New: Resolved [ 5 ]