Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-60074

Empty array returned with p4sync after 1.10.6

XMLWordPrintable

    • Icon: Improvement Improvement
    • Resolution: Fixed
    • Icon: Major Major
    • p4-plugin
    • P4-Plugin 1.10.6

      Copied from JENKINS-52806:

      alisdair_robertson added a comment - 6 hours ago

      Prior to this change the p4sync step yielded a map of the env vars, I'm using this in many pipeline scripts. After updating to 1.10.6 from 1.10.4 the p4sync step returns an empty map (breaking my pipeline scripts!)

      Was this expected?

          [JENKINS-60074] Empty array returned with p4sync after 1.10.6

          Karl Wirth added a comment -

          Hi alisdair_robertson,

          Thanks for highlighting this. I was easily able to reproduce this so will pass to the developers.

           

          Reproduction steps

          Jenkins 2.176.1

          Create a Jenkins pipeline job and put the following code in the Pipeline script section:

          node() {
        node {
            def scmVars = p4sync charset: 'none', credential: 'JenkinsMaster', populate: autoClean(delete: true, modtime: false, parallel: [enable: false, minbytes: '1024', minfiles: '1', threads: '4'], pin: '', quiet: false, replace: true, tidy: false), source: streamSource('//streams/main')
            echo "Result was ${scmVars}"
        }
    }

          On p4-plugin 1.10.4 the result is:

          [Pipeline] echo
Result was [HUDSON_CHANGELOG_FILE:/var/lib/jenkins/jobs/PipelineEditorNode/builds/8/changelog0.xml, P4_CHANGELIST:2090, P4_CLIENT:jenkins-master-PipelineEditorNode-2, P4_PORT:perforce:1666, P4_ROOT:/var/lib/jenkins/workspace/PipelineEditorNode%402, P4_TICKET:6B786DA4A0A6298A60822A383758D0C4, P4_USER:super]

          On p4-plugin 1.10.6 the result set is empty:

          [Pipeline] echo
Result was [:]

          Karl Wirth added a comment - Hi alisdair_robertson , Thanks for highlighting this. I was easily able to reproduce this so will pass to the developers.   Reproduction steps Jenkins 2.176.1 Create a Jenkins pipeline job and put the following code in the Pipeline script section: node() { node { def scmVars = p4sync charset: 'none' , credential: 'JenkinsMaster' , populate: autoClean(delete: true , modtime: false , parallel: [enable: false , minbytes: '1024' , minfiles: '1' , threads: '4' ], pin: '', quiet: false , replace: true , tidy: false ), source: streamSource(' //streams/main') echo "Result was ${scmVars}" } } On p4-plugin 1.10.4 the result is: [Pipeline] echo Result was [HUDSON_CHANGELOG_FILE:/ var /lib/jenkins/jobs/PipelineEditorNode/builds/8/changelog0.xml, P4_CHANGELIST:2090, P4_CLIENT:jenkins-master-PipelineEditorNode-2, P4_PORT:perforce:1666, P4_ROOT:/ var /lib/jenkins/workspace/PipelineEditorNode%402, P4_TICKET:6B786DA4A0A6298A60822A383758D0C4, P4_USER: super ] On p4-plugin 1.10.6 the result set is empty: [Pipeline] echo Result was [:]

          Alisdair Robertson added a comment -

          Thanks for this Karl! I hope it's an easy fix.

          This originally occurred for us on the latest Jenkins version (2.190.2)

          Alisdair Robertson added a comment - Thanks for this Karl! I hope it's an easy fix. This originally occurred for us on the latest Jenkins version (2.190.2)

          Paul Allen added a comment -

          Passes internal tests - pushed to master

          It may fail CI builds as Jenkins infra has been a bit sensitive lately.

          https://ci.jenkins.io/job/Plugins/job/p4-plugin/job/master/409/

          Paul Allen added a comment - Passes internal tests - pushed to master It may fail CI builds as Jenkins infra has been a bit sensitive lately. https://ci.jenkins.io/job/Plugins/job/p4-plugin/job/master/409/

          Paul Allen added a comment -

          Released in 1.10.7

          (cleaning up old issues)

          Paul Allen added a comment - Released in 1.10.7 (cleaning up old issues)

            Unassigned Unassigned
            p4karl Karl Wirth
            Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

              Created:
              Updated:
              Resolved: