• Icon: Bug Bug
    • Resolution: Fixed
    • Icon: Critical Critical
    • core
    • Jenkins version 2.214
      Linux VM (Ubuntu 16.04.6 LTS)
    • 2.217

      Hello,

      since the update of our jenkins to version 2.214 we encounter problems when being logged in as an administrative user (using the german language requested by the browser, this ist important).

      The update indicator (showing jenkins update) produces an error:

       

      org.apache.commons.jelly.JellyTagException: jar:file:/usr/local/jenkins/jenkins-home/war/WEB-INF/lib/jenkins-core-2.214.jar!/hudson/model/UpdateCenter/CoreUpdateMonitor/message.jelly:53:20: <j:otherwise> can't parse argument number: changelog.url
      {{ at org.apache.commons.jelly.impl.TagScript.handleException(TagScript.java:726)}}
      {{ at org.apache.commons.jelly.impl.TagScript.run(TagScript.java:281)}}
      {{ at org.apache.commons.jelly.impl.ScriptBlock.run(ScriptBlock.java:95)}}

       

      My guess is, that the following commit is the reason for this:

      https://github.com/jenkinsci/jenkins/commit/0ba0ea93d5fc36f1ecb2183cfdbcbec1f93b33ac#diff-98cf1bef361bc3e72fed2160bf895f40

       

      Maybe, all message properties should be changed to use "{2}" instead of "${changelog.url}" ?

      The standard properties file contains the following message pattern:
      {{NewVersionAvailable=<strong>New version of Jenkins ({0}) is available</strong> for <a href="{1}">download</a> }}
      {{ (<a href="{2}">changelog</a>).}}

      The german properties file producing the error contains the following pattern instead:

      NewVersionAvailable=Eine neue Version von Jenkins ({0}) kann <a href="{1}">hier heruntergeladen</a> werden (<a href="${changelog.url}">Was ist neu?</a>).

      As far as I saw there we additional files having the same pattern like the german one. Maybe they produce issues as well?

       

      Best regards,

      Heiko

          [JENKINS-60822] can't parse argument number: changelog.url

          H. Feldker created issue -

          laurent gil added a comment - - edited

          I have exactly the same issue with chrome configured with french regional settings.

          I changed Chrome regional setting to US english and it works.

          laurent gil added a comment - - edited I have exactly the same issue with chrome configured with french regional settings. I changed Chrome regional setting to US english and it works.

          H. Feldker added a comment -

          So, I just fixed my local jenkins-core-2.214.jar file by changing the file

          /hudson/model/UpdateCenter/CoreUpdateMonitor/message_de.properties

          to use [...]<a href="{2}">[...] instead of [...]<a href="${changelog.url}">[...] and jenkins worked again as expected.

          angegar My patched jar file is too big to upload here, but the process is quite simple: extract the jar file from your jenkins installation (located in jenkins-home/war/WEB-INF/lib/) to a local directory and change the message_fr.properties file in the location mentioned above to use "{2}" instead of "${changelog.url}". So if you are desperate you could fix this yourself, but I won't recommend that for a production system.

          Generally I would hope that this issue will be fixed soon in the standard distribution. Since I don't have a github account (yet) I cannot create a pull request for the change. I'm sorry about that.

           

          H. Feldker added a comment - So, I just fixed my local jenkins-core-2.214.jar file by changing the file /hudson/model/UpdateCenter/CoreUpdateMonitor/message_de.properties to use [...] <a href="{2}"> [...] instead of [...] <a href="${changelog.url}"> [...] and jenkins worked again as expected. angegar My patched jar file is too big to upload here, but the process is quite simple: extract the jar file from your jenkins installation (located in jenkins-home/war/WEB-INF/lib/) to a local directory and change the message_fr.properties file in the location mentioned above to use "{2}" instead of "${changelog.url}". So if you are desperate you could fix this yourself, but I won't recommend that for a production system. Generally I would hope that this issue will be fixed soon in the standard distribution. Since I don't have a github account (yet) I cannot create a pull request for the change. I'm sorry about that.  

          Jon Brohauge added a comment - - edited

          Working on a PR for this issue, using the exact solution provided above. I'm updating all the message_XX.properties files in stead of only fr and de.
          Will update this issue when I've got it done.

           

          [PR|https://github.com/jenkinsci/jenkins/pull/4440]

          Jon Brohauge added a comment - - edited Working on a PR for this issue, using the exact solution provided above. I'm updating all the message_XX.properties files in stead of only fr and de. Will update this issue when I've got it done.   [PR| https://github.com/jenkinsci/jenkins/pull/4440 ]
          Jesse Glick made changes -
          Link New: This issue is duplicated by JENKINS-60824 [ JENKINS-60824 ]
          Jesse Glick made changes -
          Labels New: regression
          Jesse Glick made changes -
          Assignee New: Jon Jon [ jon ]
          Jesse Glick made changes -
          Assignee Original: Jon Jon [ jon ] New: Jon Brohauge [ jnz_topdanmark ]
          Jesse Glick made changes -
          Status Original: Open [ 1 ] New: In Progress [ 3 ]
          Jesse Glick made changes -
          Status Original: In Progress [ 3 ] New: In Review [ 10005 ]

            jnz_topdanmark Jon Brohauge
            webwart H. Feldker
            Votes:
            3 Vote for this issue
            Watchers:
            11 Start watching this issue

              Created:
              Updated:
              Resolved: