Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-60940

Convert git client plugin tests from JUnit 3 to JUnit 4

    • 3.13.0

      The git client plugin tests have started their transition process to retire the JUnit 3 based GitAPITestCase, CliGitAPIImplTest, and JGitAPIImplTest. They should be replaced by the parameterized GitClientTest.

      For each test in GitAPITestCase, CliGitAPIImplTest, and JGitAPIImplTest:

      • If it is already tested in GitClientTest, delete the test from the JUnit 3 based tests
      • If it is not already tested in GitClientTest, write a test in GitClientTest or in a new test class and delete the test from the JUnit 3 based tests

      This issue could be worked by multiple people concurrently, so long as they coordinate with one another on the specific tests they are converting.

          [JENKINS-60940] Convert git client plugin tests from JUnit 3 to JUnit 4

          Mark Waite created issue -
          Mark Waite made changes -
          Assignee Original: Mark Waite [ markewaite ]

          Hi markewaite

          While I was looking at some test cases written in Junit 3, I can see those tests using private methods provided by a private inner class. While porting those tests, would you consider making those classes public so that GitClientTest can access it or would you like a plain copy of that particular private class? 

          If there is a better option would like to hear that!

          Rishabh Budhouliya added a comment - Hi markewaite ,  While I was looking at some test cases written in Junit 3, I can see those tests using private  methods provided by a private inner class. While porting those tests, would you consider making those classes public so that GitClientTest can access it or would you like a plain copy of that particular private class?  If there is a better option would like to hear that!

          Mark Waite added a comment -

          You're welcome to convert private inner classes in tests into public classes.

          Mark Waite added a comment - You're welcome to convert private inner classes in tests into public classes.

          Hi,

          I can also work on this transition process. markewaite rishabhbudhouliya 

          Loghi Perinpanayagam added a comment - Hi, I can also work on this transition process. markewaite rishabhbudhouliya  

          Hi loghijiaha,

          I have ported the CliGitAPIImplTest Junit 3 tests to GitClientTest.

          You can work on GitAPITestCase or JGitAPIImplTest. Please mention the class here so that anyone can work on the other one. Thanks!

          Rishabh Budhouliya added a comment - Hi loghijiaha , I have ported the  CliGitAPIImplTest  Junit 3 tests to  GitClientTest . You can work on GitAPITestCase or JGitAPIImplTest. Please mention the class here so that anyone can work on the other one. Thanks!

          I will work on JGitAPIImplTest.

           

          Loghi Perinpanayagam added a comment - I will work on JGitAPIImplTest.  
          Mark Waite made changes -
          Status Original: Open [ 1 ] New: In Progress [ 3 ]

          Mark Waite added a comment -

          Thank you very much to both of you, loghijiaha and rishabhbudhouliya!

          Mark Waite added a comment - Thank you very much to both of you, loghijiaha and rishabhbudhouliya !

          Any efficient idea you could suggest to check whether the test already implemented or not in GitClientTest ?

          Loghi Perinpanayagam added a comment - Any efficient idea you could suggest to check whether the test already implemented or not in GitClientTest ?

            hrushi20 Hrushi20
            markewaite Mark Waite
            Votes:
            0 Vote for this issue
            Watchers:
            7 Start watching this issue

              Created:
              Updated:
              Resolved: