[JENKINS-61197] Running a job with a custom workspace set to eg. 'F:\' causes NullPointerException - Jenkins Jira

XML

Word

Printable

Details

Type: Bug
Status: Resolved (View Workflow)
Priority: Major
Resolution: Fixed
Component/s: core, workflow-durable-task-step-plugin
Labels:
- 2.222.1-rejected
- regression
Environment:
Jenkins ver 2.221, Windows SBS 2012

Similar Issues:

Show
Released As:
2.223

Description

After upgrading fom ver 2.211 to ver 2.221 jobs with a drive as custom workspace throw a NullPointerException immediately:

 Running as SYSTEM
 [EnvInject] - Loading node environment variables.
 Baue auf Master in Arbeitsbereich F:\
 FATAL: null
 java.lang.NullPointerException
	at hudson.FilePath.sibling(FilePath.java:1327)
	at hudson.slaves.WorkspaceList.tempDir(WorkspaceList.java:306)
	at hudson.model.AbstractBuild.getEnvironment(AbstractBuild.java:868)
	at hudson.scm.SubversionSCM.checkout(SubversionSCM.java:852)
	at hudson.scm.SCM.checkout(SCM.java:505)
	at hudson.model.AbstractProject.checkout(AbstractProject.java:1206)
	at hudson.model.AbstractBuild$AbstractBuildExecution.defaultCheckout(AbstractBuild.java:574)
	at jenkins.scm.SCMCheckoutStrategy.checkout(SCMCheckoutStrategy.java:86)
	at hudson.model.AbstractBuild$AbstractBuildExecution.run(AbstractBuild.java:499)
	at hudson.model.Run.execute(Run.java:1856)
	at hudson.model.FreeStyleBuild.run(FreeStyleBuild.java:43)
	at hudson.model.ResourceController.execute(ResourceController.java:97)
	at hudson.model.Executor.run(Executor.java:428)
 ERROR: Build step failed with exception

Attachments

Issue Links

is caused by

JENKINS-60634 Define WORKSPACE_TMP=.../workspace/jobname@tmp

Resolved

links to

jenkins #4527

workflow-durable-task-step #129

Activity

Ascending order - Click to sort in descending order

Frank Schlottmann-Gödde created issue - 2020-02-24 12:05

Frank Schlottmann-Gödde made changes - 2020-02-24 12:06

Field	Original Value	New Value
Description	After upgrading fom ver 2.211 to ver 2.221 jobs with a drive as custom workspace throw a NullPointerException immediately: 00:00:00.002 Running as SYSTEM00:00:00.002 [EnvInject] - Loading node environment variables.00:00:00.003 Baue auf Master in Arbeitsbereich F:\00:00:00.004 FATAL: null00:00:00.005 java.lang.NullPointerException00:00:00.005 at hudson.FilePath.sibling(FilePath.java:1327)00:00:00.005 at hudson.slaves.WorkspaceList.tempDir(WorkspaceList.java:306)00:00:00.005 at hudson.model.AbstractBuild.getEnvironment(AbstractBuild.java:868)00:00:00.005 at hudson.scm.SubversionSCM.checkout(SubversionSCM.java:852)00:00:00.005 at hudson.scm.SCM.checkout(SCM.java:505)00:00:00.005 at hudson.model.AbstractProject.checkout(AbstractProject.java:1206)00:00:00.005 at hudson.model.AbstractBuild$AbstractBuildExecution.defaultCheckout(AbstractBuild.java:574)00:00:00.005 at jenkins.scm.SCMCheckoutStrategy.checkout(SCMCheckoutStrategy.java:86)00:00:00.005 at hudson.model.AbstractBuild$AbstractBuildExecution.run(AbstractBuild.java:499)00:00:00.005 at hudson.model.Run.execute(Run.java:1856)00:00:00.005 at hudson.model.FreeStyleBuild.run(FreeStyleBuild.java:43)00:00:00.005 at hudson.model.ResourceController.execute(ResourceController.java:97)00:00:00.005 at hudson.model.Executor.run(Executor.java:428)00:00:00.005 ERROR: Build step failed with exception	After upgrading fom ver 2.211 to ver 2.221 jobs with a drive as custom workspace throw a NullPointerException immediately: Running as SYSTEM [EnvInject] - Loading node environment variables. Baue auf Master in Arbeitsbereich F:\ FATAL: null java.lang.NullPointerException at hudson.FilePath.sibling(FilePath.java:1327) at hudson.slaves.WorkspaceList.tempDir(WorkspaceList.java:306) at hudson.model.AbstractBuild.getEnvironment(AbstractBuild.java:868) at hudson.scm.SubversionSCM.checkout(SubversionSCM.java:852) at hudson.scm.SCM.checkout(SCM.java:505) at hudson.model.AbstractProject.checkout(AbstractProject.java:1206) at hudson.model.AbstractBuild$AbstractBuildExecution.defaultCheckout(AbstractBuild.java:574) at jenkins.scm.SCMCheckoutStrategy.checkout(SCMCheckoutStrategy.java:86) at hudson.model.AbstractBuild$AbstractBuildExecution.run(AbstractBuild.java:499) at hudson.model.Run.execute(Run.java:1856) at hudson.model.FreeStyleBuild.run(FreeStyleBuild.java:43) at hudson.model.ResourceController.execute(ResourceController.java:97) at hudson.model.Executor.run(Executor.java:428) ERROR: Build step failed with exception

Frank Schlottmann-Gödde made changes - 2020-02-24 12:07

Description

After upgrading fom ver 2.211 to ver 2.221 jobs with a drive as custom workspace throw
a NullPointerException immediately:
Running as SYSTEM
[EnvInject] - Loading node environment variables.
Baue auf Master in Arbeitsbereich F:\
FATAL: null
java.lang.NullPointerException
at hudson.FilePath.sibling(FilePath.java:1327)
at hudson.slaves.WorkspaceList.tempDir(WorkspaceList.java:306)
at hudson.model.AbstractBuild.getEnvironment(AbstractBuild.java:868)
at hudson.scm.SubversionSCM.checkout(SubversionSCM.java:852)
at hudson.scm.SCM.checkout(SCM.java:505)
at hudson.model.AbstractProject.checkout(AbstractProject.java:1206)
at hudson.model.AbstractBuild$AbstractBuildExecution.defaultCheckout(AbstractBuild.java:574)
at jenkins.scm.SCMCheckoutStrategy.checkout(SCMCheckoutStrategy.java:86)
at hudson.model.AbstractBuild$AbstractBuildExecution.run(AbstractBuild.java:499)
at hudson.model.Run.execute(Run.java:1856)
at hudson.model.FreeStyleBuild.run(FreeStyleBuild.java:43)
at hudson.model.ResourceController.execute(ResourceController.java:97)
at hudson.model.Executor.run(Executor.java:428)
ERROR: Build step failed with exception

After upgrading fom ver 2.211 to ver 2.221 jobs with a drive as custom workspace throw
a NullPointerException immediately:

Running as SYSTEM
[EnvInject] - Loading node environment variables.
Baue auf Master in Arbeitsbereich F:\
FATAL: null
java.lang.NullPointerException
at hudson.FilePath.sibling(FilePath.java:1327)
at hudson.slaves.WorkspaceList.tempDir(WorkspaceList.java:306)
at hudson.model.AbstractBuild.getEnvironment(AbstractBuild.java:868)
at hudson.scm.SubversionSCM.checkout(SubversionSCM.java:852)
at hudson.scm.SCM.checkout(SCM.java:505)
at hudson.model.AbstractProject.checkout(AbstractProject.java:1206)
at hudson.model.AbstractBuild$AbstractBuildExecution.defaultCheckout(AbstractBuild.java:574)
at jenkins.scm.SCMCheckoutStrategy.checkout(SCMCheckoutStrategy.java:86)
at hudson.model.AbstractBuild$AbstractBuildExecution.run(AbstractBuild.java:499)
at hudson.model.Run.execute(Run.java:1856)
at hudson.model.FreeStyleBuild.run(FreeStyleBuild.java:43)
at hudson.model.ResourceController.execute(ResourceController.java:97)
at hudson.model.Executor.run(Executor.java:428)
ERROR: Build step failed with exception

Oleg Nenashev made changes - 2020-02-24 14:02

Labels

regression

Oleg Nenashev added a comment - 2020-02-24 15:48

There is no recent changes in the codebase: https://github.com/jenkinsci/jenkins/blame/master/core/src/main/java/hudson/FilePath.java#L1327

Oleg Nenashev added a comment - 2020-02-24 15:48 There is no recent changes in the codebase: https://github.com/jenkinsci/jenkins/blame/master/core/src/main/java/hudson/FilePath.java#L1327

Frank Schlottmann-Gödde added a comment - 2020-02-25 11:32

It is probably this:
https://github.com/jenkinsci/jenkins/commit/84f66e3c4ee32b96585c580c325288d20aef104f

Frank Schlottmann-Gödde added a comment - 2020-02-25 11:32 It is probably this: https://github.com/jenkinsci/jenkins/commit/84f66e3c4ee32b96585c580c325288d20aef104f

Oleg Nenashev added a comment - 2020-02-25 11:36

Looks very plausible. AFAICT there is a bug in the code I may be able to fix quickly

Oleg Nenashev added a comment - 2020-02-25 11:36 Looks very plausible. AFAICT there is a bug in the code I may be able to fix quickly

Oleg Nenashev made changes - 2020-02-25 11:36

Assignee

Oleg Nenashev [ oleg_nenashev ]

Oleg Nenashev made changes - 2020-02-25 11:36

Status

Open [ 1 ]

In Progress [ 3 ]

Jesse Glick made changes - 2020-02-25 13:21

Link

This issue is caused by ~~JENKINS-60634~~ [ ~~JENKINS-60634~~ ]

Jesse Glick made changes - 2020-02-25 13:21

Labels

regression

regression windows

Jesse Glick made changes - 2020-02-25 13:27

Description

After upgrading fom ver 2.211 to ver 2.221 jobs with a drive as custom workspace throw
a NullPointerException immediately:

Running as SYSTEM
[EnvInject] - Loading node environment variables.
Baue auf Master in Arbeitsbereich F:\
FATAL: null
java.lang.NullPointerException
at hudson.FilePath.sibling(FilePath.java:1327)
at hudson.slaves.WorkspaceList.tempDir(WorkspaceList.java:306)
at hudson.model.AbstractBuild.getEnvironment(AbstractBuild.java:868)
at hudson.scm.SubversionSCM.checkout(SubversionSCM.java:852)
at hudson.scm.SCM.checkout(SCM.java:505)
at hudson.model.AbstractProject.checkout(AbstractProject.java:1206)
at hudson.model.AbstractBuild$AbstractBuildExecution.defaultCheckout(AbstractBuild.java:574)
at jenkins.scm.SCMCheckoutStrategy.checkout(SCMCheckoutStrategy.java:86)
at hudson.model.AbstractBuild$AbstractBuildExecution.run(AbstractBuild.java:499)
at hudson.model.Run.execute(Run.java:1856)
at hudson.model.FreeStyleBuild.run(FreeStyleBuild.java:43)
at hudson.model.ResourceController.execute(ResourceController.java:97)
at hudson.model.Executor.run(Executor.java:428)
ERROR: Build step failed with exception

After upgrading fom ver 2.211 to ver 2.221 jobs with a drive as custom workspace throw
a NullPointerException immediately:

{code:none}
Running as SYSTEM
[EnvInject] - Loading node environment variables.
Baue auf Master in Arbeitsbereich F:\
FATAL: null
java.lang.NullPointerException
at hudson.FilePath.sibling(FilePath.java:1327)
at hudson.slaves.WorkspaceList.tempDir(WorkspaceList.java:306)
at hudson.model.AbstractBuild.getEnvironment(AbstractBuild.java:868)
at hudson.scm.SubversionSCM.checkout(SubversionSCM.java:852)
at hudson.scm.SCM.checkout(SCM.java:505)
at hudson.model.AbstractProject.checkout(AbstractProject.java:1206)
at hudson.model.AbstractBuild$AbstractBuildExecution.defaultCheckout(AbstractBuild.java:574)
at jenkins.scm.SCMCheckoutStrategy.checkout(SCMCheckoutStrategy.java:86)
at hudson.model.AbstractBuild$AbstractBuildExecution.run(AbstractBuild.java:499)
at hudson.model.Run.execute(Run.java:1856)
at hudson.model.FreeStyleBuild.run(FreeStyleBuild.java:43)
at hudson.model.ResourceController.execute(ResourceController.java:97)
at hudson.model.Executor.run(Executor.java:428)
ERROR: Build step failed with exception
{code}

Jesse Glick made changes - 2020-02-25 13:28

Description

After upgrading fom ver 2.211 to ver 2.221 jobs with a drive as custom workspace throw a {{NullPointerException}} immediately:

{code:none}
Running as SYSTEM
[EnvInject] - Loading node environment variables.
Baue auf Master in Arbeitsbereich F:\
FATAL: null
java.lang.NullPointerException
at hudson.FilePath.sibling(FilePath.java:1327)
at hudson.slaves.WorkspaceList.tempDir(WorkspaceList.java:306)
at hudson.model.AbstractBuild.getEnvironment(AbstractBuild.java:868)
at hudson.scm.SubversionSCM.checkout(SubversionSCM.java:852)
at hudson.scm.SCM.checkout(SCM.java:505)
at hudson.model.AbstractProject.checkout(AbstractProject.java:1206)
at hudson.model.AbstractBuild$AbstractBuildExecution.defaultCheckout(AbstractBuild.java:574)
at jenkins.scm.SCMCheckoutStrategy.checkout(SCMCheckoutStrategy.java:86)
at hudson.model.AbstractBuild$AbstractBuildExecution.run(AbstractBuild.java:499)
at hudson.model.Run.execute(Run.java:1856)
at hudson.model.FreeStyleBuild.run(FreeStyleBuild.java:43)
at hudson.model.ResourceController.execute(ResourceController.java:97)
at hudson.model.Executor.run(Executor.java:428)
ERROR: Build step failed with exception
{code}

Jesse Glick added a comment - 2020-02-25 13:33

FilePath.sibling is broken for root directories. Should probably just read something like

FilePath parent = getParent();
return parent != null ? parent.child(rel) : child(rel);

Note that this setup probably caused errors in some circumstances even before ~~JENKINS-60634~~, for example if you tried to use the Credentials Binding plugin with a secret file, but the recent change would have made it happen consistently.

Jesse Glick added a comment - 2020-02-25 13:33 FilePath.sibling is broken for root directories. Should probably just read something like FilePath parent = getParent(); return parent != null ? parent.child(rel) : child(rel); Note that this setup probably caused errors in some circumstances even before JENKINS-60634 , for example if you tried to use the Credentials Binding plugin with a secret file, but the recent change would have made it happen consistently.

Oleg Nenashev added a comment - 2020-02-25 13:47

https://github.com/jenkinsci/jenkins/pull/4526 - my draft. It is a bit different from what Jesse suggested

Oleg Nenashev added a comment - 2020-02-25 13:47 https://github.com/jenkinsci/jenkins/pull/4526 - my draft. It is a bit different from what Jesse suggested

Oleg Nenashev made changes - 2020-02-25 13:47

Status

In Progress [ 3 ]

In Review [ 10005 ]

Jesse Glick made changes - 2020-02-25 14:17

Remote Link

This issue links to "workflow-durable-task-step #129 (Web Link)" [ 24523 ]

Jesse Glick added a comment - 2020-02-25 14:28

I filed a variant patch, plus a plugin one.

Jesse Glick added a comment - 2020-02-25 14:28 I filed a variant patch, plus a plugin one.

Jesse Glick made changes - 2020-02-25 14:28

Remote Link

This issue links to "jenkins #4527 (Web Link)" [ 24524 ]

Jesse Glick made changes - 2020-02-25 14:28

Labels

regression windows

lts-candidate regression

Oleg Nenashev made changes - 2020-02-26 13:38

Component/s

workflow-durable-task-step-plugin [ 21715 ]

Jesse Glick made changes - 2020-03-02 21:26

Assignee

Oleg Nenashev [ oleg_nenashev ]

Jesse Glick [ jglick ]

Jesse Glick made changes - 2020-03-02 21:26

Released As		2.223
Resolution		Fixed [ 1 ]
Status	In Review [ 10005 ]	Resolved [ 5 ]

Oliver Gondža made changes - 2020-03-11 10:28

Labels

lts-candidate regression

2.222.1-fixed regression

Oliver Gondža made changes - 2020-06-01 08:33

Labels

2.222.1-fixed regression

2.222.1-rejected regression

Oliver Gondža added a comment - 2020-06-01 08:34

Contrary to what the labels have indicated, this was not fixed in 2.222.1 nor in any other release of that LTS line.

Oliver Gondža added a comment - 2020-06-01 08:34 Contrary to what the labels have indicated, this was not fixed in 2.222.1 nor in any other release of that LTS line.

People

Assignee:: Jesse Glick

Reporter:: Frank Schlottmann-Gödde

Votes:: 0 Vote for this issue

Watchers:: 4 Start watching this issue

Dates

Created:: 2020-02-24 12:05

Updated:: 2020-06-01 08:34

Resolved:: 2020-03-02 21:26