Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-61428

Control chars in Git commit messages cause invalid JSON from REST API

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Unresolved
    • Icon: Major Major
    • core
    • Jenkins version: 2.199
      Git plugin version: 3.12.1
      OS version: CentOS 7 (3.10.0-1062.1.2.el7.x86_64)
      Java version: 1.8.0_121
      no Tomcat, no reverse proxy

      Jenkins generates invalid JSON on http://.../api/json url due to Git commit messages are included in changeset comment attribute as is (the control chars like \x00-\x1F are not filtered).

      The excerpt of JSON structure is attached.

        1. invalid.json
          0.6 kB

          [JENKINS-61428] Control chars in Git commit messages cause invalid JSON from REST API

          Evgeny Boloboshkin created issue -
          Evgeny Boloboshkin made changes -
          Attachment New: invalid.json [ 50643 ]
          Mark Waite made changes -
          Assignee Original: Mark Waite [ markewaite ]
          Mark Waite made changes -
          Component/s New: core [ 15593 ]
          Component/s Original: git-plugin [ 15543 ]
          Mark Waite made changes -
          Summary Original: Control chars in Git commit messages cause invalid JSON New: Control chars in Git commit messages cause invalid JSON from REST API
          Oleg Nenashev made changes -
          Labels New: json serialization stapler

            Unassigned Unassigned
            covid19 Evgeny Boloboshkin
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

              Created:
              Updated: