Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-61465

Make Functions#checkAnyPermission work on objects that aren't AccessControlled

    XMLWordPrintable

Details

    • 2.226

    Description

      Functions#checkAnyPermission doesn't have an overload for an Object first arg (rather than AccessControlled.

      As explained in https://github.com/jenkinsci/jenkins/blob/a79101ce5440f2cff160dde791e923ce2548cfbe/core/src/main/java/hudson/Functions.java#L838-L842 this is a problem:

      Multiple-permission checks won't work on views belonging to objects that aren't AccessControlled. Even more annoying given that all use cases for this feature at the moment would check on app / the Jenkins singleton anyway.

      Attachments

        Issue Links

          Activity

            danielbeck Daniel Beck created issue -
            danielbeck Daniel Beck made changes -
            Field Original Value New Value
            Assignee Daniel Beck [ danielbeck ]
            danielbeck Daniel Beck made changes -
            Status Open [ 1 ] In Progress [ 3 ]
            danielbeck Daniel Beck made changes -
            Status In Progress [ 3 ] In Review [ 10005 ]
            danielbeck Daniel Beck made changes -
            Remote Link This issue links to "PR 4573 (Web Link)" [ 24733 ]
            danielbeck Daniel Beck made changes -
            Issue Type Bug [ 1 ] Improvement [ 4 ]
            danielbeck Daniel Beck made changes -
            Summary Functions#checkAnyPermission only works on AccessControlled Make Functions#checkAnyPermission work on objects that aren't AccessControlled
            danielbeck Daniel Beck made changes -
            Released As 2.226
            Resolution Fixed [ 1 ]
            Status In Review [ 10005 ] Resolved [ 5 ]
            olivergondza Oliver Gondža made changes -
            Labels lts-candidate 2.222.2-fixed

            People

              danielbeck Daniel Beck
              danielbeck Daniel Beck
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: