Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-63232

Build Time Trend Page fails to Display Build Time History

    • Jenkins 2.251

      The Build Time Trend doesn't show build times of Jobs any more:
      https://ci.jenkins.io/job/Core/job/jenkins/job/master/buildTimeTrend
      Used to work with Jenkins 2.222.1

          [JENKINS-63232] Build Time Trend Page fails to Display Build Time History

          Oleg Nenashev added a comment -

          maial do you confirm it for your instance or for ci.jenkins.io?

          Oleg Nenashev added a comment - maial do you confirm it for your instance or for ci.jenkins.io?

          Teemu Kokko added a comment -

          This happens also with my instance which is 2.235.3 

          Teemu Kokko added a comment - This happens also with my instance which is 2.235.3 

          Alexander Mai added a comment -

          oleg_nenashev Sorry, it's my local instance.

          Alexander Mai added a comment - oleg_nenashev Sorry, it's my local instance.

          Daniel Beck added a comment -

          Daniel Beck added a comment - This is almost certainly a regression from SECURITY-1868. We changed https://github.com/jenkinsci/jenkins/blob/20fb581ff951e0259b7d6f34f0699ef36fb47706/core/src/main/resources/hudson/model/Job/buildTimeTrend_resources.js#L23 There's probably a path through https://github.com/jenkinsci/jenkins/blob/f0c5108184a75e589493afe6d54879b5c4b7ed54/core/src/main/java/jenkins/widgets/BuildTimeTrend.java that behaves unexpectedly. CC wfollonier  

          If you don't pass through https://github.com/jenkinsci/jenkins/blob/f0c5108184a75e589493afe6d54879b5c4b7ed54/core/src/main/java/jenkins/widgets/BuildTimeTrend.java#L48, you will not get any value for builtOnStr, and thus generating the error. I will propose a fix.

          Wadeck Follonier added a comment - If you don't pass through https://github.com/jenkinsci/jenkins/blob/f0c5108184a75e589493afe6d54879b5c4b7ed54/core/src/main/java/jenkins/widgets/BuildTimeTrend.java#L48 , you will not get any value for builtOnStr, and thus generating the error. I will propose a fix.

          I confirmed it came from the security correction we applied. Our test coverage was not enough to catch this situation.

          Wadeck Follonier added a comment - I confirmed it came from the security correction we applied. Our test coverage was not enough to catch this situation.

          Any updates on this? We are having the above regression issue as well.

           

          https://github.com/jenkinsci/jenkins/commit/b321a74528f94ae7dee2afa1cc8c401c33ae5be5 looks promising but has not had any movement since August 3, as far as I can see.

          Robin Verduijn added a comment - Any updates on this? We are having the above regression issue as well.   https://github.com/jenkinsci/jenkins/commit/b321a74528f94ae7dee2afa1cc8c401c33ae5be5  looks promising but has not had any movement since August 3, as far as I can see.

          rverduijn The problem was confirmed on August 3, corrected with the linked PR and then merged/released as Jenkins 2.251 and 2.249.1. This ticket is now closed as fixed.

          If you are still encountering the problem with the more recent version, please either open a new ticket or re-open this one

          Wadeck Follonier added a comment - rverduijn The problem was confirmed on August 3, corrected with the linked PR and then merged/released as Jenkins 2.251 and 2.249.1. This ticket is now closed as fixed. If you are still encountering the problem with the more recent version, please either open a new ticket or re-open this one

          We're currently testing out 2.249.1 and the updated plugins, and things look good. Thanks

          Robin Verduijn added a comment - We're currently testing out 2.249.1 and the updated plugins, and things look good. Thanks

          Just wanted to point at that we saw the same issue happen in an environment running Jenkins 2.190.x, although there was not explicit escapeHTML where it failed in that version: https://github.com/jenkinsci/jenkins/blob/stable-2.190/core/src/main/resources/hudson/model/Job/buildTimeTrend.jelly#L58.

          In any case upgrading to 2.249.1 fixed this.

          Allan BURDAJEWICZ added a comment - Just wanted to point at that we saw the same issue happen in an environment running Jenkins 2.190.x, although there was not explicit escapeHTML where it failed in that version: https://github.com/jenkinsci/jenkins/blob/stable-2.190/core/src/main/resources/hudson/model/Job/buildTimeTrend.jelly#L58 . In any case upgrading to 2.249.1 fixed this.

            wfollonier Wadeck Follonier
            cobexer Ing. Christoph Obexer
            Votes:
            3 Vote for this issue
            Watchers:
            10 Start watching this issue

              Created:
              Updated:
              Resolved: