Patch looks ok. I was planning to use apache commons httpclient, so thanks for including it in the patch. The string check also works fine.
The only problem I found during testing was:
- created a new job
- configured, added one URL for SiteMonitor
- saved the job
- ran the job
- found 2 additional sites with empty URLs in the Site Monitor report page
- found additional results for those 2 additional sites in the console output
java.lang.IllegalArgumentException: host parameter is null - host parameter is null
URL: , response code: null, status: EXCEPTION
java.lang.IllegalArgumentException: host parameter is null - host parameter is null
URL: , response code: null, status: EXCEPTION
- went back to the job configuration page and found 2 additional sites with empty URL
I also tested this by creating a new job, configure and add a URL to monitor, save configuration, then returned to configuration page, it already had 2 extra sites with empty URLs.
I found this problem on both freestyle and Maven jobs, by running directly using mvn hpi:run, and also by installing the hpi file on my Hudson instance.
Any idea what could possibly add those 2 extra sites?
Patch looks ok. I was planning to use apache commons httpclient, so thanks for including it in the patch. The string check also works fine.
The only problem I found during testing was:
java.lang.IllegalArgumentException: host parameter is null - host parameter is null
URL: , response code: null, status: EXCEPTION
java.lang.IllegalArgumentException: host parameter is null - host parameter is null
URL: , response code: null, status: EXCEPTION
I also tested this by creating a new job, configure and add a URL to monitor, save configuration, then returned to configuration page, it already had 2 extra sites with empty URLs.
I found this problem on both freestyle and Maven jobs, by running directly using mvn hpi:run, and also by installing the hpi file on my Hudson instance.
Any idea what could possibly add those 2 extra sites?