Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-63682

The PluginServletFilter class should be final

    XMLWordPrintable

    Details

    • Type: Task
    • Status: Closed (View Workflow)
    • Priority: Minor
    • Resolution: Fixed
    • Component/s: core
    • Labels:
    • Similar Issues:
    • Released As:
      2.258

      Description

      Currently the PluginServletFilter class is not final, which allows faulty implementations like https://github.com/jenkinsci/audit-log-plugin/blob/a8206637889be84a966711ab69f76dc4a74ba5d5/src/main/java/io/jenkins/plugins/audit/filter/RequestContextFilter.java where a plugin can contribute a filter that will replace itself as the PluginServletFilter (which should really be a singleton) and prevent other filters from receiving requests.

       

      Change is breaking.

        Attachments

          Issue Links

            Activity

            There are no comments yet on this issue.

              People

              Assignee:
              pierrebtz Pierre Beitz
              Reporter:
              pierrebtz Pierre Beitz
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved: