Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-64040

Radio block content not hidden due to JENKINS-63332

    XMLWordPrintable

Details

    Description

      https://github.com/jenkinsci/jenkins/pull/4936 has caused a regression in a non-public plugin. The issue is that radio block content will not be hidden when using tabular markup within the radio block and will be over other content of the page.

      Attachments

        Issue Links

          causes

          Bug - A problem which impairs or prevents the functions of the product. JENKINS-64136 Add repository and add branch buttons hovering on page

          • Major - Major loss of function.
          • Closed
          is caused by

          Bug - A problem which impairs or prevents the functions of the product. JENKINS-63332 Radio button's move around when clicking them

          • Minor - Minor loss of function, or other problem where easy workaround is present.
          • Closed
          is duplicated by

          Bug - A problem which impairs or prevents the functions of the product. JENKINS-64421 Plugin config disappearing from job config UI

          • Minor - Minor loss of function, or other problem where easy workaround is present.
          • Closed
          links to

          Web Link jenkins#5046

          Activity

            Ascending order - Click to sort in descending order
            fqueiruga Félix Queiruga Balado created issue -
            fqueiruga Félix Queiruga Balado made changes -
            Field Original Value New Value
            Attachment screenshot-localhost_8080-2020.10.26-18_03_22.png [ 53064 ]
            fqueiruga Félix Queiruga Balado made changes -
            Description [https://github.com/jenkinsci/jenkins/pull/4936] has caused a regression in a non-public plugin. The issue is that radio block content will not be hidden when using tabular markup within the radio block and will be over other content of the page.

            _Screenshots coming soon._             		[https://github.com/jenkinsci/jenkins/pull/4936] has caused a regression in a non-public plugin. The issue is that radio block content will not be hidden when using tabular markup within the radio block and will be over other content of the page.

            !screenshot-localhost_8080-2020.10.26-18_03_22.png|width=499,height=130,thumbnail!
            oleg_nenashev Oleg Nenashev made changes -
            Labels regression
            jglick Jesse Glick made changes -
            Link This issue is caused by JENKINS-63332 [ JENKINS-63332 ]
            jglick Jesse Glick added a comment -

            It is unclear from the description where the fault lies in this case. The form in question has several consecutive entries of the form

              <f:entry title="…" field="…">
    <f:hetero-radio descriptors="…"/>
  </f:entry>

            None of the nested describables include any weird markup that I can see, just regular databinding. There is a routine tables-to-divs violation earlier in this same form

                <table style="width:100%">
      <f:descriptorList descriptors="…"/>
    </table>

            I do not see any reason to believe that other plugins, including OSS ones, might not be broken for the same reason.

            So should JENKINS-63332 be reverted? And in this case, should this issue be an lts-candidate, so that potentially 2.249.4 would go back to the original behavior still in 2.249.2; or that 2.249.3 be recut without JENKINS-63332?

            CC markewaite

            jglick Jesse Glick added a comment - It is unclear from the description where the fault lies in this case. The form in question has several consecutive entries of the form <f:entry title= "…" field= "…" > <f:hetero-radio descriptors= "…" /> </f:entry> None of the nested describables include any weird markup that I can see, just regular databinding. There is a routine tables-to-divs violation earlier in this same form <table style= "width:100%" > <f:descriptorList descriptors= "…" /> </table> I do not see any reason to believe that other plugins, including OSS ones, might not be broken for the same reason. So should JENKINS-63332 be reverted? And in this case, should this issue be an lts-candidate , so that potentially 2.249.4 would go back to the original behavior still in 2.249.2; or that 2.249.3 be recut without JENKINS-63332 ? CC markewaite
            fqueiruga Félix Queiruga Balado added a comment -

            If the culprit is the tabular markup then it's compatibility should not be broken in 2.249.X releases IMO.

            fqueiruga Félix Queiruga Balado added a comment - If the culprit is the tabular markup then it's compatibility should not be broken in 2.249.X releases IMO.
            timja Tim Jacomb made changes -
            Component/s git-plugin [ 15543 ]
            timja Tim Jacomb made changes -
            Link This issue causes JENKINS-64136 [ JENKINS-64136 ]
            timja Tim Jacomb added a comment - - edited

            Git plugin is affected by this as well https://issues.jenkins-ci.org/browse/JENKINS-64136

            It looks bad after 2.258 and gets worse after tables to divs.

            I reverted the core commit and git plugin was fixed.

            Either we should revert this or find a better fix

            git revert bbc3580d4c5fe3766dc4a530902f8ea4e20c87a3
            timja Tim Jacomb added a comment - - edited Git plugin is affected by this as well https://issues.jenkins-ci.org/browse/JENKINS-64136 It looks bad after 2.258 and gets worse after tables to divs. I reverted the core commit and git plugin was fixed. Either we should revert this or find a better fix git revert bbc3580d4c5fe3766dc4a530902f8ea4e20c87a3
            fqueiruga Félix Queiruga Balado added a comment -

            I vote for revert. Is the time to revert it on the 2.263 LTS? 

            fqueiruga Félix Queiruga Balado added a comment - I vote for revert. Is the time to revert it on the 2.263 LTS? 
            timja Tim Jacomb added a comment -

            I've tested a fix here: https://github.com/jenkinsci/jenkins/pull/5046

            no it's not too late

            timja Tim Jacomb added a comment - I've tested a fix here: https://github.com/jenkinsci/jenkins/pull/5046 no it's not too late
            timja Tim Jacomb made changes -
            Labels regression lts-candidate regression
            timja Tim Jacomb made changes -
            Status Open [ 1 ] In Progress [ 3 ]
            timja Tim Jacomb made changes -
            Assignee Tim Jacomb [ timja ]
            timja Tim Jacomb made changes -
            Status In Progress [ 3 ] In Review [ 10005 ]
            timja Tim Jacomb made changes -
            Remote Link This issue links to "jenkins#5046 (Web Link)" [ 26213 ]
            fqueiruga Félix Queiruga Balado added a comment -

            Oh . I have commented on your PR.

             

            fqueiruga Félix Queiruga Balado added a comment - Oh . I have commented on your PR.  
            timja Tim Jacomb made changes -
            Resolution Fixed [ 1 ]
            Status In Review [ 10005 ] Resolved [ 5 ]
            markewaite Mark Waite added a comment -

            Released Nov 10, 2020 in Jenkins 2.266

            markewaite Mark Waite added a comment - Released Nov 10, 2020 in Jenkins 2.266
            markewaite Mark Waite made changes -
            Status Resolved [ 5 ] Closed [ 6 ]
            olivergondza Oliver Gondža made changes -
            Labels lts-candidate regression 2.263.1-fixed regression
            markewaite Mark Waite made changes -
            Link This issue is duplicated by JENKINS-64421 [ JENKINS-64421 ]

            People

              timja Tim Jacomb
              fqueiruga Félix Queiruga Balado
              Votes:
              0 Vote for this issue
              Watchers:
              6 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: