Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-64040

Radio block content not hidden due to JENKINS-63332

    XMLWordPrintable

    Details

    • Similar Issues:

      Description

      https://github.com/jenkinsci/jenkins/pull/4936 has caused a regression in a non-public plugin. The issue is that radio block content will not be hidden when using tabular markup within the radio block and will be over other content of the page.

        Attachments

          Issue Links

            Activity

            Hide
            jglick Jesse Glick added a comment -

            It is unclear from the description where the fault lies in this case. The form in question has several consecutive entries of the form

              <f:entry title="…" field="…">
                <f:hetero-radio descriptors="…"/>
              </f:entry>
            

            None of the nested describables include any weird markup that I can see, just regular databinding. There is a routine tables-to-divs violation earlier in this same form

                <table style="width:100%">
                  <f:descriptorList descriptors="…"/>
                </table>
            

            I do not see any reason to believe that other plugins, including OSS ones, might not be broken for the same reason.

            So should JENKINS-63332 be reverted? And in this case, should this issue be an lts-candidate, so that potentially 2.249.4 would go back to the original behavior still in 2.249.2; or that 2.249.3 be recut without JENKINS-63332?

            CC Mark Waite

            Show
            jglick Jesse Glick added a comment - It is unclear from the description where the fault lies in this case. The form in question has several consecutive entries of the form <f:entry title= "…" field= "…" > <f:hetero-radio descriptors= "…" /> </f:entry> None of the nested describables include any weird markup that I can see, just regular databinding. There is a routine tables-to-divs violation earlier in this same form <table style= "width:100%" > <f:descriptorList descriptors= "…" /> </table> I do not see any reason to believe that other plugins, including OSS ones, might not be broken for the same reason. So should JENKINS-63332 be reverted? And in this case, should this issue be an lts-candidate , so that potentially 2.249.4 would go back to the original behavior still in 2.249.2; or that 2.249.3 be recut without JENKINS-63332 ? CC Mark Waite
            Hide
            fqueiruga Félix Queiruga Balado added a comment -

            If the culprit is the tabular markup then it's compatibility should not be broken in 2.249.X releases IMO.

            Show
            fqueiruga Félix Queiruga Balado added a comment - If the culprit is the tabular markup then it's compatibility should not be broken in 2.249.X releases IMO.
            Hide
            timja Tim Jacomb added a comment - - edited

            Git plugin is affected by this as well https://issues.jenkins-ci.org/browse/JENKINS-64136

            It looks bad after 2.258 and gets worse after tables to divs.

            I reverted the core commit and git plugin was fixed.

            Either we should revert this or find a better fix

            git revert bbc3580d4c5fe3766dc4a530902f8ea4e20c87a3
            
            Show
            timja Tim Jacomb added a comment - - edited Git plugin is affected by this as well https://issues.jenkins-ci.org/browse/JENKINS-64136 It looks bad after 2.258 and gets worse after tables to divs. I reverted the core commit and git plugin was fixed. Either we should revert this or find a better fix git revert bbc3580d4c5fe3766dc4a530902f8ea4e20c87a3
            Hide
            fqueiruga Félix Queiruga Balado added a comment -

            I vote for revert. Is the time to revert it on the 2.263 LTS? 

            Show
            fqueiruga Félix Queiruga Balado added a comment - I vote for revert. Is the time to revert it on the 2.263 LTS? 
            Hide
            timja Tim Jacomb added a comment -

            I've tested a fix here: https://github.com/jenkinsci/jenkins/pull/5046

            no it's not too late

            Show
            timja Tim Jacomb added a comment - I've tested a fix here: https://github.com/jenkinsci/jenkins/pull/5046 no it's not too late
            Hide
            fqueiruga Félix Queiruga Balado added a comment -

            Oh . I have commented on your PR.

             

            Show
            fqueiruga Félix Queiruga Balado added a comment - Oh . I have commented on your PR.  
            Hide
            markewaite Mark Waite added a comment -

            Released Nov 10, 2020 in Jenkins 2.266

            Show
            markewaite Mark Waite added a comment - Released Nov 10, 2020 in Jenkins 2.266

              People

              Assignee:
              timja Tim Jacomb
              Reporter:
              fqueiruga Félix Queiruga Balado
              Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved: