Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-64376

Issue filter in data table misses TODO content

    XMLWordPrintable

    Details

    • Similar Issues:

      Description

      Hi,

      When trying to narrow issues found with the Open Tasks Scanner analysis tool in the warnings next generation plugin, it not searching the field that can be seen when opening the issue with the  icon. 

      Previously the Tasks Scanner plugin used to be able to provide a full textual list of the TODO entries, so at least the browsers search functionality was usable to find patterns like ticket ids to see associated tasks remaining with a ticket.

      With the everything tucked nicely into a data table and pagination that possibility is gone.

      Would it be possible to adjust the search box to also search the textual content of the TODO?

        Attachments

          Activity

          atzimler Attila Tamas Zimler created issue -
          drulli Ulli Hafner made changes -
          Field Original Value New Value
          Issue Type Bug [ 1 ] Improvement [ 4 ]
          drulli Ulli Hafner made changes -
          Labels help-wanted
          Hide
          drulli Ulli Hafner added a comment - - edited

          I'm not sure if that is possible in a simple way with https://datatables.net. (I'm also not sure if this will be an unwanted feature for other parser results that have longer descriptions)

          Show
          drulli Ulli Hafner added a comment - - edited I'm not sure if that is possible in a simple way with https://datatables.net . (I'm also not sure if this will be an unwanted feature for other parser results that have longer descriptions)
          drulli Ulli Hafner made changes -
          Assignee Ulli Hafner [ drulli ]
          drulli Ulli Hafner made changes -
          Summary Issue search misses TODO content Issue filter in data table misses TODO content
          kasperhey Kasper Heyndrickx made changes -
          Assignee Kasper Heyndrickx [ kasperhey ]
          Hide
          kasperhey Kasper Heyndrickx added a comment -

          Hey Ulli Hafner,
          I have a basic fix locally but it requires changes in both the data-tables-api-plugin and warnings-ng-plugin. The basic idea is to add a 'hidden but searchable' column type in the data-tables-api-plugin and use it in the warnings-ng-plugin.

          I'm not sure how to go about making a pull request for this?

          Show
          kasperhey Kasper Heyndrickx added a comment - Hey Ulli Hafner , I have a basic fix locally but it requires changes in both the data-tables-api-plugin and warnings-ng-plugin. The basic idea is to add a 'hidden but searchable' column type in the data-tables-api-plugin and use it in the warnings-ng-plugin. I'm not sure how to go about making a pull request for this?
          Hide
          drulli Ulli Hafner added a comment - - edited

          You need to create a PR in the DataTables plugin first. Then use the incremental version (it is available as a link in the checks only if all checks are ok) in the PR of the warnings plugin.

          Example:

          Show
          drulli Ulli Hafner added a comment - - edited You need to create a PR in the DataTables plugin first. Then use the incremental version (it is available as a link in the checks only if all checks are ok) in the PR of the warnings plugin. Example: https://github.com/jenkinsci/data-tables-api-plugin/pull/144 https://github.com/jenkinsci/warnings-ng-plugin/pull/760
          Hide
          drulli Ulli Hafner added a comment -

          BTW: Since we already using the https://datatables.net/reference/option/columns.data API it might help to add a filter property for specific static analysis tools?

          Show
          drulli Ulli Hafner added a comment - BTW: Since we already using the https://datatables.net/reference/option/columns.data API it might help to add a filter property for specific static analysis tools?
          Hide
          kasperhey Kasper Heyndrickx added a comment - - edited

          Do you mean change the data to a function like this example?
          That could work too, might require some bigger changes though. An almost identical problem was discussed here , where they also opt for hidden columns.

          It's the first time I use datatables, so I'm not able to judge what is a "better" solution.

          Show
          kasperhey Kasper Heyndrickx added a comment - - edited Do you mean change the data to a function like this example ? That could work too, might require some bigger changes though. An almost identical problem was discussed here , where they also opt for hidden columns. It's the first time I use datatables, so I'm not able to judge what is a "better" solution.
          drulli Ulli Hafner made changes -
          Remote Link This issue links to "PR data-tables-api-plugin/pull/146 (Web Link)" [ 26481 ]
          drulli Ulli Hafner made changes -
          Remote Link This issue links to "PR warnings-ng-plugin/pull/765 (Web Link)" [ 26482 ]
          drulli Ulli Hafner made changes -
          Resolution Fixed [ 1 ]
          Status Open [ 1 ] Fixed but Unreleased [ 10203 ]
          drulli Ulli Hafner made changes -
          Released As https://github.com/jenkinsci/warnings-ng-plugin/releases/tag/v8.9.0
          Status Fixed but Unreleased [ 10203 ] Resolved [ 5 ]

            People

            Assignee:
            kasperhey Kasper Heyndrickx
            Reporter:
            atzimler Attila Tamas Zimler
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved: