Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-64439

"positive-number" field validator accepts non valid java numbers

    • Icon: Improvement Improvement
    • Resolution: Fixed
    • Icon: Minor Minor
    • core
    • None
    • Jenkins 2.274 - released 5 Jan 2021 and 2.277.1

      if you have a field that is using `<f:number clazz="positive-number" min="1" step="1" />` you can submit a garbage number as far as java is concerned without any formvalidation warning.

      this is because javascript validation treats `e` as the matmatical constant e (2.7182......)

      so you can enter `e` `3e` or lots of this.

      however Jenkins will then parse this usign standard java terms and well - `e` is not valid here, so you get a number format exception.

      For example create a job and select "Discard old builds" and enter "e" as the "days to keep builds.
      observe there are no formvalidation errors and save the form
      reconfigure the job and not that the value is missing.

          [JENKINS-64439] "positive-number" field validator accepts non valid java numbers

          James Nord created issue -
          Benny Cheng made changes -
          Assignee New: Benny Cheng [ benebsiny ]
          Oleg Nenashev made changes -
          Status Original: Open [ 1 ] New: In Progress [ 3 ]
          Oleg Nenashev made changes -
          Status Original: In Progress [ 3 ] New: In Review [ 10005 ]
          Mark Waite made changes -
          Released As New: Jenkins 2.274 - released 5 Jan 2021
          Resolution New: Fixed [ 1 ]
          Status Original: In Review [ 10005 ] New: Closed [ 6 ]
          Oleg Nenashev made changes -
          Link New: This issue relates to JENKINS-64651 [ JENKINS-64651 ]
          Mark Waite made changes -
          Released As Original: Jenkins 2.274 - released 5 Jan 2021 New: Jenkins 2.274 - released 5 Jan 2021 and 2.277.1

            benebsiny Benny Cheng
            teilo James Nord
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

              Created:
              Updated:
              Resolved: