Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-64670

FileFingerprintStorage performance

    XMLWordPrintable

Details

    • 2.277, 2.263.4, and 2.277.1

    Description

      I believe that with JENKINS-62345, as there is only one point to create the fingerprint files on the disk, and that method is synchronized, we created the context to limit the number of fingerprint we can save on disk.

      This is a big performance issue when used with Maven plugin and a set of jobs with multiple modules. It creates a queue of fingerprint objects, waiting for the lock on the FileFingerprintStorage.

      Attachments

        Activity

          alecharp Adrien Lecharpentier created issue -
          alecharp Adrien Lecharpentier made changes -
          Field Original Value New Value
          Status Open [ 1 ] In Progress [ 3 ]
          alecharp Adrien Lecharpentier made changes -
          Status In Progress [ 3 ] In Review [ 10005 ]
          alecharp Adrien Lecharpentier made changes -
          Assignee Adrien Lecharpentier [ alecharp ]

          alecharp are you aware of any stack trace in thread dumps showing this slowness' hypothesis? Merci  !

          batmat Baptiste Mathus added a comment - alecharp  are you aware of any stack trace in thread dumps showing this slowness' hypothesis? Merci  !
          allan_burdajewicz Allan BURDAJEWICZ added a comment - - edited

          One thread holds a lock on the FileFingerprintStorage

          	at jenkins.fingerprints.FileFingerprintStorage.save(FileFingerprintStorage.java:126)
          	- locked <0x00007f9b65846a98> (a jenkins.fingerprints.FileFingerprintStorage)
          

          Many others are BLOCKED waiting for the resource:

          	at jenkins.fingerprints.FileFingerprintStorage.save(FileFingerprintStorage.java:125)
          	- waiting to lock <0x00007f9b65846a98> (a jenkins.fingerprints.FileFingerprintStorage)
          
          allan_burdajewicz Allan BURDAJEWICZ added a comment - - edited One thread holds a lock on the FileFingerprintStorage at jenkins.fingerprints.FileFingerprintStorage.save(FileFingerprintStorage.java:126) - locked <0x00007f9b65846a98> (a jenkins.fingerprints.FileFingerprintStorage) Many others are BLOCKED waiting for the resource: at jenkins.fingerprints.FileFingerprintStorage.save(FileFingerprintStorage.java:125) - waiting to lock <0x00007f9b65846a98> (a jenkins.fingerprints.FileFingerprintStorage)
          alecharp Adrien Lecharpentier made changes -
          Labels lts
          alecharp Adrien Lecharpentier made changes -
          Labels lts lts-candidate
          markewaite Mark Waite made changes -
          Released As 2.277
          Resolution Fixed [ 1 ]
          Status In Review [ 10005 ] Resolved [ 5 ]
          markewaite Mark Waite made changes -
          Status Resolved [ 5 ] Closed [ 6 ]
          markewaite Mark Waite made changes -
          Labels lts-candidate 2.263.4-fixed lts-candidate
          markewaite Mark Waite made changes -
          Released As 2.277 2.277, 2.263.4
          timja Tim Jacomb made changes -
          Labels 2.263.4-fixed lts-candidate 2.263.4-fixed
          markewaite Mark Waite made changes -
          Released As 2.277, 2.263.4 2.277, 2.263.4, and 2.277.1

          People

            alecharp Adrien Lecharpentier
            alecharp Adrien Lecharpentier
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: