Details
-
Bug
-
Status: Reopened (View Workflow)
-
Major
-
Resolution: Unresolved
-
2.277.1
mesos cloud 0.18.1
Description
Mesos cloud labels can contain the char ":" in order to specify custom docker images (which also contain the char ":" for the docker image tag separator)
Was working on LTS 2.263.1 but not 2.277.1, hitting a SEVERE error with stack trace:
2021-03-18 16:02:45.512+0000 [id=66] SEVERE hudson.slaves.NodeProvisioner#lambda$update$6: Unexpected uncaught exception encountered while processing agent MesosCloud hudson.model.Failure: ‘:’ is an unsafe character at jenkins.model.Jenkins.checkGoodName(Jenkins.java:4063) at jenkins.model.Nodes.addNode(Nodes.java:139) at jenkins.model.Jenkins.addNode(Jenkins.java:2157) at hudson.slaves.NodeProvisioner.lambda$update$6(NodeProvisioner.java:256) at hudson.model.Queue._withLock(Queue.java:1384) at hudson.model.Queue.withLock(Queue.java:1261) at hudson.slaves.NodeProvisioner.update(NodeProvisioner.java:225) at hudson.slaves.NodeProvisioner.access$900(NodeProvisioner.java:64) at hudson.slaves.NodeProvisioner$NodeProvisionerInvoker.doRun(NodeProvisioner.java:823) at hudson.triggers.SafeTimerTask.run(SafeTimerTask.java:91) at jenkins.security.ImpersonatingScheduledExecutorService$1.run(ImpersonatingScheduledExecutorService.java:67) at java.base/java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:515) at java.base/java.util.concurrent.FutureTask.runAndReset(FutureTask.java:305) at java.base/java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:305) at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128) at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628) at java.base/java.lang.Thread.run(Thread.java:834)
example label that is used in the mesos config, and the agent fails to start:
worker:REDACTEDREPO/qe/jira-dependency-graph:1
Attachments
Issue Links
Activity
Field | Original Value | New Value |
---|---|---|
Priority | Critical [ 2 ] | Major [ 3 ] |
Labels | SECURITY-2021 |
Link | This issue is caused by SECURITY-2021 [ SECURITY-2021 ] |
Status | Open [ 1 ] | In Progress [ 3 ] |
Status | In Progress [ 3 ] | In Review [ 10005 ] |
Remote Link | This issue links to "PR-4196 to extend upgrade guide description of label name security hardening (Web Link)" [ 26582 ] |
Resolution | Won't Fix [ 2 ] | |
Status | In Review [ 10005 ] | Closed [ 6 ] |
Component/s | mesos-plugin [ 18122 ] | |
Component/s | core [ 15593 ] |
Summary | SEVERE error Cloud agent not starting because of checkGoodname() regression in 2.277.1 | Update Mesos Plugin to be compliant with agent naming requirements in checkGoodname() regression in 2.277.1 |
Summary | Update Mesos Plugin to be compliant with agent naming requirements in checkGoodname() regression in 2.277.1 | Update Mesos Plugin to be compliant with agent naming requirements in Jenkins 2.263.2+ |
Resolution | Won't Fix [ 2 ] | |
Status | Closed [ 6 ] | Reopened [ 4 ] |
looking at the code I'll try to set
jenkins.model.Nodes.enforceNameRestrictions=false