Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-65288

Bring back support of -Dstapler.jelly.trace=true

    • Icon: Bug Bug
    • Resolution: Fixed
    • Icon: Minor Minor
    • core
    • None
    • 2.288 - Apr 13, 2021

      Symptoms were the same as JENKINS-28561.

      When we try to use -Dstapler.jelly.trace=true, there are several things no longer working in Jenkins.

      This property will add comments explaining where the jelly fragments are coming from. This is very handy when debugging multiple plugins at once.

      1) Due to the usage of firstChild in Jenkins core, instead of firstElementChild, the comment node is returned while an element is expected. FirstChild can return Element, TextNode or CommentNode, while firstElementChild only Element.

      2) Due to the fix for SECURITY-534, the comments now force the flush of the output, meaning the check for dispatchAllowance is triggered earlier than expected and failed for ajax.jelly (layout using by all the ajax parts, like ajaxExecutors.jelly)

          [JENKINS-65288] Bring back support of -Dstapler.jelly.trace=true

          Wadeck Follonier created issue -
          Wadeck Follonier made changes -
          Status Original: Open [ 1 ] New: In Progress [ 3 ]
          Wadeck Follonier made changes -
          Status Original: In Progress [ 3 ] New: In Review [ 10005 ]
          Wadeck Follonier made changes -
          Remote Link New: This issue links to "#5391 in core (Web Link)" [ 26604 ]
          Mark Waite made changes -
          Resolution New: Fixed [ 1 ]
          Status Original: In Review [ 10005 ] New: Fixed but Unreleased [ 10203 ]
          Mark Waite made changes -
          Released As New: 2.288 - Apr 13, 2021
          Status Original: Fixed but Unreleased [ 10203 ] New: Closed [ 6 ]

            wfollonier Wadeck Follonier
            wfollonier Wadeck Follonier
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

              Created:
              Updated:
              Resolved: