Jenkins 2.263.4, Publish Over CIFS 0.16, openjdk version "1.8.0_282"
Publish Over CIFS job config mishandles publishWhenFailed in job's config.xml
If you open the job config page, set the publishWhenFailed attribute to true, and save the job config, the attribute value true is written in the job's config.xml file, as expected.
However, if you open the job config page again and look at the publishWhenFailed attribute, the value show up as false. Then if you save the job config then, the attribute value in the job config.xml file is false.
As a result, you are going to end up with a publishWhenFailed value of false, unless you remember to reset it to true every time you edit the job config for any reason.
Examining the jobs config.xml file, I notice the publishWhenFailed attribute does not look like it is in the right place.
More info follows as comments and/or attachments.