Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-65294

Publish Over CIFS job config mishandles publishWhenFailed in job's config.xml

    XMLWordPrintable

Details

    • Bug
    • Status: Closed (View Workflow)
    • Minor
    • Resolution: Incomplete
    • None
    • Jenkins 2.263.4, Publish Over CIFS 0.16, openjdk version "1.8.0_282"

    Description

      Publish Over CIFS job config mishandles publishWhenFailed in job's config.xml

      If you open the job config page, set the publishWhenFailed attribute to true, and save the job config, the attribute value true is written in the job's config.xml file, as expected. 

      However, if you open the job config page again and look at the publishWhenFailed attribute, the value show up as false.  Then if you save the job config then, the attribute value in the job config.xml file is false. 

      As a result, you are going to end up with a publishWhenFailed value of false, unless you remember to reset it to true every time you edit the job config for any reason. 

      Examining the jobs config.xml file, I notice the publishWhenFailed attribute does not look like it is in the right place. 

      More info follows as comments and/or attachments.

      Attachments

        Activity

          hushp1pt Tony Wallace created issue -
          hushp1pt Tony Wallace added a comment -

          config.xml snippet: note the location of  publishWhenFailed 

                      <jenkins.plugins.publish__over__cifs.CifsPublisherPlugin plugin="publish-over-cifs@0.16">
                        <consolePrefix>CIFS: </consolePrefix>
                        <delegate plugin="publish-over@0.22">
                          <publishers>
                            <jenkins.plugins.publish__over__cifs.CifsPublisher plugin="publish-over-cifs@0.16">
                              <configName>Eco-Jenkins</configName>
                              <verbose>false</verbose>
                              <transfers>
                                <jenkins.plugins.publish__over__cifs.CifsTransfer>
                                  <remoteDirectory>${JCI_DEVICE_CLASS_PLUS}\${UJCI_TAG}\${BUILD_TAG}</remoteDirectory>
                                  <sourceFiles>logcat-*.log, crash.log</sourceFiles>
                                  <excludes>logcat.brief*</excludes>
                                  <removePrefix/>
                                  <remoteDirectorySDF>false</remoteDirectorySDF>
                                  <flatten>false</flatten>
                                  <cleanRemote>true</cleanRemote>
                                  <noDefaultExcludes>false</noDefaultExcludes>
                                  <makeEmptyDirs>false</makeEmptyDirs>
                                  <patternSeparator>[, ]+</patternSeparator>
                                </jenkins.plugins.publish__over__cifs.CifsTransfer>
                                <jenkins.plugins.publish__over__cifs.CifsTransfer>
                                  <remoteDirectory>${JCI_DEVICE_CLASS_PLUS}\${UJCI_TAG}\${BUILD_TAG}\state</remoteDirectory>
                                  <sourceFiles>jci/state/*.*</sourceFiles>
                                  <excludes>**/.gitignore</excludes>
                                  <removePrefix/>
                                  <remoteDirectorySDF>false</remoteDirectorySDF>
                                  <flatten>true</flatten>
                                  <cleanRemote>false</cleanRemote>
                                  <noDefaultExcludes>false</noDefaultExcludes>
                                  <makeEmptyDirs>false</makeEmptyDirs>
                                  <patternSeparator>[, ]+</patternSeparator>
                                </jenkins.plugins.publish__over__cifs.CifsTransfer>
                              </transfers>
                              <useWorkspaceInPromotion>false</useWorkspaceInPromotion>
                              <usePromotionTimestamp>false</usePromotionTimestamp>
                              <retry class="jenkins.plugins.publish_over_cifs.CifsRetry">
                                <retries>2</retries>
                                <retryDelay>15000</retryDelay>
                              </retry>
                            </jenkins.plugins.publish__over__cifs.CifsPublisher>
                          </publishers>
                          <continueOnError>false</continueOnError>
                          <failOnError>false</failOnError>
                          <alwaysPublishFromMaster>true</alwaysPublishFromMaster>
                          <hostConfigurationAccess class="jenkins.plugins.publish_over_cifs.CifsPublisherPlugin" reference="../.."/>
                        </delegate>
                        <publishWhenFailed>true</publishWhenFailed>
                      </jenkins.plugins.publish__over__cifs.CifsPublisherPlugin>
          
          hushp1pt Tony Wallace added a comment - config.xml snippet: note the location of  publishWhenFailed  <jenkins.plugins.publish__over__cifs.CifsPublisherPlugin plugin="publish-over-cifs@0.16"> <consolePrefix>CIFS: </consolePrefix> <delegate plugin="publish-over@0.22"> <publishers> <jenkins.plugins.publish__over__cifs.CifsPublisher plugin="publish-over-cifs@0.16"> <configName>Eco-Jenkins</configName> <verbose>false</verbose> <transfers> <jenkins.plugins.publish__over__cifs.CifsTransfer> <remoteDirectory>${JCI_DEVICE_CLASS_PLUS}\${UJCI_TAG}\${BUILD_TAG}</remoteDirectory> <sourceFiles>logcat-*.log, crash.log</sourceFiles> <excludes>logcat.brief*</excludes> <removePrefix/> <remoteDirectorySDF>false</remoteDirectorySDF> <flatten>false</flatten> <cleanRemote>true</cleanRemote> <noDefaultExcludes>false</noDefaultExcludes> <makeEmptyDirs>false</makeEmptyDirs> <patternSeparator>[, ]+</patternSeparator> </jenkins.plugins.publish__over__cifs.CifsTransfer> <jenkins.plugins.publish__over__cifs.CifsTransfer> <remoteDirectory>${JCI_DEVICE_CLASS_PLUS}\${UJCI_TAG}\${BUILD_TAG}\state</remoteDirectory> <sourceFiles>jci/state/*.*</sourceFiles> <excludes>**/.gitignore</excludes> <removePrefix/> <remoteDirectorySDF>false</remoteDirectorySDF> <flatten>true</flatten> <cleanRemote>false</cleanRemote> <noDefaultExcludes>false</noDefaultExcludes> <makeEmptyDirs>false</makeEmptyDirs> <patternSeparator>[, ]+</patternSeparator> </jenkins.plugins.publish__over__cifs.CifsTransfer> </transfers> <useWorkspaceInPromotion>false</useWorkspaceInPromotion> <usePromotionTimestamp>false</usePromotionTimestamp> <retry class="jenkins.plugins.publish_over_cifs.CifsRetry"> <retries>2</retries> <retryDelay>15000</retryDelay> </retry> </jenkins.plugins.publish__over__cifs.CifsPublisher> </publishers> <continueOnError>false</continueOnError> <failOnError>false</failOnError> <alwaysPublishFromMaster>true</alwaysPublishFromMaster> <hostConfigurationAccess class="jenkins.plugins.publish_over_cifs.CifsPublisherPlugin" reference="../.."/> </delegate> <publishWhenFailed>true</publishWhenFailed> </jenkins.plugins.publish__over__cifs.CifsPublisherPlugin>
          hushp1pt Tony Wallace made changes -
          Field Original Value New Value
          Attachment image-2021-04-06-11-28-09-379.png [ 54407 ]
          hushp1pt Tony Wallace made changes -
          Attachment image-2021-04-06-11-29-35-673.png [ 54408 ]
          hushp1pt Tony Wallace added a comment -

          the job config page, screen 1

          hushp1pt Tony Wallace added a comment - the job config page, screen 1
          hushp1pt Tony Wallace made changes -
          Attachment image-2021-04-06-11-31-49-157.png [ 54409 ]
          hushp1pt Tony Wallace added a comment -

          hushp1pt Tony Wallace added a comment -
          hushp1pt Tony Wallace made changes -
          Description Publish Over CIFS job config mishandles publishWhenFailed in job's config.xml

          If you open the job config page, set the publishWhenFailed attribute to true, and save the job config, the attribute value true is written in the job's config.xml file, as expected. 

          However, if you open the job config page again and look at the publishWhenFailed attribute, the value show up as false.  Then if you save the job config then, the attribute value in the job config.xml file is false. 

          Examining the jobs config.xml file, I notice the publishWhenFailed attribute does not look like it is in the right place. 

          More info follows as comments and/or attachments.
          Publish Over CIFS job config mishandles publishWhenFailed in job's config.xml

          If you open the job config page, set the publishWhenFailed attribute to true, and save the job config, the attribute value true is written in the job's config.xml file, as expected. 

          However, if you open the job config page again and look at the publishWhenFailed attribute, the value show up as false.  Then if you save the job config then, the attribute value in the job config.xml file is false. 

          As a result, you are going to end up with a publishWhenFailed value of false, unless you remember to reset it to true every time you edit the job config for any reason. 

          Examining the jobs config.xml file, I notice the publishWhenFailed attribute does not look like it is in the right place. 

          More info follows as comments and/or attachments.

          For your information, all publish-over-cifs component type JENKINS issues related to the Publish Over CIFS plugin have been transferred to Github: https://github.com/jenkinsci/publish-over-cifs-plugin/issues

          Here is the direct link to this issue in Github: https://github.com/jenkinsci/publish-over-cifs-plugin/issues/91
          And here is the link to a search for related issues: https://github.com/jenkinsci/publish-over-cifs-plugin/issues?q=%22JENKINS-65294%22

          (Note: this is an automated bulk comment)

          gmcdonald Gavin McDonald added a comment - For your information, all publish-over-cifs component type JENKINS issues related to the Publish Over CIFS plugin have been transferred to Github: https://github.com/jenkinsci/publish-over-cifs-plugin/issues Here is the direct link to this issue in Github: https://github.com/jenkinsci/publish-over-cifs-plugin/issues/91 And here is the link to a search for related issues: https://github.com/jenkinsci/publish-over-cifs-plugin/issues?q=%22JENKINS-65294%22 (Note: this is an automated bulk comment)

          This issue has been closed - please see the new Github Issue for this in the previous comment.

          gmcdonald Gavin McDonald added a comment - This issue has been closed - please see the new Github Issue for this in the previous comment.
          gmcdonald Gavin McDonald made changes -
          Resolution Incomplete [ 4 ]
          Status Open [ 1 ] Closed [ 6 ]

          People

            Unassigned Unassigned
            hushp1pt Tony Wallace
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: