Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-65398

Terminology update for master, whitelist, blacklist

    XMLWordPrintable

Details

    • Epic
    • Status: Open (View Workflow)
    • Minor
    • Resolution: Unresolved
    • core
    • None
    • Terminology update for master, slave, whitelist, blacklist

    Description

      In July 2020 we  adopted the "controller" term instead of "master", and deprecated the "whitelist/blacklist" terms. There are many places where the old terminology still needs to be replaced.

      For example, deprecated term can be:

      • in UI files, like *.jelly, *.groovy, *.html
      • in logs that ends up in job console, or Jenkins console
      • in cli output
      • HTTP API
      • Documentation, README, code comments

      Changing master in other context (like git or any scm master branch) is out of scope of this Epic.
      We invite contributors to join us and participate in cleaning up Jenkins documentation, Web and CLI interfaces, and the codebase.

      Deprecated term To be replaced by
      master built-in when used for node/label
      controller (for everything else)
      slave agent (please use https://issues.jenkins.io/browse/JENKINS-42816 )
      whitelist allowlist (default but can be adapted to context)
      blacklist denylist or blocklist (default but can be adapted to context)

      If you are working on slave/agent replacement please use https://issues.jenkins.io/browse/JENKINS-42816

      Attachments

        Issue Links

          Activity

            ajard A. Jard added a comment - - edited Some PR linked to this Epic https://github.com/jenkinsci/credentials-plugin/pull/197 – merged https://github.com/jenkinsci/gradle-plugin/pull/115 – merged https://github.com/jenkinsci/junit-plugin/pull/268 – merged https://github.com/jenkinsci/kubernetes-plugin/pull/981 – merged https://github.com/jenkinsci/git-plugin/pull/1077 – merged https://github.com/jenkinsci/config-file-provider-plugin/pull/117 – merged https://github.com/jenkinsci/ldap-plugin/pull/89 – merged https://github.com/jenkinsci/metrics-plugin/pull/98 – merged https://github.com/jenkinsci/credentials-binding-plugin/pull/128 – merged https://github.com/jenkinsci/ssh-slaves-plugin/pull/226 – merged https://github.com/jenkinsci/support-core-plugin/pull/227 – merged https://github.com/jenkinsci/windows-slaves-plugin/pull/32 – merged https://github.com/jenkinsci/docker-build-publish-plugin/pull/60 https://github.com/jenkinsci/promoted-builds-plugin/pull/152
            oleg_nenashev Oleg Nenashev added a comment -

            Should we keep agent cleanup in JENKINS-42816  ?

             

            oleg_nenashev Oleg Nenashev added a comment - Should we keep agent cleanup in  JENKINS-42816   ?  
            ajard A. Jard added a comment -

            oleg_nenashev I have no strong opinion, I don't think that there are PRs with agent renaming only (it's often mainly controller and some agent in the way), but we can link both Epic maybe. But I can update the description to redirect to the other Epic for agent (I like to see the mapping all old word -> new word in one place).

            ajard A. Jard added a comment - oleg_nenashev I have no strong opinion, I don't think that there are PRs with agent renaming only (it's often mainly controller and some agent in the way), but we can link both Epic maybe. But I can update the description to redirect to the other Epic for agent (I like to see the mapping all old word -> new word in one place).
            ajard A. Jard added a comment -

            I have updated the description with a link to Agent renaming Epic, I hope it fits all needs

            ajard A. Jard added a comment - I have updated the description with a link to Agent renaming Epic, I hope it fits all needs
            kerogers Kenneth Rogers added a comment - Another PR for this epic https://github.com/jenkinsci/workflow-api-plugin/pull/147
            amuniz Antonio Muñiz added a comment - One more https://github.com/jenkinsci/pubsub-light-plugin/pull/35
            vlatombe Vincent Latombe added a comment - https://github.com/jenkinsci/workflow-durable-task-step-plugin/pull/160 https://github.com/jenkinsci/copyartifact-plugin/pull/138 https://github.com/jenkinsci/command-launcher-plugin/pull/19
            ikedam ikedam added a comment -

            Rewriting changelogs may feel strange for maintainers.
            (I actually once considered to finish the review with "Request changes" in copyartifact-plugin)

            It would be helpful to clarify that it's expected to update even changelogs as the Jenkins community policy
            though it's finally up to maintainers whether they update changelogs.
            (I believe it's the community policy according to https://github.com/jenkins-infra/jenkins.io/pull/4302 .)

            ikedam ikedam added a comment - Rewriting changelogs may feel strange for maintainers. (I actually once considered to finish the review with "Request changes" in copyartifact-plugin) It would be helpful to clarify that it's expected to update even changelogs as the Jenkins community policy though it's finally up to maintainers whether they update changelogs. (I believe it's the community policy according to https://github.com/jenkins-infra/jenkins.io/pull/4302 .)
            ajard A. Jard added a comment -

            I don't rewrite changelogs, I feel that we shouldn't change the past but maybe I am wrong. I don't have strong opinion, not sure that there is an community agreement.

            ajard A. Jard added a comment - I don't rewrite changelogs, I feel that we shouldn't change the past but maybe I am wrong. I don't have strong opinion, not sure that there is an community agreement.
            ikedam ikedam added a comment -

            I want a guideline for cases where plugins contain translations that maintainer cannot maintain.

            • Create tickets for those translations.
            • Leave TODO file or TODO comments in files.
            • Remove translations supposed to contain terminologies that should be update.

            reference: https://github.com/jenkinsci/copyartifact-plugin/pull/138/commits/7bbbafa5ad81e70d1a404e2eb88977c31602ed3d#r639029081

            ikedam ikedam added a comment - I want a guideline for cases where plugins contain translations that maintainer cannot maintain. Create tickets for those translations. Leave TODO file or TODO comments in files. Remove translations supposed to contain terminologies that should be update. reference: https://github.com/jenkinsci/copyartifact-plugin/pull/138/commits/7bbbafa5ad81e70d1a404e2eb88977c31602ed3d#r639029081

            People

              Unassigned Unassigned
              ajard A. Jard
              Votes:
              0 Vote for this issue
              Watchers:
              6 Start watching this issue

              Dates

                Created:
                Updated: