Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-66322

Prepare Gravatar for core Guava upgrade

    XMLWordPrintable

    Details

    • Similar Issues:

      Description

      See JENKINS-65988. Jenkins core is using Guava 11.0.1, which was released on January 9, 2012. Jenkins core would like to upgrade to Guava 30.1.1, which was released on March 19, 2021. Plugins must be prepared to be compatible with both Guava 11.0.1 and Guava 30.1.1 in advance of this core transition.

      In particular, this plugin has been identified as using the com.google.common.base.Objects#toStringHelper method, which existed in Guava 11.0.1 but was removed in later versions.

      To facilitate the Jenkins core transition, this plugin must be prepared and released such that it works with both Guava 11.0.1 and latest. The general recommendation is to migrate away from Objects#toStringHelper and rewrite the code to use the native functionality provided by the Java Platform. Another option is to use Apache Commons Lang 2.4 (which is bundled in Jenkins core) and its org.apache.commons.lang.builder.ToStringBuilder API.

        Attachments

          Activity

          basil Basil Crow created issue -
          basil Basil Crow made changes -
          Field Original Value New Value
          Assignee redsolo [ redsolo ] Simon Gamma [ cappuccino ]
          timja Tim Jacomb made changes -
          Status Open [ 1 ] In Progress [ 3 ]
          timja Tim Jacomb made changes -
          Status In Progress [ 3 ] In Review [ 10005 ]
          timja Tim Jacomb made changes -
          Remote Link This issue links to "https://github.com/jenkinsci/gravatar-plugin/pull/6 (Web Link)" [ 26854 ]
          Hide
          timja Tim Jacomb added a comment -

          Likely not release-able in it's current state, needs a re-fresh and likely an adoption

          Show
          timja Tim Jacomb added a comment - Likely not release-able in it's current state, needs a re-fresh and likely an adoption
          Hide
          cappuccino Simon Gamma added a comment -

          Tim Jacomb I have reimplemented your PR and modernized the pom, such that a new release should be possible to be triggered. See: https://github.com/jenkinsci/gravatar-plugin/pull/7

          Show
          cappuccino Simon Gamma added a comment - Tim Jacomb  I have reimplemented your PR and modernized the pom, such that a new release should be possible to be triggered. See:  https://github.com/jenkinsci/gravatar-plugin/pull/7
          Hide
          timja Tim Jacomb added a comment -

          Thanks!

          Show
          timja Tim Jacomb added a comment - Thanks!
          basil Basil Crow made changes -
          Resolution Fixed [ 1 ]
          Status In Review [ 10005 ] Fixed but Unreleased [ 10203 ]
          Hide
          basil Basil Crow added a comment -

          Fixed in jenkinsci/gravatar-plugin#7. Released in 2.2.

          Show
          basil Basil Crow added a comment - Fixed in jenkinsci/gravatar-plugin#7 . Released in 2.2 .
          basil Basil Crow made changes -
          Status Fixed but Unreleased [ 10203 ] Resolved [ 5 ]
          basil Basil Crow made changes -
          Labels JEP-233

            People

            Assignee:
            cappuccino Simon Gamma
            Reporter:
            basil Basil Crow
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved: