Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-66427

Prepare RocketChat Notifier for core Guava upgrade

    XMLWordPrintable

Details

    • 1.4.10

    Description

      See JENKINS-65988. Jenkins core is using Guava 11.0.1, which was released on January 9, 2012. Jenkins core would like to upgrade to Guava 30.1.1, which was released on March 19, 2021. Plugins must be prepared to be compatible with both Guava 11.0.1 and Guava 30.1.1 in advance of this core transition.

      In particular, this plugin has been identified as using the com.google.common.base.Objects#toStringHelper method, which existed in Guava 11.0.1 but was removed in later versions.

      To facilitate the Jenkins core transition, this plugin must be prepared and released such that it works with both Guava 11.0.1 and latest. The general recommendation is to migrate away from Objects#toStringHelper and rewrite the code to use the native functionality provided by the Java Platform. Another option is to use Apache Commons Lang 2.4 (which is bundled in Jenkins core) and its org.apache.commons.lang.builder.ToStringBuilder API.

      Attachments

        Activity

          basil Basil Crow created issue -
          basil Basil Crow made changes -
          Field Original Value New Value
          Status Open [ 1 ] In Progress [ 3 ]
          basil Basil Crow made changes -
          Status In Progress [ 3 ] In Review [ 10005 ]
          basil Basil Crow made changes -
          Remote Link This issue links to "jenkinsci/rocketchatnotifier-plugin#197 (Web Link)" [ 26883 ]
          basil Basil Crow added a comment -

          mreinhardt, would you be interested in taking a look at the PR I opened?

          basil Basil Crow added a comment - mreinhardt , would you be interested in taking a look at the PR I opened ?
          mreinhardt Martin Reinhardt made changes -
          Resolution Fixed [ 1 ]
          Status In Review [ 10005 ] Resolved [ 5 ]
          mreinhardt Martin Reinhardt made changes -
          Assignee Martin Reinhardt [ mreinhardt ]
          basil Basil Crow added a comment -

          Thanks!

          Fixed in jenkinsci/rocketchatnotifier-plugin#197. Released in 1.4.10.

          basil Basil Crow added a comment - Thanks! Fixed in jenkinsci/rocketchatnotifier-plugin#197 . Released in 1.4.10 .
          basil Basil Crow made changes -
          Released As 1.4.10
          basil Basil Crow made changes -
          Labels JEP-233
          basil Basil Crow made changes -
          Status Resolved [ 5 ] Closed [ 6 ]

          People

            Unassigned Unassigned
            basil Basil Crow
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: