• Icon: Bug Bug
    • Resolution: Fixed
    • Icon: Minor Minor
    • deploy-plugin
    • None
    • PLD Linux th, tomcat-7.0.0-rc4

      I'm trying to deploy hudson 1.361 into tomcat 7.0.0 rc4. (In fact I had working installation of hudson in tomcat 6.0.26 and I just upgraded tomcat, but I have same issue on fresh install).

      Tomcat says: 'OK - Started application at context path /hudson, but when I navigate to /hudson/, I'm getting e404', but when I navigate to /hudson/, I get HTTP 404 NOT FOUND error.
      There are no errors exceptions in catalina log. I tried on java-sun-1.6.0.20 and Icedtea6, same problem on both.

      My context.xml is:

      # cat /etc/tomcat/Catalina/localhost/hudson.xml                                                     
      <?xml version="1.0" encoding="UTF-8"?>
      <!-- $Id: hudson-context.xml,v 1.2 2009/02/01 23:26:40 pawelz Exp $ -->
      <Context path="/hudson" docBase="/usr/share/hudson"
              privileged="false" allowLinking="true">
      
      </Context>
      

      (same context works perfectly with tomcat-6.0.26)

      Please let me know if I can provide you with more details/information. I have testing environment, where I can test patches/workarounds/etc.

      PS.: I'm setting "Priority" to minor, because tomcat-7.0.0-rc4 is not released yet, and after downgrade to tomcat-6.0.26 everything works.
      PS2.: I'm not 1000% sure, that my tomcat is configured correctly, I'm just experimenting with tomcat 7 branch. But other applications (like for example Atlassian JIRA) works.

          [JENKINS-6738] Hudson doesn't start on tomcat 7

          jieryn added a comment -

          Change this to

          <servlet-mapping>
            <servlet-name>Stapler</servlet-name>
            <url-pattern>/*</url-pattern>
          </servlet-mapping>

          and it will work. I tested this and things appear to be working sanely now.

          jieryn added a comment - Change this to <servlet-mapping> <servlet-name>Stapler</servlet-name> <url-pattern>/*</url-pattern> </servlet-mapping> and it will work. I tested this and things appear to be working sanely now.

          According to the servlet 2.5 spec section SRV.11.2,

          • A string containing only the '/' character indicates the "default" servlet of the application. In this case the servlet path is the request URI minus the context path and the path info is null.

          So I claim that '/' is valid according to the servlet spec.

          Kohsuke Kawaguchi added a comment - According to the servlet 2.5 spec section SRV.11.2, A string containing only the '/' character indicates the "default" servlet of the application. In this case the servlet path is the request URI minus the context path and the path info is null. So I claim that '/' is valid according to the servlet spec.

          pzz added a comment -

          I have also reported it in tomcat bugzilla, see https://issues.apache.org/bugzilla/show_bug.cgi?id=49422

          pzz added a comment - I have also reported it in tomcat bugzilla, see https://issues.apache.org/bugzilla/show_bug.cgi?id=49422

          Alan Harder added a comment -

          Per Kohsuke's comment above, "/" is valid per the servlet spec. We hope that Tomcat 7 will fix this prior to their next beta/final release (or we'll surely hear about this again!)

          Alan Harder added a comment - Per Kohsuke's comment above, "/" is valid per the servlet spec. We hope that Tomcat 7 will fix this prior to their next beta/final release (or we'll surely hear about this again!)

          jieryn added a comment -

          Tomcat closed that issue as INVALID, they believe they are strictly adhering to the specification. Specification debates aside, is there some reason we can not just migrate to /* ? I tested this in Tomcat 7 and it works properly, but did not check embedded Winstone, or any other popular containers.

          Tomcat 7 has some unusual naming conventions for its releases, but they just announced a 7.0-BETA. The release manager stated that he'd like to get the first stable release out in 4 weeks or less. http://www.tomcatexpert.com/blog/2010/06/29/apache-tomcat-7-has-been-released

          So I expect we're going to see a lot more Hudson users deploying to Tomcat 7 soonish... It would be nice if we didn't have to answer mailing list messages or spurious bug reports about Hudson not working.

          jieryn added a comment - Tomcat closed that issue as INVALID, they believe they are strictly adhering to the specification. Specification debates aside, is there some reason we can not just migrate to /* ? I tested this in Tomcat 7 and it works properly, but did not check embedded Winstone, or any other popular containers. Tomcat 7 has some unusual naming conventions for its releases, but they just announced a 7.0-BETA. The release manager stated that he'd like to get the first stable release out in 4 weeks or less. http://www.tomcatexpert.com/blog/2010/06/29/apache-tomcat-7-has-been-released So I expect we're going to see a lot more Hudson users deploying to Tomcat 7 soonish... It would be nice if we didn't have to answer mailing list messages or spurious bug reports about Hudson not working.

          jieryn added a comment -

          See comment above.

          jieryn added a comment - See comment above.

          I still don't agree that this is our fault, and I've updated https://issues.apache.org/bugzilla/show_bug.cgi?id=49422 accordingly.

          But in the mean time, I guess it'd wise to work around this issue in Hudson.

          I'll try the "empty welcome file list" approach that Mark suggested to see if that does the trick, as that seems least likely to cause regressions with other containers.

          Kohsuke Kawaguchi added a comment - I still don't agree that this is our fault, and I've updated https://issues.apache.org/bugzilla/show_bug.cgi?id=49422 accordingly. But in the mean time, I guess it'd wise to work around this issue in Hudson. I'll try the "empty welcome file list" approach that Mark suggested to see if that does the trick, as that seems least likely to cause regressions with other containers.

          Empty welcome file list didn't work. Apparently the default web.xml in Tomcat also must have no welcome file list.

          Kohsuke Kawaguchi added a comment - Empty welcome file list didn't work. Apparently the default web.xml in Tomcat also must have no welcome file list.

          Code changed in hudson
          User: : kohsuke
          Path:
          trunk/hudson/main/war/resources/WEB-INF/web.xml
          trunk/www/changelog.html
          http://jenkins-ci.org/commit/33149
          Log:
          [FIXED JENKINS-6738] changed the servlet mapping to /* to make it work with Tomcat. My fingers are crossed that this doesn't cause regressions elsewhere.

          SCM/JIRA link daemon added a comment - Code changed in hudson User: : kohsuke Path: trunk/hudson/main/war/resources/WEB-INF/web.xml trunk/www/changelog.html http://jenkins-ci.org/commit/33149 Log: [FIXED JENKINS-6738] changed the servlet mapping to /* to make it work with Tomcat. My fingers are crossed that this doesn't cause regressions elsewhere.

          Régis Desgroppes added a comment - - edited

          Using a proxied Winstone with Security Realm set to "Delegate to servlet container", I had to restore:

          <servlet-mapping>
            <servlet-name>Stapler</servlet-name>
            <url-pattern>/</url-pattern>
          </servlet-mapping>
          

          ... otherwise (with /*) hudson.security.BasicAuthenticationFilter::doFilter() works with an empty path, with the effect that my browser faces a infinite redirect loop.

          This is no surprise, according to javax.servlet.http.HttpServletRequest::getServletPath():

              Returns:
                  a String containing the name or path of the servlet being called, as specified in the request URL, decoded, or an empty string if the servlet used to process the request is matched using the "/*" pattern.
          

          Interestingly, I'm referring to Tomcat 7 hosted Servlet documentation: http://tomcat.apache.org/tomcat-7.0-doc/servletapi/javax/servlet/http/HttpServletRequest.html#getServletPath%28%29

          In my opinion, the workaround should be reverted since it comes from a misinterpretation.

          Régis Desgroppes added a comment - - edited Using a proxied Winstone with Security Realm set to "Delegate to servlet container", I had to restore: <servlet-mapping> <servlet-name> Stapler </servlet-name> <url-pattern> / </url-pattern> </servlet-mapping> ... otherwise (with /*) hudson.security.BasicAuthenticationFilter::doFilter() works with an empty path, with the effect that my browser faces a infinite redirect loop. This is no surprise, according to javax.servlet.http.HttpServletRequest::getServletPath(): Returns: a String containing the name or path of the servlet being called, as specified in the request URL, decoded, or an empty string if the servlet used to process the request is matched using the "/*" pattern. Interestingly, I'm referring to Tomcat 7 hosted Servlet documentation: http://tomcat.apache.org/tomcat-7.0-doc/servletapi/javax/servlet/http/HttpServletRequest.html#getServletPath%28%29 In my opinion, the workaround should be reverted since it comes from a misinterpretation.

            kohsuke Kohsuke Kawaguchi
            pzz pzz
            Votes:
            2 Vote for this issue
            Watchers:
            5 Start watching this issue

              Created:
              Updated:
              Resolved: