-
Improvement
-
Resolution: Fixed
-
Minor
-
None
-
jenkins-2.164.3
jenkins-2.343
-
-
2.347
Found in https://github.com/jenkinsci/copyartifact-plugin/pull/147.
Class attributes of layout:icon custom tag are used to specify icons, and extra developer-defined class results to fail to find icon.
It blocks plugins migrating img to layout:icon, which triggered by https://github.com/jenkinsci/jenkins/pull/5778 .
TODO:
Test with the latest core-> Verified reproduction with Jenkins 2.343- Resolve the issue with:
- A: ignore classes without icon- prefixes
- B: add extraClass attribute
- C: update document, and allow developers to use src if they want to specify extra class.
- Actually, documentation of layout:icon looks buggy as it states that src is ignored if class is specified (but actually, src is checked first): https://github.com/jenkinsci/jenkins/blob/jenkins-2.343/core/src/main/resources/lib/layout/icon.jelly
[JENKINS-68286] layout:icon doesn't accept extra class attribute
Description |
Original:
Found in https://github.com/jenkinsci/copyartifact-plugin/pull/147.
Class attributes of layout:icon custom tag are used to specify icons, and extra developer-defined class results to fail to find icon. It blocks plugins migrating img to layout:icon, which triggered by https://github.com/jenkinsci/jenkins/pull/5778 . TODO: * Test with the latest core * Resolve the issue with: ** A: ignore classes without icon- prefixes ** B: add extraClass attribute ** C: update document, and allow developers to use src if they want to specify extra class. *** Actually, documentation of layout:icon looks buggy as it states that src is ignored if class is specified (but actually, src is checked first): https://github.com/jenkinsci/jenkins/blob/jenkins-2.343/core/src/main/resources/lib/layout/icon.jelly |
New:
Found in https://github.com/jenkinsci/copyartifact-plugin/pull/147.
Class attributes of layout:icon custom tag are used to specify icons, and extra developer-defined class results to fail to find icon. It blocks plugins migrating img to layout:icon, which triggered by https://github.com/jenkinsci/jenkins/pull/5778 . TODO: * -Test with the latest core- -> Verified reproduction with Jenkins 2.343 * Resolve the issue with: ** A: ignore classes without icon- prefixes ** B: add extraClass attribute ** C: update document, and allow developers to use src if they want to specify extra class. *** Actually, documentation of layout:icon looks buggy as it states that src is ignored if class is specified (but actually, src is checked first): https://github.com/jenkinsci/jenkins/blob/jenkins-2.343/core/src/main/resources/lib/layout/icon.jelly |
Environment |
Original:
jenkins-2.164.3
Not tested with newer cores, but I believe this affects also the latest core, jenkins-2.343) |
New:
jenkins-2.164.3
jenkins-2.343 |
Status | Original: Open [ 1 ] | New: In Progress [ 3 ] |
Status | Original: In Progress [ 3 ] | New: In Review [ 10005 ] |
Remote Link | New: This issue links to "https://github.com/jenkinsci/jenkins/pull/6510 (Web Link)" [ 27704 ] |
Icons are registered with `IconSet.icons.addIcon`: https://github.com/jenkinsci/jenkins/blob/jenkins-2.344/core/src/main/java/org/jenkins/ui/icon/IconSet.java#L145
Built-in icons: