Level medium (due to lack of reproduction steps yet)
      Skills a bit of JavaScript, a bit of Jelly

      Culprit: failed-test.jelly#L38-L59

      UPDATE: the inline script was moved to an external file, but the onClick handlers are still inline.

      Reproduction steps:

      • missing

      Proposal

      Testing notes

      • Ensure to reproduce the feature before any change
      • Ensure that you reproduce the feature after you have made the change

          [JENKINS-69658] [junit] Un-inlining failed-test.jelly

          Himanshu . added a comment -

          Hi!
          i would like to work on this issue, my GitHUbusername is Himanshu007-creator, and ill raise a PR soon. Thanks

          Himanshu . added a comment - Hi! i would like to work on this issue, my GitHUbusername is Himanshu007-creator, and ill raise a PR soon. Thanks

          himanshu007creator do not hesitate to assign the ticket to you and update the status when you start working on it, that will prevent other people to pick that ticket

          Wadeck Follonier added a comment - himanshu007creator do not hesitate to assign the ticket to you and update the status when you start working on it, that will prevent other people to pick that ticket

          Arthur CARON added a comment - - edited

          Hi,
          I don't want to steal you this ticket himanshu007creator but can I pick it ?

          Arthur CARON added a comment - - edited Hi, I don't want to steal you this ticket himanshu007creator but can I pick it ?

          Arthur CARON added a comment - - edited

          wfollonier tell me if I'm wrong, but I think that this issue is already done.

          the commit!

          Arthur CARON added a comment - - edited wfollonier tell me if I'm wrong, but I think that this issue is already done. the commit!

          lemomorse Interesting point. Between my analysis in https://docs.google.com/spreadsheets/d/1Jr5FpkAN-FjTd0D_VLz00Ab5iXNiCK03fUs2JR2omXQ on JUnit (date = 2022-09-20), the linked change was made and merged on 2022-10-03.

          Now, the PR does not correct "completely" the issue. There are still two onClick events at the bottom of that page. Link: failed-test.jelly#L66-L69

          Wadeck Follonier added a comment - lemomorse  Interesting point. Between my analysis in https://docs.google.com/spreadsheets/d/1Jr5FpkAN-FjTd0D_VLz00Ab5iXNiCK03fUs2JR2omXQ on JUnit (date = 2022-09-20), the linked change was made and merged on 2022-10-03. Now, the PR does not correct "completely" the issue. There are still two onClick events at the bottom of that page. Link: failed-test.jelly#L66-L69

          lemomorse PR discussion cont'd:

          To reproduce the issue from https://github.com/jenkinsci/junit-plugin/pull/451#discussion_r1008147453 you can just mvn test the project with a failing test. I've used a utility repo of mine: https://github.com/yaroslavafenkin/security-notifier/tree/fail. It's public so feel free to re-use that if you want, it has a single test that just fails, and then you can navigate to the report.
          Let me know if that's enough or if you want me to provide more concrete steps.

          Yaroslav Afenkin added a comment - lemomorse PR discussion cont'd: To reproduce the issue from https://github.com/jenkinsci/junit-plugin/pull/451#discussion_r1008147453 you can just mvn test the project with a failing test. I've used a utility repo of mine: https://github.com/yaroslavafenkin/security-notifier/tree/fail . It's public so feel free to re-use that if you want, it has a single test that just fails, and then you can navigate to the report. Let me know if that's enough or if you want me to provide more concrete steps.

          Shlomo added a comment -

          Both of the related PRs have been merged. 

          Can this issue be closed?

          Shlomo added a comment - Both of the related PRs have been merged.  Can this issue be closed?

            shlomo_dahan Shlomo
            wfollonier Wadeck Follonier
            Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

              Created:
              Updated:
              Resolved: