Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-7118

Add a field where the path to a global property file can be specified

    XMLWordPrintable

    Details

    • Similar Issues:

      Description

      In Buckminster 3.6, it's possible to pass a -P <property file> to all commands. I therefore propose an additional field where a path to this file can be provided. This will be particularly useful when running a script but will also help when commands are specified individually. In the latter case, the property file could be added when the resulting script is executed.

        Attachments

          Activity

          Hide
          jutzig jutzig added a comment -

          Hi Thomas,

          can you elaborate some more on what exactly you had in mind?
          This new -P is passed as an argument to buckminster itself or for each individual command?
          If it's for each individual command you propose to insert a "-P fil"e into each command unless the command already specifies a -P?
          But how'd that work if the user executes a script file? Should the script file be rewritten, or create a new file instead that contains the -P parameter for each command?
          Is this new functionality described in the bucky book already, so I can look it up for reference?

          Show
          jutzig jutzig added a comment - Hi Thomas, can you elaborate some more on what exactly you had in mind? This new -P is passed as an argument to buckminster itself or for each individual command? If it's for each individual command you propose to insert a "-P fil"e into each command unless the command already specifies a -P? But how'd that work if the user executes a script file? Should the script file be rewritten, or create a new file instead that contains the -P parameter for each command? Is this new functionality described in the bucky book already, so I can look it up for reference?
          Hide
          thhal thhal added a comment -

          Hi Johannes,

          The -P <file or URL> can be sent to buckminster itself, just like --loglevel etc.

          If I understand it correctly, the Hudson plug-in will always use a Buckminster script. Either the one provided in the config or one that it assembles from the given commands. What I propose is that the full script can be executed using the -P option. If -P is also given to individual commands, that's fine so no particular action needs to be taken there. Such properties will be merged automatically when the command executes.

          Show
          thhal thhal added a comment - Hi Johannes, The -P <file or URL> can be sent to buckminster itself, just like --loglevel etc. If I understand it correctly, the Hudson plug-in will always use a Buckminster script. Either the one provided in the config or one that it assembles from the given commands. What I propose is that the full script can be executed using the -P option. If -P is also given to individual commands, that's fine so no particular action needs to be taken there. Such properties will be merged automatically when the command executes.
          Hide
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in hudson
          User: : jutzig
          Path:
          trunk/hudson/plugins/buckminster/src/main/java/hudson/plugins/buckminster/EclipseBuckminsterBuilder.java
          trunk/hudson/plugins/buckminster/src/main/java/hudson/plugins/buckminster/command/CommandLineBuilder.java
          trunk/hudson/plugins/buckminster/src/main/resources/hudson/plugins/buckminster/EclipseBuckminsterBuilder/config.jelly
          trunk/hudson/plugins/buckminster/src/main/webapp/help-globalProperties.html
          trunk/hudson/plugins/buckminster/src/main/webapp/help-globalProperties_de.html
          trunk/hudson/plugins/buckminster/src/test/java/hudson/plugins/buckminster/command/CommandLineBuilderTest.java
          http://jenkins-ci.org/commit/35679
          Log:
          JENKINS-7118: Add a field where the path to a global property file can be specified
          http://issues.jenkins-ci.org/browse/JENKINS-7118

          Show
          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in hudson User: : jutzig Path: trunk/hudson/plugins/buckminster/src/main/java/hudson/plugins/buckminster/EclipseBuckminsterBuilder.java trunk/hudson/plugins/buckminster/src/main/java/hudson/plugins/buckminster/command/CommandLineBuilder.java trunk/hudson/plugins/buckminster/src/main/resources/hudson/plugins/buckminster/EclipseBuckminsterBuilder/config.jelly trunk/hudson/plugins/buckminster/src/main/webapp/help-globalProperties.html trunk/hudson/plugins/buckminster/src/main/webapp/help-globalProperties_de.html trunk/hudson/plugins/buckminster/src/test/java/hudson/plugins/buckminster/command/CommandLineBuilderTest.java http://jenkins-ci.org/commit/35679 Log: JENKINS-7118 : Add a field where the path to a global property file can be specified http://issues.jenkins-ci.org/browse/JENKINS-7118
          Hide
          jutzig jutzig added a comment -

          Added a new field to enter a global properties file in the advanced section.
          Fix released to TRUNK rev. 35679, will be available in the next plugin release.

          Show
          jutzig jutzig added a comment - Added a new field to enter a global properties file in the advanced section. Fix released to TRUNK rev. 35679, will be available in the next plugin release.
          Hide
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in hudson
          User: : jutzig
          Path:
          trunk/hudson/plugins/buckminster/src/main/resources/hudson/plugins/buckminster/EclipseBuckminsterBuilder/config.jelly
          http://jenkins-ci.org/commit/35680
          Log:
          JENKINS-7118: Add a field where the path to a global property file can be specified
          http://issues.jenkins-ci.org/browse/JENKINS-7118
          fixed typo in config.jelly

          Show
          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in hudson User: : jutzig Path: trunk/hudson/plugins/buckminster/src/main/resources/hudson/plugins/buckminster/EclipseBuckminsterBuilder/config.jelly http://jenkins-ci.org/commit/35680 Log: JENKINS-7118 : Add a field where the path to a global property file can be specified http://issues.jenkins-ci.org/browse/JENKINS-7118 fixed typo in config.jelly

            People

            Assignee:
            jutzig jutzig
            Reporter:
            thhal thhal
            Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved: