Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-7138

Persist matrix-based security settings in a consistent order

    XMLWordPrintable

    Details

    • Type: Improvement
    • Status: Closed (View Workflow)
    • Priority: Minor
    • Resolution: Fixed
    • Component/s: core
    • Labels:
      None
    • Environment:
      Hudson 1.369
    • Similar Issues:

      Description

      When "Matrix-based security" or "Project-based Matrix Authorization Strategy" authorization is selected, the permissions are persisted in a different order on each save.

      Storing them in a consistent order would make it easier to read diffs of config.xml.

        Attachments

          Activity

          stevengbrown Steven G Brown created issue -
          StevenGBrown StevenGBrown made changes -
          Field Original Value New Value
          Status Open [ 1 ] In Progress [ 3 ]
          StevenGBrown StevenGBrown made changes -
          Priority Major [ 3 ] Minor [ 4 ]
          Hide
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in hudson
          User: : StevenGBrown
          Path:
          trunk/hudson/main/core/src/main/java/hudson/security/GlobalMatrixAuthorizationStrategy.java
          trunk/hudson/main/core/src/main/java/hudson/security/Permission.java
          trunk/www/changelog.html
          http://jenkins-ci.org/commit/33594
          Log:
          [FIXED JENKINS-7138] GlobalMatrixAuthorizationStrategy (and ProjectMatrixAuthorizationStrategy since it subclasses the Converter) now sorts the permissions before persisting them.

          Show
          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in hudson User: : StevenGBrown Path: trunk/hudson/main/core/src/main/java/hudson/security/GlobalMatrixAuthorizationStrategy.java trunk/hudson/main/core/src/main/java/hudson/security/Permission.java trunk/www/changelog.html http://jenkins-ci.org/commit/33594 Log: [FIXED JENKINS-7138] GlobalMatrixAuthorizationStrategy (and ProjectMatrixAuthorizationStrategy since it subclasses the Converter) now sorts the permissions before persisting them.
          scm_issue_link SCM/JIRA link daemon made changes -
          Resolution Fixed [ 1 ]
          Status In Progress [ 3 ] Resolved [ 5 ]
          abayer Andrew Bayer made changes -
          Status Resolved [ 5 ] Closed [ 6 ]
          rtyler R. Tyler Croy made changes -
          Workflow JNJira [ 137235 ] JNJira + In-Review [ 204434 ]

            People

            Assignee:
            stevengbrown Steven G Brown
            Reporter:
            stevengbrown Steven G Brown
            Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved: